Your message dated Sat, 17 Dec 2011 15:29:59 +0000 with message-id <[email protected]> and subject line Bug#649901: fixed in trousers 0.3.7-2 has caused the Debian Bug report #649901, regarding Init script should check if the daemon has actually started to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 649901: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=649901 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: trousers Version: 0.3.5-2 Severity: normal Tags: patch Hi, I think that the init script shouldn't use the --background option as it prevents start-stop-daemon to check if the daemon has really started. According to the manpage of start-stop-daemon: -b, --background Typically used with programs that don't detach on their own. This option will force start-stop-daemon to fork before starting the process, and force it into the background. WARNING: start-stop-daemon cannot check the exit status if the process fails to execute for any reason. This is a last resort, and is only meant for programs that either make no sense forking on their own, or where it's not feasible to add the code for them to do this themselves. See the attached patch (not tested though). I think I'm the one to blame for this :) Cheers Laurent Bigonvillediff -Nru trousers-0.3.7/debian/trousers.init trousers-0.3.7/debian/trousers.init --- trousers-0.3.7/debian/trousers.init 2011-11-21 21:11:52.000000000 +0100 +++ trousers-0.3.7/debian/trousers.init 2011-11-24 18:32:14.000000000 +0100 @@ -35,9 +35,10 @@ exit 0 fi - start-stop-daemon --start --quiet --background --make-pid --pidfile /var/run/${NAME}.pid --user ${USER} --chuid ${USER} --exec ${DAEMON} -- -f ${DAEMON_OPTS} + start-stop-daemon --start --quiet --pidfile /var/run/${NAME}.pid --user ${USER} --chuid ${USER} --exec ${DAEMON} -- ${DAEMON_OPTS} RETVAL="$?" log_end_msg $RETVAL + [ "$RETVAL" = 0 ] && pidofproc $DAEMON > /var/run/${NAME}.pid exit $RETVAL ;;
--- End Message ---
--- Begin Message ---Source: trousers Source-Version: 0.3.7-2 We believe that the bug you reported is fixed in the latest version of trousers, which is due to be installed in the Debian FTP archive: libtspi-dev_0.3.7-2_amd64.deb to main/t/trousers/libtspi-dev_0.3.7-2_amd64.deb libtspi1_0.3.7-2_amd64.deb to main/t/trousers/libtspi1_0.3.7-2_amd64.deb trousers-dbg_0.3.7-2_amd64.deb to main/t/trousers/trousers-dbg_0.3.7-2_amd64.deb trousers_0.3.7-2.debian.tar.gz to main/t/trousers/trousers_0.3.7-2.debian.tar.gz trousers_0.3.7-2.dsc to main/t/trousers/trousers_0.3.7-2.dsc trousers_0.3.7-2_amd64.deb to main/t/trousers/trousers_0.3.7-2_amd64.deb A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Pierre Chifflier <[email protected]> (supplier of updated trousers package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sat, 17 Dec 2011 15:14:17 +0000 Source: trousers Binary: trousers trousers-dbg libtspi1 libtspi-dev Architecture: source amd64 Version: 0.3.7-2 Distribution: unstable Urgency: low Maintainer: Pierre Chifflier <[email protected]> Changed-By: Pierre Chifflier <[email protected]> Description: libtspi-dev - open-source TCG Software Stack (development) libtspi1 - open-source TCG Software Stack (library) trousers - open-source TCG Software Stack (daemon) trousers-dbg - open-source TCG Software Stack (debug) Closes: 649901 649954 Changes: trousers (0.3.7-2) unstable; urgency=low . * Apply following patches, thanks to Laurent Bigonville: * Add $network to init script depends (Closes: #649954) * Do not use --background in init script (Closes: #649901) * Also add --oknodo on start Checksums-Sha1: 961e3eb00c5f4e2aee79c14565080f986488ad1c 1921 trousers_0.3.7-2.dsc 26c10d15508572efde87c5f9bc41c8d6d67741cf 19838 trousers_0.3.7-2.debian.tar.gz 3d08827215c0a192f09f93be6fb115d072f56c69 153530 trousers_0.3.7-2_amd64.deb 81e31f31c624d8af01756e0ca41b915a158389b1 58032 trousers-dbg_0.3.7-2_amd64.deb 95f91f7634fae15bc323339450f25b184a4b341a 203894 libtspi1_0.3.7-2_amd64.deb d04447269f3ddd5302b55cf3b3fc4def480fb6dc 660596 libtspi-dev_0.3.7-2_amd64.deb Checksums-Sha256: cf023cb10b4d93a4a2cc0f6389d2a9d0edbb4ebce4c3ad761ba57cba2300290c 1921 trousers_0.3.7-2.dsc 8e09f8a9658f81a0e69740c51c1a5c56a146330f380ffb2e5e27397bb83626ec 19838 trousers_0.3.7-2.debian.tar.gz 1be85f02c566f3cc495e6065c1d2fb09e990311f1fa836b3348bb5c0ad282a15 153530 trousers_0.3.7-2_amd64.deb 22812ff9952022ca4acd62753f910f4d7799b73a0a7a59b3fcaa23dcec7ba2b8 58032 trousers-dbg_0.3.7-2_amd64.deb 340480f41700e1ed73e987352c29213ce31748849537ad1ba50e856ba7e0a90e 203894 libtspi1_0.3.7-2_amd64.deb 94de28cc0426b2f2eae25608427c4b789ff4415361b729906518bc7f9e31b7b3 660596 libtspi-dev_0.3.7-2_amd64.deb Files: f43f0a801177586fecd204833217c74b 1921 admin optional trousers_0.3.7-2.dsc 41ad0fe4b4748b0df277a434a99f4f13 19838 admin optional trousers_0.3.7-2.debian.tar.gz 3af8c867be6f280262af6ef79afbe886 153530 admin optional trousers_0.3.7-2_amd64.deb b856b5ae3327717630ec1e513035fb4d 58032 debug extra trousers-dbg_0.3.7-2_amd64.deb cf33ffb5e93684b7e6f23e06e7f9334c 203894 libs optional libtspi1_0.3.7-2_amd64.deb 268690f7f2432ee336e27f23afaac6d7 660596 libdevel optional libtspi-dev_0.3.7-2_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBCAAGBQJO7KcLAAoJEMYaZNzxOTmYG7EP/istUpl/RhhLUGe6Rz2jChq0 q7t999IepUev1mEZSSPMOIsMFe3aO2f6jpD7NiltOAIQM7q3ptiTZ1nc53B42Yms tnn0Tn/FisixptdOZmMT6R+cwRutbHLRQ+r6D78KmetfhdB3Vg+S0KoTRRq7XXL9 ren885oBzs4nRdmzFAOJvwfvsj5UglL/op65SKTOIid/iypwu/JV/S/xi2pLurUJ wvUTZOgiAVlWAGrrvjItwq+GX4pxZdFjzQ5vtl9+5rA0PSdVnM+mBmttmAQ+481K M1CV3T3MzBZHGKfNfvPdmXe9zJmxBYBxvTBZ0sVa/DeaeJh43zXnU4rqBl5ATDh1 TvGbrBkZLxwAQWSGXD0f6TMm++WIq4q2cx568RcX6gmw2csS+uC2JdeS3CCwhxGn /tt3E/pOFZnt4dtjHwhEynY4dStTI2IJ2EJHswTUOzo0wKLknWxxkBXy+8qZRm13 WMqrX7OSCop3RGvzPQ0uYaGtbknalyTbwou4tYY/dPGzB9tt4aeN+tTwP2jHqCV2 SES7FImzOHzNFjOoZe2vUqLqCdEUFhDarR/qOtRUUwzvfmuVPSQ67A+lzjwzMKvb BBBM5XCrOk08b0pZAYk0Fi9BcOeUw5qaA6GNNNP909dd/DcTlC2GYaqqgg1DuEBz gc5eaax055u23+ZD93kD =RZ+N -----END PGP SIGNATURE-----
--- End Message ---
