Your message dated Sat, 21 Jan 2012 10:32:12 +0000
with message-id <[email protected]>
and subject line Bug#655891: fixed in dmidecode 2.11-5
has caused the Debian Bug report #655891,
regarding Please enabled hardened build flags
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
655891: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655891
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dmidecode
Version: 2.11-4
Severity: important
Tags: patch
Please enabled hardened build flags through dpkg-buildflags.
Patch attached. I needed to make additional changes to the
Makefile, since otherwise the flags configured in debian/rules
are overridden.
(dpkg-buildflags abides "noopt" from DEB_BUILD_OPTIONS)
Cheers,
Moritz
diff -aur dmidecode-2.11.harden/debian/rules dmidecode-2.11/debian/rules
--- dmidecode-2.11.harden/debian/rules 2011-10-28 21:53:58.000000000 +0200
+++ dmidecode-2.11/debian/rules 2012-01-14 17:04:08.000000000 +0100
@@ -1,6 +1,10 @@
#!/usr/bin/make -f
# Flags fetched from the upstream Makefile.
+
+CFLAGS = `dpkg-buildflags --get CFLAGS`
+CFLAGS += `dpkg-buildflags --get CPPFLAGS`
+
CFLAGS += -W -Wall -pedantic -Wshadow -Wstrict-prototypes -Wpointer-arith \
-Wcast-qual -Wcast-align -Wwrite-strings -Wmissing-prototypes -Winline -Wundef
@@ -10,11 +14,13 @@
# Dropped -ansi as it break building on ia64
CFLAGS += -ansi
+LDFLAGS = `dpkg-buildflags --get LDFLAGS`
+
%:
dh ${@}
override_dh_auto_build:
- dh_auto_build -- CFLAGS="$(CFLAGS)"
+ dh_auto_build -- CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)"
override_dh_auto_install:
dh_auto_install -- prefix=/usr
diff -aur dmidecode-2.11.harden/Makefile dmidecode-2.11/Makefile
--- dmidecode-2.11.harden/Makefile 2012-01-14 16:57:02.000000000 +0100
+++ dmidecode-2.11/Makefile 2012-01-14 17:01:46.000000000 +0100
@@ -13,17 +13,17 @@
#
CC = gcc
-CFLAGS = -W -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual \
- -Wcast-align -Wwrite-strings -Wmissing-prototypes -Winline -Wundef
+#CFLAGS = -W -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual \
+# -Wcast-align -Wwrite-strings -Wmissing-prototypes -Winline -Wundef
#CFLAGS += -DBIGENDIAN
#CFLAGS += -DALIGNMENT_WORKAROUND
# When debugging, disable -O2 and enable -g.
-CFLAGS += -O2
+#CFLAGS += -O2
#CFLAGS += -g
# Pass linker flags here
-LDFLAGS =
+#LDFLAGS =
DESTDIR =
prefix = /usr/local
--- End Message ---
--- Begin Message ---
Source: dmidecode
Source-Version: 2.11-5
We believe that the bug you reported is fixed in the latest version of
dmidecode, which is due to be installed in the Debian FTP archive:
dmidecode-udeb_2.11-5_i386.udeb
to main/d/dmidecode/dmidecode-udeb_2.11-5_i386.udeb
dmidecode_2.11-5.debian.tar.gz
to main/d/dmidecode/dmidecode_2.11-5.debian.tar.gz
dmidecode_2.11-5.dsc
to main/d/dmidecode/dmidecode_2.11-5.dsc
dmidecode_2.11-5_i386.deb
to main/d/dmidecode/dmidecode_2.11-5_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Daniel Baumann <[email protected]> (supplier of updated
dmidecode package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 21 Jan 2012 11:16:31 +0100
Source: dmidecode
Binary: dmidecode dmidecode-udeb
Architecture: source i386
Version: 2.11-5
Distribution: unstable
Urgency: low
Maintainer: Daniel Baumann <[email protected]>
Changed-By: Daniel Baumann <[email protected]>
Description:
dmidecode - SMBIOS/DMI table decoder
dmidecode-udeb - SMBIOS/DMI table decoder (udeb) (udeb)
Closes: 655891
Changes:
dmidecode (2.11-5) unstable; urgency=low
.
* Updating year in copyright file.
* Updating to debhelper version 9.
* Adding patch to avoid overwriting build environment rather than to
just extend it.
* Simplifying CFLAGS handing in rules.
* Enabling hardening build options (Closes: #655891).
Checksums-Sha1:
a16a7d321987a87b28d4c8802005c01ff8166469 1166 dmidecode_2.11-5.dsc
c77922247356ac0cc017da571f3ec9942acd7964 8085 dmidecode_2.11-5.debian.tar.gz
af6896adfa19f29cd5a0f7c209d5b485cbdcad0e 74492 dmidecode_2.11-5_i386.deb
c92cd34b18befe903fd3ada59678fac730c4192f 34638 dmidecode-udeb_2.11-5_i386.udeb
Checksums-Sha256:
adafaba282f82fe4631b6343a535ebe466265a362f1966f3b6b8803dae71b485 1166
dmidecode_2.11-5.dsc
ce8318642fe3069667c0570c83bd70fc1b296e28f19fd16b48fbb8f831d35d9e 8085
dmidecode_2.11-5.debian.tar.gz
340c077eb8f978ad9d96c10ff4e57058c7bb92c6451f5133469624374e85cc86 74492
dmidecode_2.11-5_i386.deb
51126c6cc101d14bb139744e26bee1493fe28ade371d6831aec7239d2c5998d8 34638
dmidecode-udeb_2.11-5_i386.udeb
Files:
5fff8db106a6dae76af60c2c1a08a2c5 1166 utils optional dmidecode_2.11-5.dsc
21ddc5d85bbb346a92e985c5d50addb2 8085 utils optional
dmidecode_2.11-5.debian.tar.gz
5bb691e3d47256ed211fedc773d3ac88 74492 utils important
dmidecode_2.11-5_i386.deb
67333eb80d51243faa3bd0652bc306db 34638 debian-installer optional
dmidecode-udeb_2.11-5_i386.udeb
Package-Type: udeb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAk8akZMACgkQ+C5cwEsrK56OrACdFSikqTeXjEpmahMIj5Youjp1
bNkAn2nyn0rrQ5dD5yy/G3OU8vUSynBE
=03cS
-----END PGP SIGNATURE-----
--- End Message ---
