Your message dated Sat, 4 Feb 2012 14:51:45 -0800 (PST)
with message-id <[email protected]>
and subject line Patched in git
has caused the Debian Bug report #657104,
regarding opticalraytracer: FTBFS in a clean schroot
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
657104: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=657104
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: opticalraytracer
Version: 3.2-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu precise ubuntu-patch

Dear Maintainer,

opticalraytracer fails to build in a clean schroot. Since the build process
removes build.xml, there is then no rule file to build the binaries. See the
build logs in Ubuntu:

https://launchpadlibrarian.net/88517645/buildlog_ubuntu-precise-i386.opticalraytracer_3.2-1_FAILEDTOBUILD.txt.gz

This happens to work when just debuild is called because dpkg-source then
re-patches in build.xml just before getting to the debian/rules build target,
which does not happen in a schroot:

dpkg-source: info: mise en place de build-xml.patch
dpkg-source: info: mise en place de jar-path.patch
dpkg-source: info: mise en place de disable-ant-propertyfile.patch
dpkg-source: info: construction de opticalraytracer à partir de 
./opticalraytracer_3.2.orig.tar.gz
dpkg-source: info: construction de opticalraytracer dans 
opticalraytracer_3.2-1ubuntu1.debian.tar.gz
dpkg-source: info: construction de opticalraytracer dans 
opticalraytracer_3.2-1ubuntu1.dsc
 debian/rules build

A simple fix to this is to have build require the patch target so that build.xml
is added back in again.

Thanks for considering the attached patch.

I've also noticed ant clean gets called at least twice when starting the build
process, I think it might be possible to simplify things to make it unnecessary
to unpatch and repatch (especially given that format 3.0 (quilt) is used).


-- System Information:
Debian Release: wheezy/sid
  APT prefers precise-updates
  APT policy: (500, 'precise-updates'), (500, 'precise-security'), (500, 
'precise')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-9-generic (SMP w/4 CPU cores)
Locale: LANG=fr_CA.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
=== modified file 'debian/changelog'

=== modified file 'debian/rules'
--- debian/rules	2011-12-09 20:23:33 +0000
+++ debian/rules	2012-01-24 01:40:22 +0000
@@ -45,7 +45,7 @@
 	dh_testdir
 	touch configure-stamp
 
-build: build-stamp
+build: build-stamp patch
 
 build-stamp: configure-stamp  $(QUILT_STAMPFN)
 		dh_testdir


--- End Message ---
--- Begin Message ---
Hello,

Thankyou for your patch; I have committed it to the git repository.

http://anonscm.debian.org/gitweb/?p=debian-science/packages/opticalraytracer.git;a=commit;h=bb2570ebd1fca08a31f525aad49094957bbb2d2a

I originally moved this package to quilt 3.0 as it is required by 
debian-science. I must admit I am somewhat behind understanding how quilt 3 
actually integrates into the package building framework, and do feel a bit more 
comfortable with predicting quilt 1.0 behaviour.

Thankyou for your help



--- End Message ---

Reply via email to