Your message dated Sun, 12 Feb 2012 11:48:24 +0000
with message-id <[email protected]>
and subject line Bug#651852: fixed in pdf-presenter-console 2.0-7
has caused the Debian Bug report #651852,
regarding Patch for porting to poppler 0.18
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
651852: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=651852
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: pdf-presenter-console
Version: 2.0-6
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch precise
Hello,
In http://bugs.debian.org/644447 there is some discussion about
updating poppler to 0.18 in Debian. This will cause some FTBFS. We are
doing the transition in Ubuntu now and want to forward patches so that
they are readily available in Debian once 0.18 lands there. But this
patch works with poppler 0.16 just as well, so it's fine to apply to
Debian now.
This was reported upstream at
https://github.com/jakobwesthoff/Pdf-Presenter-Console/issues/35
and fixed in a branch:
https://github.com/davvil/Pdf-Presenter-Console/commit/8f9a742f725a7dcd46a22377572993f775152e29
Thanks for considering,
Martin
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
diff -Nru pdf-presenter-console-2.0/debian/changelog
pdf-presenter-console-2.0/debian/changelog
--- pdf-presenter-console-2.0/debian/changelog 2011-11-16 10:28:23.000000000
+0000
+++ pdf-presenter-console-2.0/debian/changelog 2011-12-12 15:07:20.000000000
+0000
@@ -1,3 +1,10 @@
+pdf-presenter-console (2.0-6ubuntu1) precise; urgency=low
+
+ * Add poppler-0.18.patch: Update to poppler 0.18 API. Thanks to David Vilar
+ for the patch!
+
+ -- Martin Pitt <[email protected]> Mon, 12 Dec 2011 16:07:17 +0100
+
pdf-presenter-console (2.0-6) unstable; urgency=low
* desktop file, thanks to Peter Eisentraut (closes: #648882)
diff -Nru pdf-presenter-console-2.0/debian/control
pdf-presenter-console-2.0/debian/control
diff -Nru pdf-presenter-console-2.0/debian/patches/poppler-0.18.patch
pdf-presenter-console-2.0/debian/patches/poppler-0.18.patch
--- pdf-presenter-console-2.0/debian/patches/poppler-0.18.patch 1970-01-01
00:00:00.000000000 +0000
+++ pdf-presenter-console-2.0/debian/patches/poppler-0.18.patch 2011-12-12
15:06:18.000000000 +0000
@@ -0,0 +1,49 @@
+commit 8f9a742f725a7dcd46a22377572993f775152e29
+Author: David Vilar <[email protected]>
+Date: Wed Nov 23 09:17:19 2011 +0100
+
+ Adapted to poppler >= 0.17
+
+ Removed deprecated call to poppler_page_render_to_pixbuf and substituted
+ with poppler_page_render.
+
+ First time I work with vala and poppler. As far as I can see (and test)
+ it works, but I cannot guarantee it for all the cases ;-)
+
+Bug: https://github.com/jakobwesthoff/Pdf-Presenter-Console/issues/35
+Origin:
https://github.com/davvil/Pdf-Presenter-Console/commit/8f9a742f725a7dcd46a22377572993f775152e29
+
+diff --git a/src/classes/renderer/pdf.vala b/src/classes/renderer/pdf.vala
+index 27fde95..8b10670 100644
+--- a/src/classes/renderer/pdf.vala
++++ b/src/classes/renderer/pdf.vala
+@@ -107,26 +107,15 @@ namespace org.westhoffswelt.pdfpresenter {
+ Pixmap pixmap = new Pixmap( null, this.width, this.height, 24 );
+ Context cr = Gdk.cairo_create( pixmap );
+
+- cr.set_source_rgb( 0, 0, 0 );
++ cr.set_source_rgb( 255, 255, 255 );
+ cr.rectangle( 0, 0, this.width, this.height );
+ cr.fill();
+
+- /**
+- * @TODO: Refactor rendering process to use cairo context directly
+- * for page rendering instead of inbetween pixbuf
+- */
+- var pdf = new Gdk.Pixbuf( Gdk.Colorspace.RGB, false, 8,
this.width, this.height );
++ cr.scale(this.scaling_factor, this.scaling_factor);
+ MutexLocks.poppler.lock();
+- page.render_to_pixbuf( 0, 0, this.width, this.height,
this.scaling_factor, 0, pdf );
++ page.render(cr);
+ MutexLocks.poppler.unlock();
+
+- // Compose the rendered pdf with the white background.
+- Gdk.cairo_set_source_pixbuf( cr, pdf, 0, 0 );
+- cr.rectangle( 0, 0, this.width, this.height );
+- cr.fill();
+-
+- pdf = null;
+-
+ // If the cache is enabled store the newly rendered pixmap
+ if ( this.cache != null ) {
+ this.cache.store( slide_number, pixmap );
diff -Nru pdf-presenter-console-2.0/debian/patches/series
pdf-presenter-console-2.0/debian/patches/series
--- pdf-presenter-console-2.0/debian/patches/series 2011-11-16
10:35:59.000000000 +0000
+++ pdf-presenter-console-2.0/debian/patches/series 2011-12-12
15:04:29.000000000 +0000
@@ -1 +1,2 @@
debian-changes
+poppler-0.18.patch
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: pdf-presenter-console
Source-Version: 2.0-7
We believe that the bug you reported is fixed in the latest version of
pdf-presenter-console, which is due to be installed in the Debian FTP archive:
pdf-presenter-console_2.0-7.debian.tar.gz
to main/p/pdf-presenter-console/pdf-presenter-console_2.0-7.debian.tar.gz
pdf-presenter-console_2.0-7.dsc
to main/p/pdf-presenter-console/pdf-presenter-console_2.0-7.dsc
pdf-presenter-console_2.0-7_amd64.deb
to main/p/pdf-presenter-console/pdf-presenter-console_2.0-7_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Barak A. Pearlmutter <[email protected]> (supplier of updated
pdf-presenter-console package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sun, 12 Feb 2012 09:40:39 +0000
Source: pdf-presenter-console
Binary: pdf-presenter-console
Architecture: source amd64
Version: 2.0-7
Distribution: unstable
Urgency: low
Maintainer: Barak A. Pearlmutter <[email protected]>
Changed-By: Barak A. Pearlmutter <[email protected]>
Description:
pdf-presenter-console - multi-monitor presentation tool (ala Keynote) for PDF
files
Closes: 651852
Changes:
pdf-presenter-console (2.0-7) unstable; urgency=low
.
* poppler 0.18 patch, thanks to David Vilar (closes: #651852)
also thanks to Martin Pitt <[email protected]> for the ping
Checksums-Sha1:
41798217b154bdf9423799a47fd11f0594da163f 1445 pdf-presenter-console_2.0-7.dsc
bb2b907cd788eea89ad6d4e50a11aad6f3475755 12036
pdf-presenter-console_2.0-7.debian.tar.gz
ee5d5abc6e6e7b368d1a267d2a08773b08baa987 51134
pdf-presenter-console_2.0-7_amd64.deb
Checksums-Sha256:
5ef61221621685c0ad7c221e66ff70f090078e15fca9428fe35414d27c25e43c 1445
pdf-presenter-console_2.0-7.dsc
18b6b87973cc613197013eba8ce5f33802ba17b4c11165273812b761fbfa77c6 12036
pdf-presenter-console_2.0-7.debian.tar.gz
365aec2fade7bacd5fd8e8d476e2cb524e98b6803b6baf8598a0e048616b716b 51134
pdf-presenter-console_2.0-7_amd64.deb
Files:
308ec72d20e7e0f9ffc13a1c31378179 1445 graphics extra
pdf-presenter-console_2.0-7.dsc
88bc25df66ac2b6fea5dd95f1a12fd53 12036 graphics extra
pdf-presenter-console_2.0-7.debian.tar.gz
1390d03db4c963954da8338b8c510450 51134 graphics extra
pdf-presenter-console_2.0-7_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk83onEACgkQLz4Gnv7CP7IaBACfWq/DVgyUe2oQB/o+SmzOiS9m
ksIAoJyL4fgh2m9Wii6wRTMO6HQrwJub
=yXPl
-----END PGP SIGNATURE-----
--- End Message ---
