Your message dated Wed, 22 Feb 2012 19:17:39 +0000
with message-id <[email protected]>
and subject line Bug#659768: fixed in libgphoto2 2.4.12-1
has caused the Debian Bug report #659768,
regarding libgphoto2-2: use dh_installdeb maintscript support
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
659768: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659768
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libgphoto2-2
Version: 2.4.11-4
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch precise
Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before
libgphoto2-2. This seems generally undesirable; it would be better to
enforce a single code path. This is academic for Debian because the
version of dpkg in squeeze supported dpkg-maintscript-helper; Ubuntu's
last LTS release didn't have a sufficient version of dpkg for that which
is why I care. However, the current implementation in Debian is in fact
buggy anyway due to the use of an undefined PACKAGE variable in the
preinst, so I'm filing this at Severity: normal.
It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0. This would remove duplicate code from your maintainer scripts -
in fact, you could remove your handwritten preinst entirely. Here's a
patch. If you don't apply this for 2.4.11-5, then please adjust the
relevant lines in debian/libgphoto2-2.maintscript to match the last
version before the one where you apply it.
* Use maintscript support in dh_installdeb rather than writing out
dpkg-maintscript-helper commands by hand. We now simply Pre-Depend on a
new enough version of dpkg rather than using 'dpkg-maintscript-helper
supports' guards, leading to more predictable behaviour on upgrades.
* Bump a few of the dpkg-maintscript-helper versions because PACKAGE was
left undefined in the old preinst code and thus some of the old
conffiles would never have actually been removed.
diff -Nru libgphoto2-2.4.11/debian/libgphoto2-2.maintscript
libgphoto2-2.4.11/debian/libgphoto2-2.maintscript
--- libgphoto2-2.4.11/debian/libgphoto2-2.maintscript 1970-01-01
01:00:00.000000000 +0100
+++ libgphoto2-2.4.11/debian/libgphoto2-2.maintscript 2012-02-13
16:43:16.000000000 +0000
@@ -0,0 +1,6 @@
+rm_conffile /etc/udev/libgphoto2.rules 2.4.11-4
+rm_conffile /etc/udev/rules.d/025_libgphoto2.rules 2.4.10.1-5
+rm_conffile /etc/hotplug/usb/libgphoto2.usermap 2.4.11-4
+rm_conffile /etc/udev/libgphoto2_generic_ptp_support.rules 2.4.10.1-5
+rm_conffile /etc/udev/rules.d/025_libgphoto2.rules 2.4.11-4
+rm_conffile /etc/udev/rules.d/020_libgphoto2_generic-ptp_support.rules
2.4.10.1-5
diff -Nru libgphoto2-2.4.11/debian/libgphoto2-2.postinst
libgphoto2-2.4.11/debian/libgphoto2-2.postinst
--- libgphoto2-2.4.11/debian/libgphoto2-2.postinst 2012-01-12
08:37:57.000000000 +0000
+++ libgphoto2-2.4.11/debian/libgphoto2-2.postinst 2012-02-13
16:43:32.000000000 +0000
@@ -11,18 +11,6 @@
rm -f
/usr/share/hal/fdi/information/10freedesktop/10-camera-$PACKAGE.fdi
rm -f /usr/share/hal/fdi/information/20thirdparty/$PACKAGE.fdi
rm -f
/usr/share/hal/fdi/information/10freedesktop/10-camera-$PACKAGE-device.fdi
-
- # properly remove old config files
- for f in \
- /etc/udev/$PACKAGE.rules \
- /etc/udev/rules.d/025_libgphoto2.rules \
- /etc/hotplug/usb/$PACKAGE.usermap \
- /etc/udev/libgphoto2_generic_ptp_support.rules \
- /etc/udev/rules.d/025_$PACKAGE.rules \
- /etc/udev/rules.d/020_libgphoto2_generic-ptp_support.rules
- do
- dpkg-maintscript-helper rm_conffile $f 2.4.10.1-5 -- "$@"
- done
;;
abort-upgrade|abort-remove|abort-deconfigure)
diff -Nru libgphoto2-2.4.11/debian/libgphoto2-2.postrm
libgphoto2-2.4.11/debian/libgphoto2-2.postrm
--- libgphoto2-2.4.11/debian/libgphoto2-2.postrm 2012-01-12
08:37:57.000000000 +0000
+++ libgphoto2-2.4.11/debian/libgphoto2-2.postrm 2012-02-13
16:43:47.000000000 +0000
@@ -11,21 +11,7 @@
rm -f
/usr/share/hal/fdi/information/10freedesktop/10-camera-$PACKAGE-device.fdi ||
true
;;
- purge)
- # properly remove old config files
- for f in \
- /etc/udev/$PACKAGE.rules \
- /etc/udev/rules.d/025_libgphoto2.rules \
- /etc/hotplug/usb/$PACKAGE.usermap \
- /etc/udev/libgphoto2_generic_ptp_support.rules \
- /etc/udev/rules.d/025_$PACKAGE.rules \
-
/etc/udev/rules.d/020_libgphoto2_generic-ptp_support.rules
- do
- dpkg-maintscript-helper rm_conffile $f 2.4.10.1-5 --
"$@"
- done
- ;;
-
- disappear|upgrade|failed-upgrade|abort-install|abort-upgrade)
+ purge|disappear|upgrade|failed-upgrade|abort-install|abort-upgrade)
;;
*)
diff -Nru libgphoto2-2.4.11/debian/libgphoto2-2.preinst
libgphoto2-2.4.11/debian/libgphoto2-2.preinst
--- libgphoto2-2.4.11/debian/libgphoto2-2.preinst 2012-01-12
08:37:57.000000000 +0000
+++ libgphoto2-2.4.11/debian/libgphoto2-2.preinst 1970-01-01
01:00:00.000000000 +0100
@@ -1,32 +0,0 @@
-#!/bin/sh
-
-set -e
-
-case "$1" in
- install|upgrade)
- # properly remove old config files
- for f in \
- /etc/udev/$PACKAGE.rules \
- /etc/udev/rules.d/025_libgphoto2.rules \
- /etc/hotplug/usb/$PACKAGE.usermap \
- /etc/udev/libgphoto2_generic_ptp_support.rules \
- /etc/udev/rules.d/025_$PACKAGE.rules \
-
/etc/udev/rules.d/020_libgphoto2_generic-ptp_support.rules
- do
- dpkg-maintscript-helper rm_conffile $f 2.4.10.1-5 --
"$@"
- done
- ;;
-
- abort-upgrade)
- ;;
-
- *)
- echo "preinst called with unknown argument \`$1'" >&2
- exit 1
- ;;
-
-esac
-
-#DEBHELPER#
-
-exit 0
Thanks,
--
Colin Watson [[email protected]]
--- End Message ---
--- Begin Message ---
Source: libgphoto2
Source-Version: 2.4.12-1
We believe that the bug you reported is fixed in the latest version of
libgphoto2, which is due to be installed in the Debian FTP archive:
libgphoto2-2-dev_2.4.12-1_i386.deb
to main/libg/libgphoto2/libgphoto2-2-dev_2.4.12-1_i386.deb
libgphoto2-2_2.4.12-1_i386.deb
to main/libg/libgphoto2/libgphoto2-2_2.4.12-1_i386.deb
libgphoto2-dev-doc_2.4.12-1_all.deb
to main/libg/libgphoto2/libgphoto2-dev-doc_2.4.12-1_all.deb
libgphoto2-l10n_2.4.12-1_all.deb
to main/libg/libgphoto2/libgphoto2-l10n_2.4.12-1_all.deb
libgphoto2-port0_2.4.12-1_i386.deb
to main/libg/libgphoto2/libgphoto2-port0_2.4.12-1_i386.deb
libgphoto2_2.4.12-1.debian.tar.gz
to main/libg/libgphoto2/libgphoto2_2.4.12-1.debian.tar.gz
libgphoto2_2.4.12-1.dsc
to main/libg/libgphoto2/libgphoto2_2.4.12-1.dsc
libgphoto2_2.4.12.orig.tar.gz
to main/libg/libgphoto2/libgphoto2_2.4.12.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
David Paleino <[email protected]> (supplier of updated libgphoto2 package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Wed, 22 Feb 2012 19:45:20 +0100
Source: libgphoto2
Binary: libgphoto2-2-dev libgphoto2-dev-doc libgphoto2-port0 libgphoto2-2
libgphoto2-l10n
Architecture: source i386 all
Version: 2.4.12-1
Distribution: unstable
Urgency: low
Maintainer: Debian PhotoTools Maintainers
<[email protected]>
Changed-By: David Paleino <[email protected]>
Description:
libgphoto2-2 - gphoto2 digital camera library
libgphoto2-2-dev - gphoto2 digital camera library (development files)
libgphoto2-dev-doc - gphoto2 digital camera library (development documentation)
libgphoto2-l10n - gphoto2 digital camera library - localized messages
libgphoto2-port0 - gphoto2 digital camera port library
Closes: 659768
Changes:
libgphoto2 (2.4.12-1) unstable; urgency=low
.
* New upstream version
* Fix maintainer scripts with the help of dh_installdeb's .maintscript
support. *MANY* thanks to Colin Watson for the patch (and for
letting me know about .maintscript). (Closes: #659768)
* Build-Depend on libgd2-xpm-dev instead of libgd2-noxpm-dev
* Added proper lintian overrides
* Add dependency to libjs-jquery to avoid embedding it in libgphoto2-dev-doc
* Fixed some harmless typos in the source code
Checksums-Sha1:
69b1702aab111f7598ad3b3783bb3fe123bb2afd 1869 libgphoto2_2.4.12-1.dsc
307bcd58969e94cebd34bfb57d09ee4c534b5e28 5572578 libgphoto2_2.4.12.orig.tar.gz
0ad5f69e52025de5bda168b4071500b2bf425722 27821
libgphoto2_2.4.12-1.debian.tar.gz
4b4324736cfd4e1644e6de78280bf2d039fbc01a 2517542
libgphoto2-2-dev_2.4.12-1_i386.deb
95a7662264522e159ca351921da69ef70478dab5 2929496
libgphoto2-dev-doc_2.4.12-1_all.deb
5efd8f05d1653fe24b77f5d0d76d7e197170e9a1 152940
libgphoto2-port0_2.4.12-1_i386.deb
65bdfcf8686a75a4a3f85754e707f3a6eb4a9f4e 1042732 libgphoto2-2_2.4.12-1_i386.deb
0e6af04e8b3dd216a3378549bf8ab5415f91ddd2 745186
libgphoto2-l10n_2.4.12-1_all.deb
Checksums-Sha256:
18348697bac94bc6939a82e285cbe0b1587477d7ca4bbc03d41175a6a38880f6 1869
libgphoto2_2.4.12-1.dsc
8f5a3f08a779db6abb87575b22e30b5c6e3749f0972bf0b74263b2879e35cd19 5572578
libgphoto2_2.4.12.orig.tar.gz
4a12bd8799151f2f12b7eeb16bd5e09108563a41b31808960a639d9da42398e3 27821
libgphoto2_2.4.12-1.debian.tar.gz
4427aa147f9f3dc6d1e18e28cc3210225aad6ad61365604340102fa5f11ed37d 2517542
libgphoto2-2-dev_2.4.12-1_i386.deb
2317b4fa69e48260304346aa862908f1221100488303a9a22b496b8428e6833c 2929496
libgphoto2-dev-doc_2.4.12-1_all.deb
8e2235ce1aed3216b764ec790f947d22a03095fea963e9ca7dc852fa490ab61a 152940
libgphoto2-port0_2.4.12-1_i386.deb
5fd6b7ce1f80d18b5ba88e3bab9b80eb73a3ca6104c4f8132ba62c9600332726 1042732
libgphoto2-2_2.4.12-1_i386.deb
765ecb7aa043a05b415643ddf5a45141e4ed78c46f82edaaeaa7f3f5d67333cf 745186
libgphoto2-l10n_2.4.12-1_all.deb
Files:
e65b59297760e129a2755823f88a6213 1869 libs optional libgphoto2_2.4.12-1.dsc
9829ec3bb70713f7a4a27b681c35031b 5572578 libs optional
libgphoto2_2.4.12.orig.tar.gz
ba4d602264c560670f1e7495d5b9b1cb 27821 libs optional
libgphoto2_2.4.12-1.debian.tar.gz
37db239371b760884b840ff603db3b39 2517542 libdevel optional
libgphoto2-2-dev_2.4.12-1_i386.deb
dda862e55d4ff81d98ce642097902360 2929496 doc optional
libgphoto2-dev-doc_2.4.12-1_all.deb
3d3f9e65a87bb1ba4403e50c2263f7f8 152940 libs optional
libgphoto2-port0_2.4.12-1_i386.deb
3416e0595f494e2debcbf878a779bfcb 1042732 libs optional
libgphoto2-2_2.4.12-1_i386.deb
4e196e392e64bcd567d635ebecb4910a 745186 localization optional
libgphoto2-l10n_2.4.12-1_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEARECAAYFAk9FOa0ACgkQ5qqQFxOSsXQGNgCgukh5soty47oJFDGHiOJyeUhZ
LDEAniuzWlp0WTe602rNI8yi+8ZZMU+W
=qRll
-----END PGP SIGNATURE-----
--- End Message ---
