Your message dated Fri, 09 Mar 2012 13:02:12 +0000
with message-id <[email protected]>
and subject line Bug#638803: fixed in backup-manager 0.7.10.1-1
has caused the Debian Bug report #638803,
regarding backup-manager: If a backup crosses the day limit it won't be uploaded
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
638803: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=638803
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: backup-manager
Version: 0.7.9-3
Severity: normal
Tags: upstream patch

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Backup-manager calculates the date string of the archive name (the TODAY env
var) upon startup, then performs the backup, then runs backup-manager-upload
with a date argument of 'today' to upload the archive(s).

The 'today' argument results in recalculation of the date string on the fly
by bmu, at the time of invocation, ie just before the upload begins. Thus,
we have two calculations of the date part of the archive name separated by a
potentially significant time delay.

Therefore, if a backup starts at date X and finishes at date X + 1, it will
not get uploaded. I was actually hit by that before inspecting the code.

A patch is attached to address this issue. The patch replaces the 'today'
argument with the $TODAY variable, the one that its value is set during the
startup of backup-manager. 

I have tested the patch both by building the package and patching my system's
live configuration and it works (backups are uploaded). 

The patch has also the nice side effect of allowing the upload of archives of
any date, by writing 'export TODAY=...' in a configuration file, FOO, and then
issuing 'backup-manager --upload -c FOO', since backup-manager sets the TODAY
variable early, before reading the configuration file.

regards
George Zarkadas

- -- System Information:
Debian Release: 6.0.2
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'proposed-updates'), (500, 
'stable'), (450, 'testing-proposed-updates'), (450, 'testing'), (400, 
'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/4 CPU cores)
Locale: LANG=el_GR.utf8, LC_CTYPE=el_GR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages backup-manager depends on:
ii  debconf [debconf-2.0]        1.5.36.1    Debian configuration management sy
ii  findutils                    4.4.2-1+b1  utilities for finding files--find,
ii  ucf                          3.0025+nmu1 Update Configuration File: preserv

backup-manager recommends no packages.

Versions of packages backup-manager suggests:
ii  anacron               2.3-14             cron-like program that doesn't go 
ii  backup-manager-doc    0.7.9-3            documentation package for Backup M
ii  dar                   2.3.10-1+b1        Disk ARchive: Backup directory tre
ii  dvd+rw-tools          7.1-6              DVD+-RW/R tools
ii  genisoimage           9:1.1.11-1         Creates ISO-9660 CD-ROM filesystem
ii  gettext-base          0.18.1.1-3         GNU Internationalization utilities
ii  libfile-slurp-perl    9999.13-1          single call read & write file rout
pn  libnet-amazon-s3-perl <none>             (no description available)
ii  openssh-client        1:5.5p1-6+squeeze1 secure shell (SSH) client, for sec
ii  perl                  5.10.1-17squeeze2  Larry Wall's Practical Extraction 
ii  wodim                 9:1.1.11-1         command line CD/DVD writing tool
ii  zip                   3.0-3              Archiver for .zip files

- -- debconf information excluded

- -- debsums errors found:
debsums: changed file /usr/share/backup-manager/actions.sh (from backup-manager 
package)
debsums: changed file /usr/share/backup-manager/files.sh (from backup-manager 
package)
debsums: changed file /usr/share/backup-manager/backup-methods.sh (from 
backup-manager package)
debsums: changed file /usr/share/backup-manager/upload-methods.sh (from 
backup-manager package)
debsums: changed file /usr/share/backup-manager/sanitize.sh (from 
backup-manager package)
debsums: changed file /usr/share/backup-manager/externals.sh (from 
backup-manager package)
debsums: changed file /usr/sbin/backup-manager (from backup-manager package)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iQEcBAEBAgAGBQJOUaHiAAoJEJWXIVmJ5BwWQMgIAI3ywdXCVZT1/PB5EpioLbWu
Lu1z1kW4dxeTyX/XciML7aVchhwSCOWp+ksS4JISHHz3Lh1UQoHhfBFfcHqY6bXj
wtl7Er6smBhxuNwCYO3lBrfhjJScPi6xZ7IYO1ilg67zGp1y3msWjx4y63ktsrgh
vl/l3hzoyEWDVjzgbdFdmrias+uxKmrZN7bwKksoQkBf3kmhYeFtGDe0Ak6H8ubj
V5/1UYYC3UQ4LWK6uG4D9HwTkBUYrKGekOJOXYsDzGGBSwnfTm1Dq/p+WaJsYtw6
1gUEZZ6kiIPa+KTIoJ/PW8F/0m23LDbqF5XI39WUrbC16SYDlju7Xp4XEoW3SaU=
=Zie9
-----END PGP SIGNATURE-----
--- a/lib/upload-methods.sh
+++ b/lib/upload-methods.sh
@@ -64,7 +64,7 @@
           -h="$bm_upload_hosts" \
           -u="$BM_UPLOAD_SSH_USER" \
           -d="$BM_UPLOAD_SSH_DESTINATION" \
-          -r="$BM_REPOSITORY_ROOT" today 2>$logfile || 
+          -r="$BM_REPOSITORY_ROOT" ${TODAY} 2>$logfile || 
     error "Error reported by backup-manager-upload for method \"scp\", check 
\"\$logfile\"."
     rm -f $logfile
 }
@@ -101,7 +101,7 @@
          -u="$BM_UPLOAD_SSH_USER" \
          -d="$BM_UPLOAD_SSH_DESTINATION" \
          -r="$BM_REPOSITORY_ROOT" \
-         --gpg-recipient="$BM_UPLOAD_SSHGPG_RECIPIENT" today 2>$logfile|| 
+         --gpg-recipient="$BM_UPLOAD_SSHGPG_RECIPIENT" ${TODAY} 2>$logfile|| 
     error "Error reported by backup-manager-upload for method \"ssh-gpg\", 
check \"\$logfile\"."
     rm -f $logfile
 }
@@ -134,7 +134,7 @@
         -h="$bm_upload_hosts" \
         -u="$BM_UPLOAD_FTP_USER" \
         -d="$BM_UPLOAD_FTP_DESTINATION" \
-        -r="$BM_REPOSITORY_ROOT" today 2>$logfile|| 
+        -r="$BM_REPOSITORY_ROOT" ${TODAY} 2>$logfile|| 
     error "Error reported by backup-manager-upload for method \"ftp\", check 
\"\$logfile\"."
     rm -f $logfile
 
@@ -164,7 +164,7 @@
         -h="$bm_upload_hosts" \
         -u="$BM_UPLOAD_S3_ACCESS_KEY" \
         -b="$BM_UPLOAD_S3_DESTINATION" \
-        -r="$BM_REPOSITORY_ROOT" today 2>$logfile || 
+        -r="$BM_REPOSITORY_ROOT" ${TODAY} 2>$logfile || 
     error "Error reported by backup-manager-upload for method \"s3\", check 
\"\$logfile\"."
     rm -f $logfile
 }

--- End Message ---
--- Begin Message ---
Source: backup-manager
Source-Version: 0.7.10.1-1

We believe that the bug you reported is fixed in the latest version of
backup-manager, which is due to be installed in the Debian FTP archive:

backup-manager-doc_0.7.10.1-1_all.deb
  to main/b/backup-manager/backup-manager-doc_0.7.10.1-1_all.deb
backup-manager_0.7.10.1-1.debian.tar.gz
  to main/b/backup-manager/backup-manager_0.7.10.1-1.debian.tar.gz
backup-manager_0.7.10.1-1.dsc
  to main/b/backup-manager/backup-manager_0.7.10.1-1.dsc
backup-manager_0.7.10.1-1_all.deb
  to main/b/backup-manager/backup-manager_0.7.10.1-1_all.deb
backup-manager_0.7.10.1.orig.tar.gz
  to main/b/backup-manager/backup-manager_0.7.10.1.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Sven Joachim <[email protected]> (supplier of updated backup-manager package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Wed, 07 Mar 2012 19:08:15 +0100
Source: backup-manager
Binary: backup-manager backup-manager-doc
Architecture: source all
Version: 0.7.10.1-1
Distribution: unstable
Urgency: low
Maintainer: Sven Joachim <[email protected]>
Changed-By: Sven Joachim <[email protected]>
Description: 
 backup-manager - command-line backup tool
 backup-manager-doc - documentation package for Backup Manager
Closes: 491199 567553 602633 608237 610413 637743 638803 638920 655985 659162
Changes: 
 backup-manager (0.7.10.1-1) unstable; urgency=low
 .
   [ Sven Joachim ]
   * New upstream release (Closes: #655985).
     - Adds a new "postgresql" backup method (Closes: #637743).
   * Remove the fragile translation-updates.diff patch.  Instead, backup
     the upstream po files before the build and restore them in the clean
     target (Closes: #602633).
   * Depend on perl (via ${perl:Depends}), rather than than suggesting it,
     since perl is required by backup-manager-purge (LP: #941919).
   * Drop the debian-perl-location.diff patch, setting PERL5DIR in
     debian/rules instead.
   * Refresh the remaining Debian patches.
   * Fill out the same "Language:" header in debian/po/*.po.
   * Drop findutils dependency, even the version in Etch is new enough.
   * Upgrade Standards-Version to 3.9.3, no changes needed.
   * Update lintian override for Lintian 2.5.
   * Update debian/watch to find the 0.7.10.1 release tarball.
   * Add build-indep and (empty) build-arch targets to debian/rules.
   * Update Vcs-* fields in debian/control, switching to collab-maint.
   * Fix a few typos in the debconf templates, thanks to Daniele Forsi
     for the report.
   * Update README.Debian, the Amazon S3 upload method not longer needs
     libfile-slurp-perl (see #491199).
   * Demote the priority of the repo_user/repo_group debconf templates to
     medium.
   * Update debian/copyright.
 .
   [ Georgios M. Zarkadas ]
   * Add Greek debconf translation.
   * Allow absolute paths in BM_TARBALL_BLACKLIST even when backing up
     the root (/) directory (Closes: #608237).
   * Fix missed archive uploads when backups are crossing the day
     limit (Closes: # 638803).
   * Provide a configuration option to record all uploaded archives in
     a single text database file (Closes: #638920).
   * Fix upstream makefile to make the build/clean process of gettext (po)
     files idempotent and bring sanity back to the package's build process.
   * Fix a security issue in pgsql backup method regarding the .pgpass
     file handling.
   * Add support for local unix sockets connections to the pgsql backup method.
   * Add existence check for pg_dumpall to the pgsql backup method.
   * Use the same naming convention for database methods generated archives.
   * Add myself to Uploaders.
   * Add cron script to remove old entries from uploaded archives database.
   * Update control file to reflect upstream fix of Amazon S3 uploading
     method's dependencies (Closes: #491199).
   * Fix missed warnings when BM_LOGGER* variables are undefined or wrongly
     configured (Closes: #567553).
   * Change configurator to dynamically update BM_TARBALL_BLACKLIST when
     user selections change during configuration (Closes: #610413).
   * Add backtracking support to the configurator.
 .
   [ Sven Joachim, Georgios M. Zarkadas ]
   * Switch source format to 3.0 (quilt).
     - Drop debian/README.source.
   * Change debian/rules to use the generic 'dh$@' rule plus overrides.
 .
   [ Joe Dalton ]
   * Add Danish debconf translation (Closes: #659162).
Checksums-Sha1: 
 52102a178a9a5c99d031b2be7f1a756f7c441d90 2193 backup-manager_0.7.10.1-1.dsc
 a08768acff444275c3b33e35a808280106060641 150963 
backup-manager_0.7.10.1.orig.tar.gz
 e54e17f9a6ff9a78bb983f6d9f1653f1f9ac19b8 75326 
backup-manager_0.7.10.1-1.debian.tar.gz
 b959bc66c6b042ce36240bc3f9a2dc0e367fca3f 159432 
backup-manager_0.7.10.1-1_all.deb
 db61174d7f10f7a06d7e5c90c6e29772486523b1 234504 
backup-manager-doc_0.7.10.1-1_all.deb
Checksums-Sha256: 
 bcf6a886a56bf649734293a6729642b762cbfa4d5cebb3ab56892d2a34561995 2193 
backup-manager_0.7.10.1-1.dsc
 16994520d3fded41e166d17c946405dd192acf960603044aa6c915465e78d41f 150963 
backup-manager_0.7.10.1.orig.tar.gz
 46b68be7b01a990c5e9a869d7fcf7d2f7ae82d5dd614210d66f5342db45faaac 75326 
backup-manager_0.7.10.1-1.debian.tar.gz
 b701261e84675312ba11b9a6204698b42be333c4ba31b41cd50728bf64a60621 159432 
backup-manager_0.7.10.1-1_all.deb
 f09760ba85ad0716f4ca37e20c630a76db5912f78779a45d673a80de8dbaf323 234504 
backup-manager-doc_0.7.10.1-1_all.deb
Files: 
 e1e1cbd3b3ed95849724296c81bbc390 2193 admin optional 
backup-manager_0.7.10.1-1.dsc
 b7f1e6ecfb6c45116e9aef2de92ffb12 150963 admin optional 
backup-manager_0.7.10.1.orig.tar.gz
 6c36718a802ebea270f79a162a9dab10 75326 admin optional 
backup-manager_0.7.10.1-1.debian.tar.gz
 626a3bd130e39ac359c0d98240026396 159432 admin optional 
backup-manager_0.7.10.1-1_all.deb
 6efe622a55bb99d2701966eb2e23d5b8 234504 doc optional 
backup-manager-doc_0.7.10.1-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJPWf2oAAoJEMcZdpmymyMqGWEQAJ+XQDnWcjnvTlPA7U1TQpOz
L4H45lB5N0w9pkxORnxw6qG9KU1FZFtdtiFUNqEsNFYdN4h6FI/NL9Un5xMh6Zhb
ApMKftW5BVdLaXqW0Wr+y0+ejeeZDmr/3DACGqQgKFEelna6It2bp4UeNQEqSRdZ
EH2LldQNCw5nhsJt9WDoXofyjTPA3jiD9BpYal9PXoRKWuFRTvWBB1GTm5mi5LCB
M92IhvELpd1TEG3eC4OHLI1gaQsHe9n6G2sPBSU7VGbSkCUBfjXBG4iAUPAcQO+G
eFAt0Yfml/6o76Q762OJN27/0c7LmwS3WwzhDGYbpL1nWIBiscbK2Aw2CzrtY58r
IOw0nLOUolj04PmfF9Mgs39EVrxxr4teix3hyBuxnuga2Ftih/NH3hT8Zb9Y+TA4
umeSKu0DRCNuRAMfaGS+iKaqSnpTFlp4P1hynNkPcVptY6fhqfpGuOLHZrkr9kmF
IK8Tue561mFQNUqx/AqOiNMs46xlDy7kci/zrLIUhjKnZ7QMEtiNTqqewz6YUZfD
jZWHioJIFSHTLCuiILDdFGrW01o9a/Rt/kNJmn6xCJfQ3j1iuKEwVWSWKOy1JQo/
sUL5SJzuPKl3WKYvy7DOFKd5JIOVMLubtNpeg5LMoEBs/Tobmuj0hbjOAtAkwzvW
WOjEZGO/1zC7FbWL+ZlE
=OHCS
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to