Your message dated Sat, 17 Mar 2012 11:04:35 +0000
with message-id <[email protected]>
and subject line Bug#659794: fixed in tmux 1.6-2
has caused the Debian Bug report #659794,
regarding tmux: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
659794: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659794
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: tmux
Version: 1.6-1
Severity: wishlist
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before tmux.  This
seems generally undesirable; it would be better to enforce a single code
path.  (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts.
Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -Nru tmux-1.6/debian/control tmux-1.6/debian/control
--- tmux-1.6/debian/control     2012-01-23 18:25:26.000000000 +0000
+++ tmux-1.6/debian/control     2012-02-13 18:46:04.000000000 +0000
@@ -14,6 +14,7 @@
 
 Package: tmux
 Architecture: any
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Description: terminal multiplexer
  tmux enables a number of terminals (or windows) to be accessed and
diff -Nru tmux-1.6/debian/maintscript tmux-1.6/debian/maintscript
--- tmux-1.6/debian/maintscript 1970-01-01 01:00:00.000000000 +0100
+++ tmux-1.6/debian/maintscript 2012-02-13 18:45:18.000000000 +0000
@@ -0,0 +1 @@
+rm_conffile /etc/init.d/tmux-cleanup 1.4-6
diff -Nru tmux-1.6/debian/postinst tmux-1.6/debian/postinst
--- tmux-1.6/debian/postinst    2012-01-23 18:25:26.000000000 +0000
+++ tmux-1.6/debian/postinst    2012-02-13 18:45:34.000000000 +0000
@@ -2,10 +2,6 @@
 
 set -e
 
-if dpkg-maintscript-helper supports rm_conffile; then
-    dpkg-maintscript-helper rm_conffile /etc/init.d/tmux-cleanup 1.4-6 -- "$@"
-fi
-
 if [ "$1" = "configure" ]; then
     if [ -z "$2" ] || dpkg --compare-versions "$2" lt "1.5-3"; then
        add-shell /usr/bin/tmux
diff -Nru tmux-1.6/debian/postrm tmux-1.6/debian/postrm
--- tmux-1.6/debian/postrm      2012-01-23 18:25:26.000000000 +0000
+++ tmux-1.6/debian/postrm      2012-02-13 18:45:37.000000000 +0000
@@ -2,10 +2,6 @@
 
 set -e
 
-if dpkg-maintscript-helper supports rm_conffile; then
-    dpkg-maintscript-helper rm_conffile /etc/init.d/tmux-cleanup 1.4-6 -- "$@"
-fi
-
 if [ "$1" = "remove" ]; then
     remove-shell /usr/bin/tmux
 fi
diff -Nru tmux-1.6/debian/preinst tmux-1.6/debian/preinst
--- tmux-1.6/debian/preinst     2012-01-23 18:25:26.000000000 +0000
+++ tmux-1.6/debian/preinst     2012-02-13 18:45:41.000000000 +0000
@@ -7,8 +7,4 @@
     update-rc.d -f tmux-cleanup remove >/dev/null
 fi
 
-if dpkg-maintscript-helper supports rm_conffile; then
-    dpkg-maintscript-helper rm_conffile /etc/init.d/tmux-cleanup 1.4-6 -- "$@"
-fi
-
 #DEBHELPER#

Thanks,

-- 
Colin Watson                                       [[email protected]]



--- End Message ---
--- Begin Message ---
Source: tmux
Source-Version: 1.6-2

We believe that the bug you reported is fixed in the latest version of
tmux, which is due to be installed in the Debian FTP archive:

tmux_1.6-2.debian.tar.gz
  to main/t/tmux/tmux_1.6-2.debian.tar.gz
tmux_1.6-2.dsc
  to main/t/tmux/tmux_1.6-2.dsc
tmux_1.6-2_amd64.deb
  to main/t/tmux/tmux_1.6-2_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Romain Francoise <[email protected]> (supplier of updated tmux package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 17 Mar 2012 11:42:28 +0100
Source: tmux
Binary: tmux
Architecture: source amd64
Version: 1.6-2
Distribution: unstable
Urgency: low
Maintainer: Karl Ferdinand Ebert <[email protected]>
Changed-By: Romain Francoise <[email protected]>
Description: 
 tmux       - terminal multiplexer
Closes: 659794 662250
Changes: 
 tmux (1.6-2) unstable; urgency=low
 .
   [ Colin Watson ]
   * Use maintscript support in dh_installdeb rather than writing out
     dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
     new enough version of dpkg rather than using 'dpkg-maintscript-helper
     supports' guards, leading to more predictable behaviour on upgrades
     (closes: #659794).
 .
   [ Romain Francoise ]
   * Quote backslash in examples/screen-keys.conf to avoid syntax error
     (closes: #662250).
   * Bump Standards-Version to 3.9.3.
Checksums-Sha1: 
 b83254bfea2e064c3a29641c356d647ee7624b71 1246 tmux_1.6-2.dsc
 293ab226157204dd754bd8b84932eba868c65a39 10367 tmux_1.6-2.debian.tar.gz
 4fbdecd9d6af6dcf54a5c98d518b7557b19cd7bd 249380 tmux_1.6-2_amd64.deb
Checksums-Sha256: 
 0a3506a457aafc8e7af7ba638de69be0166d15953db93c89d1160702f4eb34fb 1246 
tmux_1.6-2.dsc
 667772209d8cdf6ed574288e520c209c8a565a87274d8c4dfb42027b5fb1c896 10367 
tmux_1.6-2.debian.tar.gz
 bc41e2c1323e429f83ed6d0aaae7289e2d9f5fca949f50c8f8e3f450660fd273 249380 
tmux_1.6-2_amd64.deb
Files: 
 3bd31a4fbea78546aa1b6ba827a93299 1246 admin optional tmux_1.6-2.dsc
 17826db28eab02caad27019953b95db4 10367 admin optional tmux_1.6-2.debian.tar.gz
 6956b6e86b86af41aac9f3bc284e0a36 249380 admin optional tmux_1.6-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iD8DBQFPZG4NogN2vsA8Vt8RAjmNAKCL7XHymUeveGmON9z4M34+l2vtmwCgu5tR
HkTcE3MskVGkhIahiJ7hEI0=
=M6uY
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to