Your message dated Sat, 07 Apr 2012 20:57:14 +0000
with message-id <[email protected]>
and subject line Bug#657537: fixed in ircd-hybrid 1:7.2.2.dfsg.2-7
has caused the Debian Bug report #657537,
regarding Please enable hardened build flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
657537: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=657537
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ircd-hybrid
Version: 1:7.2.2.dfsg.2-6.3
Severity: important
Tags: patch

Please enable hardened build flags through dpkg-buildflags.

Patch attached. (dpkg-buildflags abides "noopt" from DEB_BUILD_OPTIONS)

The hardened build flags exposed a missing format string, for which
I have attached a patch as well.

Cheers,
        Moritz
diff -aur ircd-hybrid-7.2.2.dfsg.2.harden/debian/rules ircd-hybrid-7.2.2.dfsg.2/debian/rules
--- ircd-hybrid-7.2.2.dfsg.2.harden/debian/rules	2012-01-26 21:51:08.000000000 +0100
+++ ircd-hybrid-7.2.2.dfsg.2/debian/rules	2012-01-26 21:52:07.000000000 +0100
@@ -31,12 +31,6 @@
 I_DOC = $(I)/usr/share/doc/ircd-hybrid
 I_ETC = $(I)/etc/ircd-hybrid
 
-ifneq (,$(findstring noopt,$(DEB_BUILD_OPTIONS)))
-	CFLAGS += -O0
-else
-	CFLAGS += -O2
-endif
-
 buildtype := $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
 hosttype := $(shell dpkg-architecture -qDEB_HOST_GNU_TYPE)
 
@@ -75,7 +69,6 @@
 	dpkg-checkbuilddeps
 endif
 	dh_testdir
-	CFLAGS= \
 	./configure	$(crossflags) $(sslflags) \
 			--with-nicklen=$(NICKLEN) \
 			--with-topiclen=$(TOPICLEN) \
@@ -89,6 +82,7 @@
 			--libdir=/usr/lib/ircd-hybrid \
 			$(configure_options) \
 			--with-maxclients=$(MAXCLIENTS) \
+			$(shell dpkg-buildflags --export=configure) \
 			--enable-halfops
 	touch $@
 
Nur in ircd-hybrid-7.2.2.dfsg.2/debian: rules~.
diff -aur ircd-hybrid-7.2.2.dfsg.2.harden/src/restart.c ircd-hybrid-7.2.2.dfsg.2/src/restart.c
--- ircd-hybrid-7.2.2.dfsg.2.harden/src/restart.c	2006-07-17 08:31:26.000000000 +0200
+++ ircd-hybrid-7.2.2.dfsg.2/src/restart.c	2012-01-26 21:54:08.000000000 +0100
@@ -79,7 +79,7 @@
     sendto_one(target_p, ":%s ERROR :%s", me.name, buffer);
   }
 
-  ilog(L_NOTICE, buffer);
+  ilog(L_NOTICE, "%s", buffer);
 
   send_queued_all();
   close_fds(NULL);
Nur in ircd-hybrid-7.2.2.dfsg.2/src: restart.c~.

--- End Message ---
--- Begin Message ---
Source: ircd-hybrid
Source-Version: 1:7.2.2.dfsg.2-7

We believe that the bug you reported is fixed in the latest version of
ircd-hybrid, which is due to be installed in the Debian FTP archive:

hybrid-dev_7.2.2.dfsg.2-7_all.deb
  to main/i/ircd-hybrid/hybrid-dev_7.2.2.dfsg.2-7_all.deb
ircd-hybrid_7.2.2.dfsg.2-7.diff.gz
  to main/i/ircd-hybrid/ircd-hybrid_7.2.2.dfsg.2-7.diff.gz
ircd-hybrid_7.2.2.dfsg.2-7.dsc
  to main/i/ircd-hybrid/ircd-hybrid_7.2.2.dfsg.2-7.dsc
ircd-hybrid_7.2.2.dfsg.2-7_amd64.deb
  to main/i/ircd-hybrid/ircd-hybrid_7.2.2.dfsg.2-7_amd64.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Moritz Muehlenhoff <[email protected]> (supplier of updated ircd-hybrid package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 07 Apr 2012 21:34:25 +0200
Source: ircd-hybrid
Binary: ircd-hybrid hybrid-dev
Architecture: source all amd64
Version: 1:7.2.2.dfsg.2-7
Distribution: unstable
Urgency: low
Maintainer: Joshua Kwan <[email protected]>
Changed-By: Moritz Muehlenhoff <[email protected]>
Description: 
 hybrid-dev - development files for ircd-hybrid
 ircd-hybrid - high-performance secure IRC server
Closes: 657537
Changes: 
 ircd-hybrid (1:7.2.2.dfsg.2-7) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Orphan package. As indicated in #548366, Joshua Kwan is no longer
     interested and there's no visible activity by Aurelien for a long
     time now.
   * Enable hardened build flags and fix missing format string (also
     forwarded and accepted upstream) (Closes: #657537)
Checksums-Sha1: 
 363d974b071362c67ede08719e27bfc742f996f2 1229 ircd-hybrid_7.2.2.dfsg.2-7.dsc
 f9c087a7abfd0235e101fd6ee9c55368101fbdd1 117681 
ircd-hybrid_7.2.2.dfsg.2-7.diff.gz
 5f58dfe9f6f5e967d061a738b45f33180af684b5 66544 
hybrid-dev_7.2.2.dfsg.2-7_all.deb
 815558ac1da372f8b7b71578505eb777a93d46e8 611696 
ircd-hybrid_7.2.2.dfsg.2-7_amd64.deb
Checksums-Sha256: 
 c127e3c924fedaf2170f474e3b319b22936284b02e6b644b454d4770799dc807 1229 
ircd-hybrid_7.2.2.dfsg.2-7.dsc
 5c7823d1727784e653346e9c3495d31f5db87572173153cb31c78c40df9ce9aa 117681 
ircd-hybrid_7.2.2.dfsg.2-7.diff.gz
 fd03fd5c62d6fa28c9b8ca4f71e7fe8b6097ed7f2e8fb33f7878f45e6321198e 66544 
hybrid-dev_7.2.2.dfsg.2-7_all.deb
 6d3da9817c7826152d6f43e90a1ad20f01c1fc6e90f0c48020c885082b5db44b 611696 
ircd-hybrid_7.2.2.dfsg.2-7_amd64.deb
Files: 
 17802ab8a5b95dd086852bbb4e595299 1229 net optional 
ircd-hybrid_7.2.2.dfsg.2-7.dsc
 394ed820e4a339ff1547fde6ffd82d99 117681 net optional 
ircd-hybrid_7.2.2.dfsg.2-7.diff.gz
 2921498a406edc3ccbd86fc7a7e927cc 66544 devel optional 
hybrid-dev_7.2.2.dfsg.2-7_all.deb
 a1dd7126a88676d94f5421fe2a87813f 611696 net optional 
ircd-hybrid_7.2.2.dfsg.2-7_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iEYEARECAAYFAk+AmW8ACgkQXm3vHE4uyloyowCeOQYJCFPnvz7YZyXlTseQX8Mf
v54AoM3a6Knij+8Fe2uXRZ5vLfwFb6Ap
=OOg6
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to