Your message dated Mon, 16 Apr 2012 09:34:15 +0000
with message-id <[email protected]>
and subject line Bug#655891: fixed in dmidecode 2.11-6
has caused the Debian Bug report #655891,
regarding Please enabled hardened build flags
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
655891: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=655891
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dmidecode
Version: 2.11-4
Severity: important
Tags: patch

Please enabled hardened build flags through dpkg-buildflags.

Patch attached. I needed to make additional changes to the
Makefile, since otherwise the flags configured in debian/rules
are overridden.

(dpkg-buildflags abides "noopt" from DEB_BUILD_OPTIONS)

Cheers,
        Moritz
diff -aur dmidecode-2.11.harden/debian/rules dmidecode-2.11/debian/rules
--- dmidecode-2.11.harden/debian/rules	2011-10-28 21:53:58.000000000 +0200
+++ dmidecode-2.11/debian/rules	2012-01-14 17:04:08.000000000 +0100
@@ -1,6 +1,10 @@
 #!/usr/bin/make -f
 
 # Flags fetched from the upstream Makefile.
+
+CFLAGS = `dpkg-buildflags --get CFLAGS`
+CFLAGS += `dpkg-buildflags --get CPPFLAGS`
+
 CFLAGS +=	-W -Wall -pedantic -Wshadow -Wstrict-prototypes -Wpointer-arith \
 		-Wcast-qual -Wcast-align -Wwrite-strings -Wmissing-prototypes -Winline -Wundef
 
@@ -10,11 +14,13 @@
 # Dropped -ansi as it break building on ia64
 CFLAGS +=	-ansi
 
+LDFLAGS = `dpkg-buildflags --get LDFLAGS`
+
 %:
 	dh ${@}
 
 override_dh_auto_build:
-	dh_auto_build -- CFLAGS="$(CFLAGS)"
+	dh_auto_build -- CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)"
 
 override_dh_auto_install:
 	dh_auto_install -- prefix=/usr
diff -aur dmidecode-2.11.harden/Makefile dmidecode-2.11/Makefile
--- dmidecode-2.11.harden/Makefile	2012-01-14 16:57:02.000000000 +0100
+++ dmidecode-2.11/Makefile	2012-01-14 17:01:46.000000000 +0100
@@ -13,17 +13,17 @@
 #
 
 CC      = gcc
-CFLAGS  = -W -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual \
-          -Wcast-align -Wwrite-strings -Wmissing-prototypes -Winline -Wundef
+#CFLAGS  = -W -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith -Wcast-qual \
+#          -Wcast-align -Wwrite-strings -Wmissing-prototypes -Winline -Wundef
 #CFLAGS += -DBIGENDIAN
 #CFLAGS += -DALIGNMENT_WORKAROUND
 
 # When debugging, disable -O2 and enable -g.
-CFLAGS += -O2
+#CFLAGS += -O2
 #CFLAGS += -g
 
 # Pass linker flags here
-LDFLAGS =
+#LDFLAGS =
 
 DESTDIR =
 prefix  = /usr/local



--- End Message ---
--- Begin Message ---
Source: dmidecode
Source-Version: 2.11-6

We believe that the bug you reported is fixed in the latest version of
dmidecode, which is due to be installed in the Debian FTP archive:

dmidecode-udeb_2.11-6_i386.udeb
  to main/d/dmidecode/dmidecode-udeb_2.11-6_i386.udeb
dmidecode_2.11-6.debian.tar.gz
  to main/d/dmidecode/dmidecode_2.11-6.debian.tar.gz
dmidecode_2.11-6.dsc
  to main/d/dmidecode/dmidecode_2.11-6.dsc
dmidecode_2.11-6_i386.deb
  to main/d/dmidecode/dmidecode_2.11-6_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Baumann <[email protected]> (supplier of updated 
dmidecode package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 16 Apr 2012 09:23:37 +0000
Source: dmidecode
Binary: dmidecode dmidecode-udeb
Architecture: source i386
Version: 2.11-6
Distribution: unstable
Urgency: low
Maintainer: Daniel Baumann <[email protected]>
Changed-By: Daniel Baumann <[email protected]>
Description: 
 dmidecode  - SMBIOS/DMI table decoder
 dmidecode-udeb - SMBIOS/DMI table decoder (udeb) (udeb)
Closes: 655891
Changes: 
 dmidecode (2.11-6) unstable; urgency=low
 .
   * Also passing ldflags to configure to enable all hardening build
     flags (Closes: #655891).
   * Updating to standards version 3.9.3.
   * Updating copyright file machine-readable format version 1.0.
Checksums-Sha1: 
 d733a8722a2d112198de7cf61bacc8515ff540b7 1166 dmidecode_2.11-6.dsc
 4b53195a10b74869fda6e0c3bf84a5e1be8761be 66389 dmidecode_2.11.orig.tar.gz
 356f61565d8b5197130a765bdf40b2b70c6e600e 8325 dmidecode_2.11-6.debian.tar.gz
 19c5d8435555a78cb7604df86458016c8ee1e971 74718 dmidecode_2.11-6_i386.deb
 0ad3e134084bb8ad77385c733df704e907a78ddf 34638 dmidecode-udeb_2.11-6_i386.udeb
Checksums-Sha256: 
 e524f6f676015605c194ff3518da7600a1ad50c99167ceb4a9cbab8973848f71 1166 
dmidecode_2.11-6.dsc
 d99ee210ecbd6caff2cf6d95dec6d88818c16cec1a08ed0963fd8702f6af8b59 66389 
dmidecode_2.11.orig.tar.gz
 c8e5531292a142c41cc394fa5e43d7c1a6f8e9d11a083c7c96dcfdf5421f7267 8325 
dmidecode_2.11-6.debian.tar.gz
 392bf010b8b45fad6bc4f6a5edde263133ea0a77cb6e3404dcf39a27fe48beb8 74718 
dmidecode_2.11-6_i386.deb
 00f33066e170d0b7ed23278cb08360d2ed4818df2560188c497ff46d89aed2f6 34638 
dmidecode-udeb_2.11-6_i386.udeb
Files: 
 5d8d11f253afa6e7b8c7623a8b746d69 1166 utils optional dmidecode_2.11-6.dsc
 9fddbbc3e330bee5950b8b5d424a57cb 66389 utils optional 
dmidecode_2.11.orig.tar.gz
 f14e1cccc417fafe042d3b78990bf354 8325 utils optional 
dmidecode_2.11-6.debian.tar.gz
 740c9fde954ecbb97ae983cd35ab26f8 74718 utils important 
dmidecode_2.11-6_i386.deb
 befa1baecf5de843a1fa2b7fe707ac48 34638 debian-installer optional 
dmidecode-udeb_2.11-6_i386.udeb
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)

iEYEARECAAYFAk+L5b4ACgkQ+C5cwEsrK54n6wCfW/1Q8FuAVXFSmvmKE6u2OgwZ
BEwAn2t9VIC5WnpoX1wK7oscRSTKOuxc
=tg2h
-----END PGP SIGNATURE-----



--- End Message ---

Reply via email to