Your message dated Sun, 27 May 2012 06:17:24 +0000
with message-id <[email protected]>
and subject line Bug#641570: fixed in frogatto 1.2+dfsg-1
has caused the Debian Bug report #641570,
regarding frogatto: FTBFS with ld that defaults to --as-needed: bad link order
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
641570: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641570
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: frogatto
Version: 1.1+dfsg-4
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch oneiric
frogatto fails to build with a linker that defaults to --as-needed, as
shown in this Ubuntu bug report (see comment #1):
https://bugs.launchpad.net/ubuntu/+source/frogatto/+bug/771073
This is because of incorrect link ordering: it puts libraries before the
objects that use them rather than after. See:
http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries
The following patch fixes this.
* Fix link order to list libraries after the objects that require them.
diff -Nru frogatto-1.1+dfsg/debian/patches/link-order.patch
frogatto-1.1+dfsg/debian/patches/link-order.patch
--- frogatto-1.1+dfsg/debian/patches/link-order.patch 1970-01-01
01:00:00.000000000 +0100
+++ frogatto-1.1+dfsg/debian/patches/link-order.patch 2011-09-14
12:49:02.000000000 +0100
@@ -0,0 +1,40 @@
+Description: List libraries after the objects that require them
+Author: Colin Watson <[email protected]>
+Bug-Ubuntu: https://bugs.launchpad.net/bugs/771073
+Forwarded: no
+Last-Update: 2011-09-14
+
+Index: b/Makefile
+===================================================================
+--- a/Makefile
++++ b/Makefile
+@@ -16,10 +16,10 @@
+ $(CXX) -DIMPLEMENT_SAVE_PNG -fno-inline-functions -g $(OPT) `sdl-config
--cflags` -D_GNU_SOURCE=1 -D_REENTRANT -Wnon-virtual-dtor -Wreturn-type
-fthreadsafe-statics -c $<
+
+ game: $(objects)
+- $(CXX) -g $(OPT) -L. -L/sw/lib -L. -D_GNU_SOURCE=1 -D_REENTRANT
-Wnon-virtual-dtor -Wreturn-type -L/usr/lib `sdl-config --libs` -lSDLmain -lSDL
-lGL -lGLU -lGLEW -lSDL_image -lSDL_ttf -lSDL_mixer -lpng -lboost_regex-mt
-lboost_system-mt -lpthread -fthreadsafe-statics $(objects) -o game
++ $(CXX) -g $(OPT) -L. -L/sw/lib -L. -D_GNU_SOURCE=1 -D_REENTRANT
-Wnon-virtual-dtor -Wreturn-type $(objects) -L/usr/lib `sdl-config --libs`
-lSDLmain -lSDL -lGL -lGLU -lGLEW -lSDL_image -lSDL_ttf -lSDL_mixer -lpng
-lboost_regex-mt -lboost_system-mt -lpthread -fthreadsafe-statics -o game
+
+ server: $(server_objects)
+- $(CXX) -fno-inline-functions -g $(OPT) -L/sw/lib -D_GNU_SOURCE=1
-D_REENTRANT -Wnon-virtual-dtor -Wreturn-type -L/usr/lib `sdl-config --libs`
-lSDLmain -lSDL -lGL -lGLU -lSDL_image -lSDL_ttf -lSDL_mixer -lboost_regex-mt
-lboost_system-mt -lboost_thread-mt -lboost_iostreams-mt -fthreadsafe-statics
$(server_objects) -o server
++ $(CXX) -fno-inline-functions -g $(OPT) -L/sw/lib -D_GNU_SOURCE=1
-D_REENTRANT -Wnon-virtual-dtor -Wreturn-type $(server_objects) -L/usr/lib
`sdl-config --libs` -lSDLmain -lSDL -lGL -lGLU -lSDL_image -lSDL_ttf
-lSDL_mixer -lboost_regex-mt -lboost_system-mt -lboost_thread-mt
-lboost_iostreams-mt -fthreadsafe-statics -o server
+
+ poolalloc.o: src/poolalloc.c
+ $(CC) -fno-inline-functions -g $(OPT) `sdl-config --cflags`
-D_GNU_SOURCE=1 -D_REENTRANT -Wreturn-type -c src/poolalloc.c
+@@ -28,13 +28,13 @@
+ $(CC) -fno-inline-functions -g $(OPT) `sdl-config --cflags`
-D_GNU_SOURCE=1 -D_REENTRANT -DUSE_LOCKS=1 -Wreturn-type -c src/malloc.c
+
+ formula_test: $(formula_test_objects)
+- $(CXX) -O2 -g -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT
-DUNIT_TEST_FORMULA -Wnon-virtual-dtor -Wreturn-type -L/usr/lib -lSDL -lGL
-lGLU -lSDL_image -lSDL_ttf -lSDL_mixer -lboost_regex src/formula.cpp
$(formula_test_objects) -o test
++ $(CXX) -O2 -g -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT
-DUNIT_TEST_FORMULA -Wnon-virtual-dtor -Wreturn-type src/formula.cpp
$(formula_test_objects) -L/usr/lib -lSDL -lGL -lGLU -lSDL_image -lSDL_ttf
-lSDL_mixer -lboost_regex -o test
+
+ wml_modify_test: $(wml_modify_test_objects)
+- $(CXX) -O2 -g -framework Cocoa -I/usr/local/include/boost-1_34
-I/sw/include/SDL -Isrc/ -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT
-DUNIT_TEST_WML_MODIFY -Wnon-virtual-dtor -Wreturn-type -L/usr/lib
-lboost_regex src/wml_modify.cpp $(wml_modify_test_objects) -o test
++ $(CXX) -O2 -g -framework Cocoa -I/usr/local/include/boost-1_34
-I/sw/include/SDL -Isrc/ -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT
-DUNIT_TEST_WML_MODIFY -Wnon-virtual-dtor -Wreturn-type src/wml_modify.cpp
$(wml_modify_test_objects) -L/usr/lib -lboost_regex -o test
+
+ wml_schema_test: $(wml_schema_test_objects)
+- $(CXX) -O2 -g -framework Cocoa -I/usr/local/include/boost-1_34
-I/sw/include/SDL -Isrc/ -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT
-DUNIT_TEST_WML_SCHEMA -Wnon-virtual-dtor -Wreturn-type -L/usr/lib
-lboost_regex src/wml_schema.cpp $(wml_schema_test_objects) -o test
++ $(CXX) -O2 -g -framework Cocoa -I/usr/local/include/boost-1_34
-I/sw/include/SDL -Isrc/ -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT
-DUNIT_TEST_WML_SCHEMA -Wnon-virtual-dtor -Wreturn-type src/wml_schema.cpp
$(wml_schema_test_objects) -L/usr/lib -lboost_regex -o test
+
+ update-pot:
+ utils/make-pot.sh > po/frogatto.pot
diff -Nru frogatto-1.1+dfsg/debian/patches/series
frogatto-1.1+dfsg/debian/patches/series
--- frogatto-1.1+dfsg/debian/patches/series 2011-06-19 14:21:06.000000000
+0100
+++ frogatto-1.1+dfsg/debian/patches/series 2011-09-14 12:45:37.000000000
+0100
@@ -1 +1,2 @@
disable-ccache.patch
+link-order.patch
--
Colin Watson [[email protected]]
--- End Message ---
--- Begin Message ---
Source: frogatto
Source-Version: 1.2+dfsg-1
We believe that the bug you reported is fixed in the latest version of
frogatto, which is due to be installed in the Debian FTP archive:
frogatto_1.2+dfsg-1.debian.tar.gz
to contrib/f/frogatto/frogatto_1.2+dfsg-1.debian.tar.gz
frogatto_1.2+dfsg-1.dsc
to contrib/f/frogatto/frogatto_1.2+dfsg-1.dsc
frogatto_1.2+dfsg-1_amd64.deb
to contrib/f/frogatto/frogatto_1.2+dfsg-1_amd64.deb
frogatto_1.2+dfsg.orig.tar.gz
to contrib/f/frogatto/frogatto_1.2+dfsg.orig.tar.gz
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Dmitry E. Oboukhov <[email protected]> (supplier of updated frogatto package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: RIPEMD160
Format: 1.8
Date: Sun, 27 May 2012 09:52:56 +0400
Source: frogatto
Binary: frogatto
Architecture: source amd64
Version: 1.2+dfsg-1
Distribution: unstable
Urgency: low
Maintainer: Dmitry E. Oboukhov <[email protected]>
Changed-By: Dmitry E. Oboukhov <[email protected]>
Description:
frogatto - 2D platformer game starring a quixotic frog
Closes: 641570 662580 669295
Changes:
frogatto (1.2+dfsg-1) unstable; urgency=low
.
[ Vincent Cheng ]
* Non-maintainer upload.
* New upstream release. (Closes: #662580)
- Fix FTBFS with -Wl,--as-needed due to bad link order. (Closes: #641570)
* Drop +ssh protocol in debian/control Vcs-* fields. (Closes: #669295)
* Enable build hardening using dpkg-buildflags.
- Add debian/patches/enable-build-hardening.patch.
* Remove deprecated Encoding field from desktop menu file (lintian tag
desktop-entry-contains-encoding-key).
* Fix debian/watch file to point to latest release hosted on Github.
* Update to Standards version 3.9.3, no changes required.
.
[ Dmitry E. Oboukhov ]
* Add Vincent Cheng to Uploaders list.
Checksums-Sha1:
ef84468ff060bac713e725157fa0e95e48f5d981 1600 frogatto_1.2+dfsg-1.dsc
7be728cd790b83a442f7db77149df7c6fbd122a3 1186195 frogatto_1.2+dfsg.orig.tar.gz
f4ea1198e84c12d717cf59fd0e61a65f1ef3b5d5 9961 frogatto_1.2+dfsg-1.debian.tar.gz
e4715cd16eb5b275c08901f6b43c09ad3680c952 1858160 frogatto_1.2+dfsg-1_amd64.deb
Checksums-Sha256:
cd6d1626da4ea3904fdd9922afb9710b5d854148977889f6cb0912ab932a8ab5 1600
frogatto_1.2+dfsg-1.dsc
3c9fbfab69bb2d6454db650cef9921fd1b2e3dff61519efe724cfae10fa2d3d4 1186195
frogatto_1.2+dfsg.orig.tar.gz
896ba956e3b6658dd87101e5a73e5f9233a891bc7b8623e80c8c52da159a6b1a 9961
frogatto_1.2+dfsg-1.debian.tar.gz
b2b47ccf5e7219a899851c346f3bc8a1103e760c84e8bd5c1fb603df8cec3a35 1858160
frogatto_1.2+dfsg-1_amd64.deb
Files:
e40ca670bc49be175ef246a2da270d5e 1600 contrib/games extra
frogatto_1.2+dfsg-1.dsc
5626236dae4df8efc62e33de8775558b 1186195 contrib/games extra
frogatto_1.2+dfsg.orig.tar.gz
298e008c81505e5b9af1327af5e10427 9961 contrib/games extra
frogatto_1.2+dfsg-1.debian.tar.gz
b911872195f34e04971c8d3aaa5ffa24 1858160 contrib/games extra
frogatto_1.2+dfsg-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
iEYEAREDAAYFAk/BxEUACgkQq4wAz/jiZTeQPgCgsnCRPs2j9i9ShoNHB2pkBuLY
G4EAoOlEfbhJKzG54/qxKldcIDTv6DEH
=NnHi
-----END PGP SIGNATURE-----
--- End Message ---
