Your message dated Sun, 27 May 2012 09:05:12 +0000
with message-id <[email protected]>
and subject line Bug#674636: fixed in xmoto 0.5.9+dfsg-3
has caused the Debian Bug report #674636,
regarding xmoto: FTBFS because of non-standard sa_restorer
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
674636: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674636
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: xmoto
Version: 0.5.9+dfsg-1
Severity: serious
Tags: patch
Justification: fails to build from source (but built successfully in the past)
Hi,
new xmoto 0.5.9 fails on ia64, kfreebsd and hurd because of the
unconditional "usage" of the sa_restorer field of struct sigaction.
POSIX[1] does not specify a sa_restorer field at all, and in the Linux
manpages[2] it is declared as obsolete and advertized against its use.
After all, what the code is really doing is to reset all the fields of
the struct sigaction v_act; what can be done to do that in a simplier
(and portable) way is just to memset it to 0 before using it (this also
avoids to manually set sa_flags, and a #ifdef snippet there).
Attached there is a patch for it (I admittely tested it only on Hurd,
but I think it should make xmoto compile on all the archs mentioned
above).
[1] http://pubs.opengroup.org/onlinepubs/9699919799/functions/sigaction.html
[2] http://www.kernel.org/doc/man-pages/online/pages/man2/sigaction.2.html
Thanks,
--
Pino
--- a/src/GameInit.cpp
+++ b/src/GameInit.cpp
@@ -268,12 +268,9 @@ void GameApp::run_load(int nNumArgs, cha
if(v_xmArgs.isOptServerOnly()) {
struct sigaction v_act;
+ memset(&v_act, 0, sizeof(struct sigaction));
v_act.sa_handler = xmexit_term;
-#if !defined(__APPLE__) && !defined(__FreeBSD__)
- v_act.sa_restorer = NULL;
-#endif
sigemptyset(&v_act.sa_mask);
- v_act.sa_flags = 0;
if(sigaction(SIGTERM, &v_act, NULL) != 0) {
LogWarning("sigaction failed");
--- End Message ---
--- Begin Message ---
Source: xmoto
Source-Version: 0.5.9+dfsg-3
We believe that the bug you reported is fixed in the latest version of
xmoto, which is due to be installed in the Debian FTP archive:
xmoto-data_0.5.9+dfsg-3_all.deb
to main/x/xmoto/xmoto-data_0.5.9+dfsg-3_all.deb
xmoto_0.5.9+dfsg-3.debian.tar.gz
to main/x/xmoto/xmoto_0.5.9+dfsg-3.debian.tar.gz
xmoto_0.5.9+dfsg-3.dsc
to main/x/xmoto/xmoto_0.5.9+dfsg-3.dsc
xmoto_0.5.9+dfsg-3_i386.deb
to main/x/xmoto/xmoto_0.5.9+dfsg-3_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Stephen Kitt <[email protected]> (supplier of updated xmoto package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Sat, 26 May 2012 20:31:17 +0200
Source: xmoto
Binary: xmoto xmoto-data
Architecture: source i386 all
Version: 0.5.9+dfsg-3
Distribution: unstable
Urgency: low
Maintainer: Debian Games Team <[email protected]>
Changed-By: Stephen Kitt <[email protected]>
Description:
xmoto - 2D motocross platform game
xmoto-data - 2D motocross platform game - data files
Closes: 674636
Changes:
xmoto (0.5.9+dfsg-3) unstable; urgency=low
.
* Pino Toscano provided a better patch to remove the use of sa_restorer,
thanks! (Closes: #674636.)
Checksums-Sha1:
92ca47a787b42ca594ab16ac6cdcda3eb85487c4 2410 xmoto_0.5.9+dfsg-3.dsc
9d3f4a251cd603c163f339584ac6804f138bd753 17892 xmoto_0.5.9+dfsg-3.debian.tar.gz
c4d1b79b34e9041b0fa2c16a819f6a5ab33c8a64 1846544 xmoto_0.5.9+dfsg-3_i386.deb
9097b1c5e4fbdfcd39c9c9e9eea5b04d565f1208 37650802
xmoto-data_0.5.9+dfsg-3_all.deb
Checksums-Sha256:
9627a5cf9c9f004b6d4f12e0bc7a62e2f83e373556b4dc8c0425c70e84aa853f 2410
xmoto_0.5.9+dfsg-3.dsc
53c62329d5d5d8fb75b739a335e7f6bb1117f2594302a96034508a6496e92fb7 17892
xmoto_0.5.9+dfsg-3.debian.tar.gz
f7ce0fe155373d3d4e5515aaab9fafac8d4d8e0f954622e6f97d89b17cdc3ba9 1846544
xmoto_0.5.9+dfsg-3_i386.deb
a6f9e75c5f60e2752fd4eb5beabcb4a5212f5d3d62e86fbeb64e2fc1233a9e37 37650802
xmoto-data_0.5.9+dfsg-3_all.deb
Files:
ab989d2f75fde3a0223f23914b14d2cc 2410 games optional xmoto_0.5.9+dfsg-3.dsc
ada8de8cc1d596c55a180a2f58ff1d3e 17892 games optional
xmoto_0.5.9+dfsg-3.debian.tar.gz
ac77a0c4cffc307a3dce8770c9f9431a 1846544 games optional
xmoto_0.5.9+dfsg-3_i386.deb
9350fc62393e98c378fc5cb41cd7f919 37650802 games optional
xmoto-data_0.5.9+dfsg-3_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJPwedmAAoJEHWXeKmja0lPnikP/jFk2xv3LEI2pPFt1UektGcW
JS4LKY2ajOmspsAtRiXxQYwS74szzneSu5LIusemmbmhwLfdM4j2ko/EAGZrUVP7
fYKx+VN/zanYfU1JnRH4I7ZUHZxmVU3smqqSFlE6We7/BVitGUmmByEjiCFWe+ij
1Hg8p5MIiFaNKCFcYSsVg6E9S0YGiujOYeLBjmLNY8bqEEzf1e31Pq2yTsVorGu5
lA8bIDltoYB5pYti78/LKqszxm9A/kZEqOQQ+tVsjFHS78m9wcM/Z4/10lucF8a0
4KvujTqFm9Vn3kT8jN8PvK0rM6f4GuuyJ8Ibhf2oAyDRG8zOoMLIYA7uD2KKrb5C
CWIMosrNA5WGjX0tVUsP3WsBhmXMX6WAsn675KL5/lSqeoaYW2XHjNOvj3jaZ8j6
MUrpTgiUyCwpkikYrnU3xTI3j6aqybtaUrmjrRWBjI43/e7zv1dH0GTVIDJF+JET
rUOB8f6jt7aCfHrhHNTEOco7tbMOocJgG8qhKJ1berDnjt+LWMm7TlbHwAsSyHSE
+FaiFU3rVXHRbBccmXkU8Vpbs1c6n+ePKTpsSK+Op/yH4/ozj2JE03vJnoQNezYB
uqJ0A/UKXaHe+2PJxjPC5KIh8OCWGkJA0A7M/tYzznbwTU8iwwspqxj9cDAauYey
LcT/umqEI5W+vWOkpHZP
=pR8p
-----END PGP SIGNATURE-----
--- End Message ---
