Your message dated Thu, 28 Jun 2012 19:29:57 +0200
with message-id <[email protected]>
and subject line re: [PATCH] Fix wrong NFS umount path
has caused the Debian Bug report #679011,
regarding [PATCH] Fix wrong NFS umount path
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
679011: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=679011
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: klibc
Version: 2.0-2
Hi, [filing a bug report after having posted to [email protected] ]
When mounting a NFS share and an error occurs for some reason, the NFS
share is not unmounted correctly: the local path is used instead of the
remote path in the umount_v[23]() call. This patch fixes this.
I found this while debugging some problems mounting the root file system
on NFS in a test system; I saw this in the logs (/mnt/duplicated is the
legitimate remote path):
Jun 21 21:52:35 pangolin-test rpc.mountd[11155]: authenticated mount
request from 192.168.42.2:984 for /mnt/duplicated (/mnt/duplicated)
Jun 21 21:52:35 pangolin-test rpc.mountd[11155]: refused unmount
request from 192.168.42.2 for /root (/): no export entry
I didn't understand why the hell it was trying to umount /root. You can
look at google for this and you'll find a lot of people wondering what
this is. I think that the big issue with this is that _a lot_ of
problems appearing _after_ not unmounting correctly the share the first
time are caused by this: I used to get mounting errors with “Stale NFS
file handle” that would never go away (NFS is so much a PITA for this
statefull behavior). You'll find a lot of people on the net trying to
reboot their NFS server and the like, in hope this errors goes away.
It was also quite misleading that the mount point for the root FS in the
initramfs is called /root. Anyway, a lot of these problems go away with
this patch.
BTW, this bug is more than 9 years old, since the inception of nfsmount!
Signed-off-by: Benjamin Cama <[email protected]>
---
usr/kinit/nfsmount/mount.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/usr/kinit/nfsmount/mount.c b/usr/kinit/nfsmount/mount.c
index e3838f4..e0687a6 100644
--- a/usr/kinit/nfsmount/mount.c
+++ b/usr/kinit/nfsmount/mount.c
@@ -329,9 +329,9 @@ int nfs_mount(const char *pathname, const char *hostname,
bail:
if (mounted) {
if (data->flags & NFS_MOUNT_VER3)
- umount_v3(path, clnt);
+ umount_v3(rem_path, clnt);
else
- umount_v2(path, clnt);
+ umount_v2(rem_path, clnt);
}
ret = -1;
--
Benjamin Cama <[email protected]>
--- End Message ---
--- Begin Message ---
Thank you very much for the patch, this got fixed in klibc
upstream and prompted 2.0.1 release:
http://www.zytor.com/pipermail/klibc/2012-June/003315.html
I just uploaded it to debian, forgot to include
bug closure on upload, thus closing now, pasting changelog:
klibc (2.0.1-1) unstable; urgency=high
* New upstream release (nfsmount, get{host,domain}name())
* debian/watch: fix file for new repo layout.
-- maximilian attems <[email protected]> Thu, 28 Jun 2012 18:29:48 +0200
--
maks
--- End Message ---
