Your message dated Thu, 16 Aug 2012 11:32:49 +0000
with message-id <[email protected]>
and subject line Bug#685056: fixed in slirp 1:1.0.17-7
has caused the Debian Bug report #685056,
regarding slirp: IPCP negotiation fails for 64-bit hosts
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
685056: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=685056
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: slirp
Version: 1:1.0.17-4
Severity: important
Tags: patch

Due to incorrect use of "sizeof(long)" in src/ppp/ipcp.c, a 64-bit host may 
send back incorrect
IPCP NAKs in response to a client sending an IPCP configure request that 
includes DNS/WINS
options.

Example data observed (for a host using 205.137.237.222 and 8.8.8.8 for DNS):
data in  -> client requests IP and DNS addresses from host (configure request)
raw: 7E 80 21 01 01 00 16 03 06 00 00 00 00 81 06 00 00 00 00 83 06 00 00 00 00 
0E 5B 7E
data out <- host sends NAK with offered IP and DNS addresses (configure nak)
raw: 7E FF 03 80 21 03 01 00 16 03 06 0A 00 CD 86 ED DE 00 00 08 08 08 08 00 00 
00 00 29 E2 7E

The NAK response offers an incorrect IP address and no DNS IPs, which 
eventually causes
negotiation to fail.

Proposed solution is to change "sizeof (long)" to "sizeof (u_int32_t)" to 
correctly match the
length of IPV4 addresses, using following patch or similar:

--- a/ipcp.c
+++ b/ipcp.c
@@ -881,7 +881,7 @@
            }
            GETLONG(tl,p);
            if (htonl(tl) != wo->dnsaddr[0]) {
-                DECPTR(sizeof (long),p);
+                DECPTR(sizeof (u_int32_t),p);
                tl = ntohl(wo->dnsaddr[0]);
                PUTLONG(tl, p);
                orc = CONFNAK;
@@ -899,7 +899,7 @@
            }
            GETLONG(tl,p);
            if (htonl(tl) != wo->winsaddr[0]) {
-                DECPTR(sizeof (long),p);
+                DECPTR(sizeof (u_int32_t),p);
                tl = ntohl(wo->winsaddr[0]);
                PUTLONG(tl, p);
                orc = CONFNAK;
@@ -917,7 +917,7 @@
            }
            GETLONG(tl,p);
            if (htonl(tl) != wo->dnsaddr[1]) { /* and this is the 2nd one */
-                DECPTR(sizeof (long),p);
+                DECPTR(sizeof (u_int32_t),p);
                tl = ntohl(wo->dnsaddr[1]);
                PUTLONG(tl, p);
                orc = CONFNAK;
@@ -935,7 +935,7 @@
            }
            GETLONG(tl,p);
            if (htonl(tl) != wo->winsaddr[1]) { /* and this is the 2nd one */
-                DECPTR(sizeof (long),p);
+                DECPTR(sizeof (u_int32_t),p);
                tl = ntohl(wo->winsaddr[1]);
                PUTLONG(tl, p);
                orc = CONFNAK;



-- System Information:
Debian Release: 6.0.2
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-274.7.1.el5.028stab095.1 (SMP w/1 CPU core)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/bash

Versions of packages slirp depends on:
ii  libc6                         2.11.3-3   Embedded GNU C Library: Shared lib

slirp recommends no packages.

slirp suggests no packages.

-- no debconf information

--- End Message ---
--- Begin Message ---
Source: slirp
Source-Version: 1:1.0.17-7

We believe that the bug you reported is fixed in the latest version of
slirp, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Roberto Lumbreras <[email protected]> (supplier of updated slirp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 16 Aug 2012 11:19:57 +0200
Source: slirp
Binary: slirp
Architecture: source i386
Version: 1:1.0.17-7
Distribution: unstable
Urgency: low
Maintainer: Roberto Lumbreras <[email protected]>
Changed-By: Roberto Lumbreras <[email protected]>
Description: 
 slirp      - SLIP/PPP emulator using a dial up shell account
Closes: 685056
Changes: 
 slirp (1:1.0.17-7) unstable; urgency=low
 .
   * Fix IPCP negotiation fails for 64-bit hosts (Closes: #685056)
   * Set debhelper compat to 9.
Checksums-Sha1: 
 265913d14222df8709c45465a9718760c531fd11 1058 slirp_1.0.17-7.dsc
 66ad8c71e222b830d076b93b168f2095bef0c6ed 15575 slirp_1.0.17-7.debian.tar.gz
 14d76f7ff8d7329f65ca8628bf9fa76fc280a9e2 255068 slirp_1.0.17-7_i386.deb
Checksums-Sha256: 
 9020a3919866f1b5d70a987514df538c2ae5b7eb880f5f5078ef71661ae44284 1058 
slirp_1.0.17-7.dsc
 3a0cf962a781bdf169710bae6e814b9ca3c1ad81e9a735717d8d457ee053931d 15575 
slirp_1.0.17-7.debian.tar.gz
 5a7215ed1f03a8cbdc364e00f088e771928056d021c78208e0b23a38284fc738 255068 
slirp_1.0.17-7_i386.deb
Files: 
 b8c9f1d5633fab53e681fc66378bbb24 1058 net optional slirp_1.0.17-7.dsc
 15bc13be3b512c62a7be7f741bd19ecc 15575 net optional 
slirp_1.0.17-7.debian.tar.gz
 fb44a7eaf59d86ba80b0530e97278009 255068 net optional slirp_1.0.17-7_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iD8DBQFQLNjSfIEQE/XJcI0RAhaYAKDyTHzGaqWv9OQ6HDT0/W1Le8FzhQCeKodv
6uU8UGDGpTwSWAm94jq13+c=
=YdOZ
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to