Your message dated Thu, 13 Sep 2012 21:31:12 -0400
with message-id <[email protected]>
and subject line Re: Bug#685818: shorewall: Unrelated env var causes failure
has caused the Debian Bug report #685818,
regarding shorewall: Unrelated env var causes failure
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
685818: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=685818
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: shorewall
Version: 4.5.5.3-1
Severity: important
Dear Maintainer,
I recently upgraded my system to wheezy, and started getting the
following type of errors when starting or restarting shorewall:
Shorewall configuration compiled to /var/lib/shorewall/.restart
/var/lib/shorewall/.restart: 2645: /var/lib/shorewall/.restart: Syntax error:
";;" unexpected (expecting "}")
/sbin/shorewall: 124: [: -lt: unexpected operator
/var/lib/shorewall/.restart: 2645: /var/lib/shorewall/.restart: Syntax error:
";;" unexpected (expecting "}")
Looking through that generated script, I discovered the following:
#
# From the params file
#
PSQL_EDITOR='vim +'set ft=sql'\"'\"
'
>From that point on, the quoting is messed up. This appears to be from
the export_params method in /usr/share/shorewall/Shorewall/Config.pm .
The variable mentioned there exported by my shell configuration with:
export PSQL_EDITOR="vim +'set ft=sql'"
If I unset that variable before restarting shorewall, the problem goes
away.
-- System Information:
Debian Release: wheezy/sid
APT prefers testing
APT policy: (500, 'testing'), (50, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 3.4.2-linode44 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages shorewall depends on:
ii bc 1.06.95-2
ii debconf [debconf-2.0] 1.5.46
ii iproute 20120521-3
ii iptables 1.4.14-3
ii perl-modules 5.14.2-12
ii shorewall-core 4.5.5.3-1
shorewall recommends no packages.
Versions of packages shorewall suggests:
ii linux-image-2.6.32-5-686 [linux-image] 2.6.32-45
ii linux-image-3.2.0-3-686-pae [linux-image] 3.2.23-1
ii make 3.81-8.2
pn shorewall-doc <none>
-- Configuration Files:
/etc/default/shorewall changed [not included]
/etc/shorewall/params [Errno 13] Permission denied: u'/etc/shorewall/params'
-- debconf information:
shorewall/invalid_config:
shorewall/dont_restart:
shorewall/major_release:
--- End Message ---
--- Begin Message ---
On Fri, Aug 24, 2012 at 04:06:26PM -0400, Aaron Schrab wrote:
>
> Shorewall configuration compiled to /var/lib/shorewall/.restart
> /var/lib/shorewall/.restart: 2645: /var/lib/shorewall/.restart: Syntax error:
> ";;" unexpected (expecting "}")
> /sbin/shorewall: 124: [: -lt: unexpected operator
> /var/lib/shorewall/.restart: 2645: /var/lib/shorewall/.restart: Syntax error:
> ";;" unexpected (expecting "}")
>
>
> Looking through that generated script, I discovered the following:
>
> #
> # From the params file
> #
> PSQL_EDITOR='vim +'set ft=sql'\"'\"
> '
>
I have discussed this issue with upstream. It comes down to upstream
having to choose between inheriting the environment of the parent shell,
or wiping out the environment. Since the latter tends to cause more
problems than the former, the decision has been made to retain the
inherited environment.
That said, you can easily avoid this problem by putting a line like
this:
PSQL_EDITOR=
into /etc/shorewall/params.
Regards,
-Roberto
--
Roberto C. Sánchez
http://people.connexer.com/~roberto
http://www.connexer.com
signature.asc
Description: Digital signature
--- End Message ---