Your message dated Wed, 21 Nov 2012 16:20:34 +0000
with message-id <[email protected]>
and subject line Bug#691377: Removed package(s) from unstable
has caused the Debian Bug report #44611,
regarding Mirror does not return a failure error code if server goes away
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
44611: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=44611
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: mirror
Version: 2.9-4

Yet another bug in mirror that I found with my debugging/informational patch
that was part of my first report.

Before:
----------------------------------------------------------------------------
Got contrib/libc6/SRPMS/le-1.5.2-1.src.rpm 308060 45
Failed to get contrib/libc6/SRPMS/klyx-0.9.9-2.src.rpm: remote server gone away
Failed to get file remote server gone away
Fatal error talking to site, skipping rest of transfers

Mirror redhat:redhat.ftp (pid 8311) ended with status: 0
----------------------------------------------------------------------------

After:
----------------------------------------------------------------------------
Got 6.0/i386/XFree86-I128-3.3.5-0.6.0.i386.rpm 944170 84
Failed to get 6.0/i386/XFree86-3.3.5-0.6.0.i386.rpm: remote server gone away
Failed to get file remote server gone away

Mirror redhat:redhat.updates (pid 16598) ended with status: 256
----------------------------------------------------------------------------


Patch for this bug:
----------------------------------------------------------------------------
--- mirror.debian       Tue Aug 24 19:18:23 1999
+++ mirror      Tue Sep  7 15:53:38 1999
@@ -1377,9 +1377,10 @@
                }
 
                &make_dirs();
-               &do_all_transfers();
-
-               $exit_status = $exit_ok;        # Everything went ok.
+               if (&do_all_transfers() != -1)
+               {
+                       $exit_status = $exit_ok;        # Everything went ok.
+               }
 
                if( $get_file ){
                        # I must have finished with the remote information
@@ -2685,7 +2686,7 @@
                        if( $ftp'fatalerror || $timeouts > $max_timeouts ){
                                &msg( $log, "Fatal error talking to site, 
skipping rest of transfers\n" );
                                &disconnect();
-                               return;
+                               return -1;
                        }
                        next;
                }
----------------------------------------------------------------------------


Full patch including my previous bug report on mirror (bug 44020):
----------------------------------------------------------------------------
--- mirror.debian       Tue Aug 24 19:18:23 1999
+++ mirror      Tue Sep  7 15:53:38 1999
@@ -731,7 +731,7 @@
                        $value{ 'get_patt' } = pop( @get_patt );
                        $value{ 'local_dir' } = '.';
                        $value{ 'remote_user' } = 'anonymous';
-                       $exit_status = &do_mirror();
+                       &do_mirror();
                }
                return;
        }
@@ -740,7 +740,7 @@
        if( $command_line{ 'interactive' } ){
                # No config file to read
                $value{ 'package' } = 'interactive';
-               $exit_status = &do_mirror();
+               &do_mirror();
                return;
        }
 
@@ -760,7 +760,7 @@
                # Is this a new package?
                if( $value{ 'package' } && $key eq 'package' ){
                        # mirror the existing package
-                       $exit_status = &do_mirror();
+                       &do_mirror();
                        
                        # reset
                        &set_defaults();
@@ -786,7 +786,7 @@
 
        # Mirror the last package in the file
        if( $value{ 'package' } ){
-               $exit_status = &do_mirror();
+               &do_mirror();
        }
 }
 
@@ -994,7 +994,7 @@
                $skip_till = $limit_packages = 0;
        }
        
-       local( $exit_status ) = $exit_fail_noconnect;  # Presume the worse.
+       $exit_status = $exit_fail_noconnect;  # Presume the worse.
        $timeouts = 0;
 
        # set things from the command line arguments
@@ -1377,9 +1377,10 @@
                }
 
                &make_dirs();
-               &do_all_transfers();
-
-               $exit_status = $exit_ok;        # Everything went ok.
+               if (&do_all_transfers() != -1)
+               {
+                       $exit_status = $exit_ok;        # Everything went ok.
+               }
 
                if( $get_file ){
                        # I must have finished with the remote information
@@ -2685,7 +2686,7 @@
                        if( $ftp'fatalerror || $timeouts > $max_timeouts ){
                                &msg( $log, "Fatal error talking to site, 
skipping rest of transfers\n" );
                                &disconnect();
-                               return;
+                               return -1;
                        }
                        next;
                }
@@ -3860,14 +3861,14 @@
 {
        $sigs ++;
        if( $sigs > $max_sigs ){
-               exit( 0 );
+               exit( 127 );
        }
 
         local( $sig ) = @_;
         local( $msg ) = "Caught a SIG$sig shutting down";
         local( $package, $filename, $line ) = caller;
         warn "$package:$filename:$line $msg";
-        exit( 0 );
+        exit( 127 );
 }
 
 sub trap_signals
----------------------------------------------------------------------------

Cheers,
Marc
-- 
Microsoft is to software what McDonalds is to gourmet cooking
 
Home page: http://marc.merlins.org/ (friendly to non IE browsers)
Finger [email protected] for PGP key and other contact information

--- End Message ---
--- Begin Message ---
Version: 2.9-62+rm

Dear submitter,

as the package mirror has just been removed from the Debian archive
unstable we hereby close the associated bug reports.  We are sorry
that we couldn't deal with your issue properly.

For details on the removal, please see http://bugs.debian.org/691377

The version of this package that was in Debian prior to this removal
can still be found using http://snapshot.debian.org/.

This message was generated automatically; if you believe that there is
a problem with it please contact the archive administrators by mailing
[email protected].

Debian distribution maintenance software
pp.
Ansgar Burchardt (the ftpmaster behind the curtain)

--- End Message ---

Reply via email to