Your message dated Thu, 20 Oct 2005 07:59:16 +1000
with message-id <[EMAIL PROTECTED]>
and subject line Bug#301279: swf-player now built by swfdec0.3
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 7 Mar 2005 13:31:04 +0000
>From [EMAIL PROTECTED] Mon Mar 07 05:31:04 2005
Return-path: <[EMAIL PROTECTED]>
Received: from c223012.adsl.hansenet.de (localhost.localdomain) [213.39.223.12]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1D8IK7-0004Qf-00; Mon, 07 Mar 2005 05:31:03 -0800
Received: from aj by localhost.localdomain with local (Exim 4.44)
id 1D8JGR-0001Sp-Ud; Mon, 07 Mar 2005 15:31:19 +0100
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
From: Andreas Jochens <[EMAIL PROTECTED]>
Subject: swfdec: FTBFS (amd64/gcc-4.0): pointer targets in passing argument 1
of 'art_rgb565_run_alpha' differ in signedness
Message-Id: <[EMAIL PROTECTED]>
Date: Mon, 07 Mar 2005 15:31:19 +0100
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-Spam-Level:
Package: swfdec
Severity: normal
Tags: patch
When building 'swfdec' on amd64 with gcc-4.0,
I get the following error:
x86_64-linux-gcc -DHAVE_CONFIG_H -I. -I. -I.. -I../libswfdec -Wall -Werror
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libart-2.0
-I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I./jpeg/ -g -O2 -MT
libswfdec_la-art.lo -MD -MP -MF .deps/libswfdec_la-art.Tpo -c art.c -fPIC
-DPIC -o .libs/libswfdec_la-art.o
cc1: warnings being treated as errors
art.c: In function 'art_rgb565_fillrect':
art.c:306: warning: pointer targets in passing argument 1 of
'art_rgb565_run_alpha' differ in signedness
art.c: In function 'art_rgb_fillrect':
art.c:321: warning: pointer targets in passing argument 1 of
'art_rgb_run_alpha' differ in signedness
make[4]: *** [libswfdec_la-art.lo] Error 1
make[4]: Leaving directory `/swfdec-0.2.2/libswfdec'
With the attached patch 'swfdec' can be compiled
on amd64 using gcc-4.0.
Regards
Andreas Jochens
diff -urN ../tmp-orig/swfdec-0.2.2/libswfdec/art.c ./libswfdec/art.c
--- ../tmp-orig/swfdec-0.2.2/libswfdec/art.c 2003-02-05 08:31:29.000000000
+0100
+++ ./libswfdec/art.c 2005-03-07 15:05:54.356415446 +0100
@@ -298,7 +298,7 @@
buffer += rect->x0 * 2;
for(i=rect->y0;i<rect->y1;i++){
- art_rgb565_run_alpha(buffer + i*stride,
+ art_rgb565_run_alpha((unsigned char*)buffer + i*stride,
SWF_COLOR_R(color),
SWF_COLOR_G(color),
SWF_COLOR_B(color),
@@ -313,7 +313,7 @@
buffer += rect->x0 * 3;
for(i=rect->y0;i<rect->y1;i++){
- art_rgb_run_alpha(buffer + i*stride,
+ art_rgb_run_alpha((unsigned char*)buffer + i*stride,
SWF_COLOR_R(color),
SWF_COLOR_G(color),
SWF_COLOR_B(color),
diff -urN ../tmp-orig/swfdec-0.2.2/libswfdec/get.c ./libswfdec/get.c
--- ../tmp-orig/swfdec-0.2.2/libswfdec/get.c 2003-02-03 07:52:32.000000000
+0100
+++ ./libswfdec/get.c 2005-03-07 15:06:21.767124673 +0100
@@ -91,9 +91,9 @@
char *get_string(bits_t *bits)
{
- char *s = g_strdup(bits->ptr);
+ char *s = g_strdup((char*)bits->ptr);
- bits->ptr += strlen(bits->ptr) + 1;
+ bits->ptr += strlen((char*)bits->ptr) + 1;
return s;
}
diff -urN ../tmp-orig/swfdec-0.2.2/libswfdec/render.c ./libswfdec/render.c
--- ../tmp-orig/swfdec-0.2.2/libswfdec/render.c 2003-02-22 04:49:30.000000000
+0100
+++ ./libswfdec/render.c 2005-03-07 15:06:56.023512559 +0100
@@ -207,7 +207,7 @@
s->drawrect.y0 = 0;
s->drawrect.y1 = 0;
if(!s->buffer){
- s->buffer = art_new (art_u8, s->stride*s->height);
+ s->buffer = (char*) art_new (art_u8, s->stride*s->height);
swf_invalidate_irect(s,&s->irect);
}
if(!s->tmp_scanline){
diff -urN ../tmp-orig/swfdec-0.2.2/libswfdec/swf.c ./libswfdec/swf.c
--- ../tmp-orig/swfdec-0.2.2/libswfdec/swf.c 2003-02-02 20:46:13.000000000
+0100
+++ ./libswfdec/swf.c 2005-03-07 15:10:49.876374642 +0100
@@ -10,27 +10,6 @@
int swf_inflate_init(SwfdecDecoder *s);
int swf_parse_header2(SwfdecDecoder *s);
-#ifdef __GNUC__
-#define weak_alias(name, aliasname) \
-extern __typeof (name) aliasname __attribute__ ((weak, alias (#name)))
-weak_alias(swfdec_decoder_new, swf_init);
-weak_alias(swfdec_decoder_addbits, swf_addbits);
-weak_alias(swfdec_decoder_parse, swf_parse);
-#else
-SwfdecDecoder *swf_init(void)
-{
- return swfdec_decoder_new();
-}
-int swf_addbits(SwfdecDecoder *s, unsigned char *bits, int len)
-{
- return swfdec_decoder_addbits(s,bits,len);
-}
-int swf_parse(SwfdecDecoder *s)
-{
- return swfdec_decoder_parse(s);
-}
-#endif
-
SwfdecDecoder *swfdec_decoder_new(void)
{
SwfdecDecoder *s;
@@ -66,7 +45,7 @@
return SWF_ERROR;
}
- s->parse.end = s->input_data + s->z->total_out;
+ s->parse.end = (unsigned char*) s->input_data + s->z->total_out;
}else{
if(s->parse.ptr){
offset = (void *)s->parse.ptr - (void *)s->input_data;
@@ -78,8 +57,8 @@
memcpy(s->input_data + s->input_data_len, bits, len);
s->input_data_len += len;
- s->parse.ptr = s->input_data + offset;
- s->parse.end = s->input_data + s->input_data_len;
+ s->parse.ptr = (unsigned char*) s->input_data + offset;
+ s->parse.end = (unsigned char*) s->input_data +
s->input_data_len;
}
return SWF_OK;
@@ -233,7 +212,7 @@
return SWF_ERROR;
}
- if(image) *image = s->buffer;
+ if(image) *image = (unsigned char*) s->buffer;
s->buffer = NULL;
return SWF_OK;
@@ -245,7 +224,7 @@
return SWF_ERROR;
}
- if(image) *image = s->buffer;
+ if(image) *image = (unsigned char*) s->buffer;
return SWF_OK;
}
@@ -382,15 +361,15 @@
z->zalloc = zalloc;
z->zfree = zfree;
- compressed_data = s->parse.ptr;
+ compressed_data = (char*) s->parse.ptr;
compressed_len = s->input_data_len -
((void *)s->parse.ptr - (void *)s->input_data);
- z->next_in = compressed_data;
+ z->next_in = (unsigned char*) compressed_data;
z->avail_in = compressed_len;
z->opaque = NULL;
data = malloc(s->length);
- z->next_out = data;
+ z->next_out = (unsigned char*) data;
z->avail_out = s->length;
ret = inflateInit(z);
@@ -404,7 +383,7 @@
s->input_data = data;
s->input_data_len = z->total_in;
- s->parse.ptr = data;
+ s->parse.ptr = (unsigned char*) data;
return SWF_OK;
}
@@ -616,3 +595,25 @@
va_end(args);
}
+#ifdef __GNUC__
+#define weak_alias(name, aliasname) \
+extern __typeof (name) aliasname __attribute__ ((weak, alias (#name)))
+weak_alias(swfdec_decoder_new, swf_init);
+weak_alias(swfdec_decoder_addbits, swf_addbits);
+weak_alias(swfdec_decoder_parse, swf_parse);
+#else
+SwfdecDecoder *swf_init(void)
+{
+ return swfdec_decoder_new();
+}
+int swf_addbits(SwfdecDecoder *s, unsigned char *bits, int len)
+{
+ return swfdec_decoder_addbits(s,bits,len);
+}
+int swf_parse(SwfdecDecoder *s)
+{
+ return swfdec_decoder_parse(s);
+}
+#endif
+
+
diff -urN ../tmp-orig/swfdec-0.2.2/libswfdec/swfdec_layer.c
./libswfdec/swfdec_layer.c
--- ../tmp-orig/swfdec-0.2.2/libswfdec/swfdec_layer.c 2003-02-02
20:46:13.000000000 +0100
+++ ./libswfdec/swfdec_layer.c 2005-03-07 15:11:21.605250383 +0100
@@ -200,9 +200,9 @@
cb_data.x0 = rect.x0;
cb_data.x1 = rect.x1;
if(cb_data.subpixel){
- cb_data.buf = s->buffer + rect.y0*s->stride +
(rect.x0/3)*s->bytespp;
+ cb_data.buf = (unsigned char*) s->buffer + rect.y0*s->stride +
(rect.x0/3)*s->bytespp;
}else{
- cb_data.buf = s->buffer + rect.y0*s->stride +
rect.x0*s->bytespp;
+ cb_data.buf = (unsigned char*) s->buffer + rect.y0*s->stride +
rect.x0*s->bytespp;
}
cb_data.color = layervec->color;
cb_data.rowstride = s->stride;
diff -urN ../tmp-orig/swfdec-0.2.2/pixbuf-loader/io-swf.c
./pixbuf-loader/io-swf.c
--- ../tmp-orig/swfdec-0.2.2/pixbuf-loader/io-swf.c 2003-02-22
04:49:30.000000000 +0100
+++ ./pixbuf-loader/io-swf.c 2005-03-07 15:21:36.440575822 +0100
@@ -341,8 +341,8 @@
fill_info (GdkPixbufFormat *info)
{
static GdkPixbufModulePattern signature[] = {
- { "FWS", NULL, 100 },
- { "CWS", NULL, 100 },
+ { (unsigned char*) "FWS", NULL, 100 },
+ { (unsigned char*) "CWS", NULL, 100 },
{ NULL, NULL, 0 }
};
static gchar *mime_types[] = {
diff -urN ../tmp-orig/swfdec-0.2.2/player/swf_play.c ./player/swf_play.c
--- ../tmp-orig/swfdec-0.2.2/player/swf_play.c 2005-03-07 15:21:42.012500337
+0100
+++ ./player/swf_play.c 2005-03-07 15:21:02.851059218 +0100
@@ -398,7 +398,7 @@
data = malloc(4096);
ret = g_io_channel_read_chars(chan, data, 4096, &bytes_read, &error);
if(ret==G_IO_STATUS_NORMAL){
- ret = swfdec_decoder_addbits(s,data,bytes_read);
+ ret = swfdec_decoder_addbits(s,(unsigned char*)data,bytes_read);
if(!render_idle_id)render_idle_id =
g_idle_add(render_idle,NULL);
}else if(ret==G_IO_STATUS_ERROR){
exit(1);
diff -urN ../tmp-orig/swfdec-0.2.2/test/display-shape.c ./test/display-shape.c
--- ../tmp-orig/swfdec-0.2.2/test/display-shape.c 2002-10-28
22:24:04.000000000 +0100
+++ ./test/display-shape.c 2005-03-07 15:20:33.772671883 +0100
@@ -28,7 +28,7 @@
gdk_draw_rgb_image (widget->window, widget->style->black_gc,
0, 0, s->width, s->height,
GDK_RGB_DITHER_NONE,
- s->buffer,
+ (unsigned char*) s->buffer,
s->width*3);
return FALSE;
}
@@ -85,7 +85,7 @@
read_swf_file(fn);
- build_widget (s->buffer);
+ build_widget ((unsigned char*) s->buffer);
/* gtk main loop */
@@ -146,7 +146,7 @@
drawing_area->style->black_gc,
0, 0, s->width, s->height,
GDK_RGB_DITHER_NONE,
- s->buffer,
+ (unsigned char*) s->buffer,
s->width*3);
}
---------------------------------------
Received: (at 298426-done) by bugs.debian.org; 19 Oct 2005 21:59:40 +0000
>From [EMAIL PROTECTED] Wed Oct 19 14:59:40 2005
Return-path: <[EMAIL PROTECTED]>
Received: from crumbs.ertius.org [67.18.176.136] (postfix)
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1ESLyG-0002Oh-00; Wed, 19 Oct 2005 14:59:40 -0700
Received: from ooder.vpn.ertius.org (ooder.vpn.ertius.org [10.10.0.1])
by crumbs.ertius.org (Postfix) with ESMTP id 0C96971517
for <[EMAIL PROTECTED]>; Thu, 20 Oct 2005 07:59:23 +1000 (EST)
Received: by ooder.vpn.ertius.org (Postfix, from userid 1000)
id 0ADFA77ED1; Thu, 20 Oct 2005 07:59:16 +1000 (EST)
Date: Thu, 20 Oct 2005 07:59:16 +1000
From: Rob Weir <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: Re: Bug#301279: swf-player now built by swfdec0.3
Message-ID: <[EMAIL PROTECTED]>
References: <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> <[EMAIL PROTECTED]> <[EMAIL
PROTECTED]>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
protocol="application/pgp-signature"; boundary="3uo+9/B/ebqu+fSQ"
Content-Disposition: inline
In-Reply-To: <[EMAIL PROTECTED]>
User-Agent: Mutt/1.5.9i
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-11.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER,
HAS_PACKAGE autolearn=ham version=2.60-bugs.debian.org_2005_01_02
--3uo+9/B/ebqu+fSQ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Package: swfdec0.3
Version: 0.3.4-3
On Wed, Oct 19, 2005 at 08:51:38AM -0700, David Schleef said
> On Wed, Oct 19, 2005 at 09:35:17PM +1000, Rob Weir wrote:
> > The swfdec source package appears to be gone from the pool, is there
> > anything else stopping your upload to fix #298426? If you're out of
> > time, would you like someone to NMU it?
>=20
> I don't think the bug is relevant to the current version.
You're right, sorry; swfdec0.3_0.3.4-3 builds on sid for me, too.
-rob
--=20
Not even if we rub the engine with cheetah blood?
--3uo+9/B/ebqu+fSQ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFDVsG0vQ+DhR5zt80RAr/xAJ40uncjkcl9g3xejy+bTddy+sEj6wCfZi9/
fc1+i+uY5+CEB+fSTr5Q22Y=
=mf2C
-----END PGP SIGNATURE-----
--3uo+9/B/ebqu+fSQ--
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
