Your message dated Tue, 05 Feb 2013 17:47:30 +0000
with message-id <[email protected]>
and subject line Bug#698348: fixed in b43-fwcutter 1:017-1~experimental1
has caused the Debian Bug report #698348,
regarding Allow unconditional installation without corresponding hardware
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
698348: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=698348
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: b43-fwcutter
Version: 1:015-14
Severity: normal
Tags: patch

Currently the installer scripts abort if no supported hardware is
detected and the package is left unconfigured. IMO this is quite bad as
no serious error prevents the firmware from being installed. There is
also no harm in installing firmware you don't strictly need. After all
by installing the package the user requested that the firmware should be
on his system and IMO it's not nice to second guess what the user really
want's to do. A (debconf) note telling the user that no supported hardware
was found would be nice and sufficient.

Beside this on live systems you actually want to have the firmware
installed all the time so that the live system also works when booted on a
system with a b43 or b43legacy wireless chipset. Forcing the user to do
the installation on a supported system is not nice.

In case you really want to keep the current checks, I attached a patch that
adds a debconf question to the b43-fwcutter package to choose if the
installer packages should install the firmware unconditionally or not.
The question is only asked at medium priority so it should not be shown
in default installs and nothing changes there. The main purpose of the
question is that you can preseed this on live systems. The same question
is used by all installer packages.

Thanks,
Gaudenz

-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (800, 'testing'), (700, 'unstable'), (50, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_CH.UTF-8, LC_CTYPE=de_CH.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

-- debconf information excluded
commit 82c1fcb3b9f719f24934d1661210c75067e065c5
Author: Gaudenz Steinlin <[email protected]>
Date:   Thu Jan 17 11:31:51 2013 +0100

    Debconf question to install firmware unconditional
    
    This enables the installer packages to install the firmware even if no
    corresponding hardware is present. This is usefull on live systems.

diff --git a/debian/b43-fwcutter.config b/debian/b43-fwcutter.config
new file mode 100644
index 0000000..5d3271d
--- /dev/null
+++ b/debian/b43-fwcutter.config
@@ -0,0 +1,10 @@
+#!/bin/sh
+
+set -e
+
+. /usr/share/debconf/confmodule
+
+db_input medium b43-fwcutter/install-unconditional || true
+db_go || true
+
+#DEBHELPER#
\ No newline at end of file
diff --git a/debian/b43-fwcutter.postinst b/debian/b43-fwcutter.postinst
new file mode 100644
index 0000000..fe570f9
--- /dev/null
+++ b/debian/b43-fwcutter.postinst
@@ -0,0 +1,9 @@
+#!/bin/sh
+
+set -e
+. /usr/share/debconf/confmodule
+
+# This script does not use the debconf template.
+# It's only used by the *-installer packages
+
+#DEBHELPER#
\ No newline at end of file
diff --git a/debian/b43-fwcutter.templates b/debian/b43-fwcutter.templates
new file mode 100644
index 0000000..e1b6f3f
--- /dev/null
+++ b/debian/b43-fwcutter.templates
@@ -0,0 +1,8 @@
+Template: b43-fwcutter/install-unconditional
+Type: boolean
+Default: false
+Description: Install firmware for hardware not present on this system?
+ Should the installer package download and install firmware for hardware
+ that is not currently present on the system. This is useful if you plan
+ to move this installation to different hardware or share the same installation
+ on different systems.
\ No newline at end of file
diff --git a/debian/firmware-b43-installer.postinst b/debian/firmware-b43-installer.postinst
index 468a486..409a673 100644
--- a/debian/firmware-b43-installer.postinst
+++ b/debian/firmware-b43-installer.postinst
@@ -2,6 +2,8 @@
 
 set -e
 
+. /usr/share/debconf/confmodule
+
 tmp=`mktemp -q -d`
 
 latest_firmware ()
@@ -61,6 +63,15 @@ if dpkg --compare-versions 2.6.25 gt `uname -r | cut -d- -f1`; then
 	exit 0
 fi
 
+# install firmware unconditional if the corresponding debconf value is true
+# this is usefull for live-systems or similar systems that should work on
+# changing hardware
+db_get b43-fwcutter/install-unconditional
+if [ "$RET" = "true" ] ; then
+    latest_firmware
+    exit 0
+fi
+
 
 # Fix for BCM4306/3 [14e4:4320] (rev 03)
 chip=`lspci -n | grep -o "14e4:4320 (rev 03)"` || true
diff --git a/debian/firmware-b43-lpphy-installer.postinst b/debian/firmware-b43-lpphy-installer.postinst
index 735b99d..c9b160a 100644
--- a/debian/firmware-b43-lpphy-installer.postinst
+++ b/debian/firmware-b43-lpphy-installer.postinst
@@ -2,6 +2,8 @@
 
 set -e
 
+. /usr/share/debconf/confmodule
+
 tmp=`mktemp -q -d`
 
 latest_firmware ()
@@ -60,6 +62,15 @@ if dpkg --compare-versions 2.6.32 gt `uname -r | cut -d- -f1`; then
 	exit 0
 fi
 
+# install firmware unconditional if the corresponding debconf value is true
+# this is usefull for live-systems or similar systems that should work on
+# changing hardware
+db_get b43-fwcutter/install-unconditional
+if [ "$RET" = "true" ] ; then
+    latest_firmware
+    exit 0
+fi
+
 # check chip
 supported=0
 pci=`lspci -n | grep -o "14e4:[1234567890abcdef]\+"` || true
diff --git a/debian/firmware-b43legacy-installer.postinst b/debian/firmware-b43legacy-installer.postinst
index 0ca5b29..4afbe6b 100644
--- a/debian/firmware-b43legacy-installer.postinst
+++ b/debian/firmware-b43legacy-installer.postinst
@@ -2,6 +2,8 @@
 
 set -e
 
+. /usr/share/debconf/confmodule
+
 tmp=`mktemp -q -d`
 
 latest_firmware ()
@@ -49,6 +51,15 @@ if [ "$(stat -c %d/%i /)" != "$(stat -Lc %d/%i /proc/1/root 2>/dev/null)" ];
     echo "No chroot environment found. Starting normal installation"
 fi
 
+# install firmware unconditional if the corresponding debconf value is true
+# this is usefull for live-systems or similar systems that should work on
+# changing hardware
+db_get b43-fwcutter/install-unconditional
+if [ "$RET" = "true" ] ; then
+    latest_firmware
+    exit 0
+fi
+
 # Fix for BCM4306 [14e4:4320] (rev 02)
 chip=`lspci -n | grep -o "14e4:4320 (rev 02)"` || true
 if [ "$chip" ] ; then

--- End Message ---
--- Begin Message ---
Source: b43-fwcutter
Source-Version: 1:017-1~experimental1

We believe that the bug you reported is fixed in the latest version of
b43-fwcutter, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Daniel Echeverry <[email protected]> (supplier of updated b43-fwcutter 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 04 Feb 2013 10:05:30 -0500
Source: b43-fwcutter
Binary: b43-fwcutter firmware-b43-installer firmware-b43legacy-installer
Architecture: source amd64 all
Version: 1:017-1~experimental1
Distribution: experimental
Urgency: low
Maintainer: Daniel Echeverry <[email protected]>
Changed-By: Daniel Echeverry <[email protected]>
Description: 
 b43-fwcutter - Utility for extracting Broadcom 43xx firmware
 firmware-b43-installer - Installer package for firmware for the b43 driver
 firmware-b43legacy-installer - Installer package for firmware for the 
b43legacy driver
Closes: 657837 682427 698348 698759
Changes: 
 b43-fwcutter (1:017-1~experimental1) experimental; urgency=low
 .
   * New upstream release.
   * New Maintainer. Closes: #698759
   * debian/control
     + Set myself as Maintainer.
     + Remove firmware-b43-lpphy-installer package. Closes: #657837
       + Firmware-b43-installer now supports BCM4312.
     + Update firmware-b43-installer description.
     + Change debhelper to 9 in B-D.
     + Bump Standard Versions 3.9.4.
     + Switch compat level 8 to 9.
     + Remove dm-upload field.
     + Remove conflict field.
     + Add po-debconf and debconf in B-D.
   * debian/rules
     + Add security Flags.
     + Use tiny rules.
   * Remove firmware-b43-lpphy-installer.* files.
   * Firmware-b43-installer now support BCM4331. Closes: #682427
   * Add debconf support. Thanks to Gaudenz. Closes: #698348
     + Allow installation without corresponding hardware.
     + Add es.po translation.
   * Update copyright file.
   * Remove debian/series file.
   * Update watch file.
   * Remove README.firmware-b43-lpphy-installer file.
Checksums-Sha1: 
 db5970ff0d0c722f57029061f506cbe2c3cedef4 2131 
b43-fwcutter_017-1~experimental1.dsc
 8f33940a14e078e86003e8128e93ede3c436fc8e 19139 b43-fwcutter_017.orig.tar.bz2
 7e5764f81eabe8e2d275fc785eb8b7e4113de2c7 10990 
b43-fwcutter_017-1~experimental1.debian.tar.gz
 d5f91a596c9762888494553b06d9dbaca3815cd0 25600 
b43-fwcutter_017-1~experimental1_amd64.deb
 676a99e95229a61d4c3a0b68b4cf78cfd1cfac3c 9930 
firmware-b43-installer_017-1~experimental1_all.deb
 2969a176b21c6dda9c1b80ab883c62df13946c12 9464 
firmware-b43legacy-installer_017-1~experimental1_all.deb
Checksums-Sha256: 
 7334068e68d6f798f589936b7ad61fb63b234ec8bc58c231cf6b47b09e17f909 2131 
b43-fwcutter_017-1~experimental1.dsc
 92b06548013136fb2bdac7da5de095a12872f27722cf996129ab24945de568b6 19139 
b43-fwcutter_017.orig.tar.bz2
 77f707a888afe66c6f5ebeb14e9e9b744427a509e55b9208e65975fa1263ebce 10990 
b43-fwcutter_017-1~experimental1.debian.tar.gz
 8432100ad6d3562592760cf71f7730a9d4c486b4a82e6083b77b376d247c6434 25600 
b43-fwcutter_017-1~experimental1_amd64.deb
 4274bb9a268ebb8aeb6b02523d88ceeb5ef8ea77270c9abaa6d6c3f4d0f429cf 9930 
firmware-b43-installer_017-1~experimental1_all.deb
 718582b78016103d1abf885d06da5a20d66e5b42a835175fc25fad86464766e2 9464 
firmware-b43legacy-installer_017-1~experimental1_all.deb
Files: 
 19f2e8f61117941fc0b057c2085d6f60 2131 contrib/utils optional 
b43-fwcutter_017-1~experimental1.dsc
 fe6a3cc765d8a8328dc09f7a6159bfb7 19139 contrib/utils optional 
b43-fwcutter_017.orig.tar.bz2
 eb0babb9a10740dee0bfa05b53317c67 10990 contrib/utils optional 
b43-fwcutter_017-1~experimental1.debian.tar.gz
 868546ad5f1195239f823b71efdf1836 25600 contrib/utils optional 
b43-fwcutter_017-1~experimental1_amd64.deb
 5dc252d44b33519ecd10e411c424f049 9930 contrib/kernel optional 
firmware-b43-installer_017-1~experimental1_all.deb
 5670b0fa5546f8dc12bf2fb095e9a2e5 9464 contrib/kernel optional 
firmware-b43legacy-installer_017-1~experimental1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCAAGBQJREUTMAAoJEHQmOzf1tfkTV2QP/2JLbIhtXVIov5o50bcgMEY0
lWkaCb8tUo1yZohpixRF1WgZlqX5pTdJYc96KRH2uJUoUESiQndaq3t9GTu7FMFY
jaXv6Ln8IBk/eoz8GO32Fh8KjQ0J8Xv44PVP0BVHCJvC1yF3h4niXH4a9T8z7Z6O
D6Kk7vMzxm4Xq7orCtus1JjMlztKuLe7e/S0uvf7XWSIG+IGl4Sk4to4mME+aBDm
Lotum0TVM9cVFmWdqCkoV1GZWFnlMo/hWuM/KvNPnDPGPkcEwMgApVaiqEQOYEgp
sCHmCF4yDNnD+pfm6ryhCREBj4/GtSwlAMaBgGBpS4/1VmZ/H3Z5mThioGKgwX6W
vDbSra+sI4j7wIFreWe+U8ZrsDaSje33HYmdxJUfGUaSK7BdOYjy6aRRS9xV/jBe
lnU/dZa8d26czfDNCk0kxwk8VCXuSXi05INmusMZykftY5gkh4Km+w70j7Z0MV0I
9fDX/dEeJKsVSTs40SN4AqADL3WFujMvUh6qwJQr+8lkxaAYDUHr3QwfoiHrcgke
nQ4AYj/TDXLTikqDdt2hzHUcdNxoR5ImgePAyI9gzPSE/lInPu1jfqyRySYYQ4n2
MzdJO4UicIml8S4xaK4jcRfwOUdt1hsEl+551IzdJ1Qb01zAtDgGvja1+oHiKsf9
8MEWFVDXNroIn9oCTt2b
=QF4E
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to