Your message dated Sun, 24 Feb 2013 16:45:09 +0200
with message-id <[email protected]>
and subject line #693039 triplane: errors from cppcheck
has caused the Debian Bug report #693039,
regarding triplane: errors from cppcheck
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
693039: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=693039
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: triplane
Version: 1.0.7-1
Severity: normal
There are some errors from cppcheck, it would probably be good to fix
them, especially the possible memory leak:
pabs@chianamo ~/tmp/triplane-1.0.7 $ cppcheck -j8 --quiet -f .
[src/io/dksfile.cpp:197]: (error) Used file that is not opened.
[src/io/dksfile.cpp:206]: (error) Used file that is not opened.
[src/io/dksfile.cpp:210]: (error) Used file that is not opened.
[src/io/dksfile.cpp:214]: (error) Used file that is not opened.
[src/io/dksfile.cpp:225]: (error) Used file that is not opened.
[src/io/dksfile.cpp:229]: (error) Used file that is not opened.
[src/tools/dat2c/dat2c.cpp:81]: (error) Memory leak: data
[src/tools/pgdview/pgdview.cpp:61]: (error) Buffer overrun possible for long
command line arguments.
[src/tools/pcx2pgd/pcx2pgd.cpp:302]: (error) Buffer overrun possible for long
command line arguments.
[src/tools/lvledit/lvledit.cpp:489]: (error) Buffer overrun possible for long
command line arguments.
--
bye,
pabs
http://wiki.debian.org/PaulWise
signature.asc
Description: This is a digitally signed message part
--- End Message ---
--- Begin Message ---
package triplane
tag 693039 wontfix
thanks
Hi,
thanks for the report. However, when I read through the errors I don't
think this is actually a bug.
> pabs@chianamo ~/tmp/triplane-1.0.7 $ cppcheck -j8 --quiet -f .
> [src/io/dksfile.cpp:197]: (error) Used file that is not opened.
> [src/io/dksfile.cpp:206]: (error) Used file that is not opened.
> [src/io/dksfile.cpp:210]: (error) Used file that is not opened.
> [src/io/dksfile.cpp:214]: (error) Used file that is not opened.
> [src/io/dksfile.cpp:225]: (error) Used file that is not opened.
> [src/io/dksfile.cpp:229]: (error) Used file that is not opened.
These seem to be false positives. The code uses a global variable to
hold the file handle and cppcheck is unable to see that the file is
guaranteed to be open.
> [src/tools/dat2c/dat2c.cpp:81]: (error) Memory leak: data
> [src/tools/pgdview/pgdview.cpp:61]: (error) Buffer overrun possible for long
> command line arguments.
> [src/tools/pcx2pgd/pcx2pgd.cpp:302]: (error) Buffer overrun possible for long
> command line arguments.
> [src/tools/lvledit/lvledit.cpp:489]: (error) Buffer overrun possible for long
> command line arguments.
These are sort of real but they are all in support code that is not
included in the binary package. These tools are only used during build
so memory leaks or security issues should not really matter. Given the
age of the codebase it is easier to rewrite the tools than to fix buffer
overflows :)
-Timo
--- End Message ---
