Your message dated Thu, 28 Mar 2013 20:48:04 +0000 with message-id <[email protected]> and subject line Bug#699372: fixed in nbd 1:3.2-3 has caused the Debian Bug report #699372, regarding nbd-client: Change init script and config file to better deal with NBD_NAME to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 699372: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=699372 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: nbd-client Version: 1:3.2-2 Severity: minor Tags: patch Dear Maintainer, Please consider making the following changes (in this form, or another) to the init script and config file. The config file change's purpose is mostly documenting the existence of NBD_NAME, and the fact NBD_PORT is optional with NBD_NAME. The init script change allows NBD_PORT to be unspecified (i.e. default), and complains if both NBD_PORT and NBD_NAME are missing. Without this change, the init script fails if NBD_PORT is empty or unset. Kind regards, Rogier. Change 1: nbd-client config file ------------------------------------------- --- /usr/share/nbd-client/nbd-client.cf.orig 2012-12-20 22:47:53.000000000 +0100 +++ /usr/share/nbd-client/nbd-client.cf 2013-01-30 14:36:05.000000000 +0100 @@ -18,16 +18,20 @@ # The host on which the nbd-server process is running NBD_HOST[0]= # -# The port on which this client needs to connect +# The port on which this client needs to connect. Optional for +# new-style exports (which use a single port, and export names). NBD_PORT[0]= # +# The name of the export. Required for new-style exports. +NBD_NAME[0]= +# # Any extra parameters you would want to specify NBD_EXTRA[0]= # The second networked block device could look like: # NBD_DEVICE[1]=/dev/nbd1 # NBD_TYPE[1]="f" # NBD_HOST[1]="localhost" -# NBD_PORT[1]="1235" +# NBD_NAME[1]="disk1" # # You can add as many as you want, but don't skip any number in the variable # names, or the initscript will fail. ------------------------------------------- Change 2: init script ------------------------------------------- --- /etc/init.d/nbd-client.orig 2013-01-30 10:37:35.000000000 +0100 +++ /etc/init.d/nbd-client 2013-01-30 14:21:12.000000000 +0100 @@ -105,17 +105,16 @@ then echo "${NBD_DEVICE[$i]} already connected, skipping..." else - if [ ! -z "${NBD_NAME[$i]}" ] + if [ -z "${NBD_NAME[$i]}" -a -z "${NBD_PORT[$i]}" ] then - name="-N ${NBD_NAME[$i]}" + echo "Either NBD_NAME or NBD_PORT must be specified for ${NBD_DEVICE[$i]}" else - name="" - fi - if $DAEMON "${NBD_HOST[$i]}" $name "${NBD_PORT[$i]}" "${NBD_DEVICE[$i]}" ${NBD_EXTRA[$i]} - then - echo "connected ${NBD_DEVICE[$i]}" - else - echo "could not connect ${NBD_DEVICE[$i]}" + if $DAEMON "${NBD_HOST[$i]}" ${NBD_NAME[$i]:+-N "${NBD_NAME[$i]}"} ${NBD_PORT[$i]: +"${NBD_PORT[$i]}"} "${NBD_DEVICE[$i]}" ${NBD_EXTRA[$i]} + then + echo "connected ${NBD_DEVICE[$i]}" + else + echo "could not connect ${NBD_DEVICE[$i]}" + fi fi fi i=$(($i + 1)) ------------------------------------------- -- System Information: Debian Release: wheezy/sid APT prefers testing APT policy: (500, 'testing') Architecture: i386 (x86_64) Kernel: Linux 3.2.0-4-amd64 (SMP w/2 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages nbd-client depends on: ii debconf [debconf-2.0] 1.5.46 ii initscripts 2.88dsf-34 ii libc6 2.13-37 nbd-client recommends no packages. nbd-client suggests no packages. -- debconf information excluded
--- End Message ---
--- Begin Message ---Source: nbd Source-Version: 1:3.2-3 We believe that the bug you reported is fixed in the latest version of nbd, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Wouter Verhelst <[email protected]> (supplier of updated nbd package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Wed, 06 Mar 2013 12:21:03 +0100 Source: nbd Binary: nbd-server nbd-client nbd-client-udeb Architecture: source amd64 Version: 1:3.2-3 Distribution: unstable Urgency: low Maintainer: Wouter Verhelst <[email protected]> Changed-By: Wouter Verhelst <[email protected]> Description: nbd-client - Network Block Device protocol - client nbd-client-udeb - Network Block Device protocol - client for Debian Installer (udeb) nbd-server - Network Block Device protocol - server Closes: 699372 Changes: nbd (1:3.2-3) unstable; urgency=low . * Fix handling of NBD_NAME variable in nbd-client initscript. Patch by Rogier <[email protected]>. Closes: #699372. * Steal stability fixes from git head: - fix for handling of zero-sized read request - fix for integer output format string - fix for 64-bit offset wrapover. - remove double cast which results in data loss * Change Standards-Version: to 3.9.4. The only change relevant to nbd is the /run transition, but as we were already compliant with that since 1:2.9.23-3, nothing relevant is left. Checksums-Sha1: 84540dda37e38ad2c25f74b264b8f57bb667d8dc 1892 nbd_3.2-3.dsc 69a129764fb0ada59165476c28ce12062ca8fadf 95661 nbd_3.2-3.diff.gz 9a050a8b6f89de1918ed3c807cbe8037dea13d05 74070 nbd-server_3.2-3_amd64.deb 3e41233acf2092e3cda71c08d16832103932ca63 63204 nbd-client_3.2-3_amd64.deb 8913068f360b53eabbaddb6fc50af035c3ea870b 8106 nbd-client-udeb_3.2-3_amd64.udeb Checksums-Sha256: bd22188ba894542c0fb99409bf9625a1c1228c6d9b8bdaed5cb643e086b9d0e4 1892 nbd_3.2-3.dsc d91b24037a94e4e91385ccb57bf41d9899cdcab6ae03104c734965caa599c31d 95661 nbd_3.2-3.diff.gz 20c99bc16943f7a9f20b50d586e04e9a60885eba85eb95cadd3a66c6615435e6 74070 nbd-server_3.2-3_amd64.deb 215422d5a3e050959ec1bc05da03f3daa4f0dbe872149078008247dec78dae2c 63204 nbd-client_3.2-3_amd64.deb 5246757a085bfe9c5e7942e7833f0ced2315ed9e6f08411030a6555d2b90abbe 8106 nbd-client-udeb_3.2-3_amd64.udeb Files: 52addc87fffe296eb8aa0e79a26efec0 1892 admin optional nbd_3.2-3.dsc b86e6491353a88112fdc9b10433946ab 95661 admin optional nbd_3.2-3.diff.gz e9c91e843078ac6a0100d60da78021e0 74070 admin optional nbd-server_3.2-3_amd64.deb 2242cd7c75faf174c98a2c4720431c5e 63204 admin optional nbd-client_3.2-3_amd64.deb a84cc8b7aadb8bbae31877eb3e48fb44 8106 debian-installer optional nbd-client-udeb_3.2-3_amd64.udeb Package-Type: udeb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBAgAGBQJRVJ6uAAoJEMKUD5Ub3wqdbIcQAPB4mMtP4Hsc+85xPfzedYp/ 5kHs9YNAmOgQ8Qqis1YluCwQ57zazAUnOa59ZaH7jHa6gFC/K89kQFJHgmadr4Vo 16piItfLQsKJxa/kd88j/GqFtYCUoAvhEYvksvm7rbwAFxzhUYVWJjMxZ2x3y/Ir qt5P3iD7xFkyDK/Vc/6+2v8+rZMwIfnrr40WplYqnhSebs8j5YON+KoadtIoZs8c FgHLWbbc5HSzFNQsvysEVGZHiVSopisLkJmrU9AaazrbyJkfu2+bBky+OKQ90xjm Zj1fpvxMVhMzFCsQ3uSnnSGcFdZEUfr2N5kwpuqW6nz7YEtGTtN2vbJfjk2oq6Kc XFEJiWZUbwghnZ1f5oh3BJX7XFu3zRNUU6RuzLe23g5EZDrotcATv/9sYtUC731m brEgeXiZP+cjJ1PaS8dEfv24ebIE9LEHZ6RqbL0Grm0jqsa23DuuzvWjjKFqIub2 lm1UxMyHAficQA04NtZ0JTbv4WmSSYJRPFQmuHNGKLBCR9q7Zrp4bwS4W9YpNE/u jJl5csId455o475vopbnBMdJrCWEvJFr8OqJj40jHAs6y5ulmn/YVjgyNB72SmcU 9zXXH4sc2YQmF1vjQIsjYk+db5KpnVU11Rj2vlV5yhacuweEeqyZdekKj8OvWeMW Cq7Vstvg+HCkYBRZapzs =5f9q -----END PGP SIGNATURE-----
--- End Message ---
