Your message dated Sun, 31 Mar 2013 19:02:55 +0000
with message-id <[email protected]>
and subject line Bug#699093: fixed in vcsh 1.1-1
has caused the Debian Bug report #699093,
regarding vcsh: insufficient argument quoting
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
699093: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=699093
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: vcsh
Version: 1.0-1
Severity: normal

Dear Maintainer,

vcsh does not appear to quote arguments sufficiently when passing them on to
git. e.g. whem commiting using the -m option:

$ vcsh bash commit -a -m "This is a test"
fatal: Paths with -a does not make sense.
$ vcsh bash commit -m "This is a test" .bashrc 
error: pathspec 'is' did not match any file(s) known to git.
error: pathspec 'a' did not match any file(s) known to git.
error: pathspec 'test' did not match any file(s) known to git.

In both cases the argument to -m has ended up just "This" while "is", "a" and
"test" are separate arguments.

After a little light hacking the attached patch works for me, not sure it is
the best approach though.

Ian.

-- System Information:
Debian Release: wheezy/sid
  APT prefers testing
  APT policy: (990, 'testing'), (500, 'stable-updates'), (500, 'unstable'), 
(500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages vcsh depends on:
ii  git  1:1.7.10.4-1+wheezy1

Versions of packages vcsh recommends:
ii  mr                           1.12
ii  openssh-client [ssh-client]  1:6.0p1-3

vcsh suggests no packages.

-- no debconf information
--- /usr/bin/vcsh	2012-06-30 01:10:40.000000000 +0100
+++ ./vcsh	2013-01-27 13:10:48.000000000 +0000
@@ -169,7 +169,7 @@
 run() {
 	hook pre-run
 	use
-	$VCSH_EXTERNAL_COMMAND
+	"$@"
 	hook post-run
 }
 
@@ -259,7 +259,7 @@
 	export VCSH_REPO_NAME="$2"
 	export GIT_DIR="$VCSH_REPO_D/$VCSH_REPO_NAME.git"
 	[ "$VCSH_COMMAND" = 'rename' ]         && export GIT_DIR_NEW="$VCSH_REPO_D/$3.git"
-	[ "$VCSH_COMMAND" = 'run' ] && shift 2 && export VCSH_EXTERNAL_COMMAND="$*"
+	[ "$VCSH_COMMAND" = 'run' ] && shift 2
 	[ "$VCSH_COMMAND" = 'write-gitignore' ]
 elif [ "$1" = 'list' ] ||
      [ "$1" = 'list-tracked' ]; then
@@ -270,7 +270,7 @@
 	export GIT_DIR="$VCSH_REPO_D/$VCSH_REPO_NAME.git"
 	[ -d $GIT_DIR ] || { help; exit 1; }
 	shift 1
-	export VCSH_EXTERNAL_COMMAND="git $*"
+	set -- "git" "$@"
 elif [ -n "$1" ]; then
 	export VCSH_COMMAND='enter'
 	export VCSH_REPO_NAME="$1"
@@ -304,6 +304,6 @@
 verbose "$VCSH_COMMAND begin"
 export VCSH_COMMAND=$(echo $VCSH_COMMAND | sed 's/-/_/g')
 hook pre-command
-$VCSH_COMMAND
+$VCSH_COMMAND "$@"
 hook post-command
 verbose "$VCSH_COMMAND end, exiting"

--- End Message ---
--- Begin Message ---
Source: vcsh
Source-Version: 1.1-1

We believe that the bug you reported is fixed in the latest version of
vcsh, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Richard Hartmann <[email protected]> (supplier of updated vcsh 
package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Sun, 31 Mar 2013 20:46:10 +0200
Source: vcsh
Binary: vcsh
Architecture: source all
Version: 1.1-1
Distribution: experimental
Urgency: low
Maintainer: Richard Hartmann <[email protected]>
Changed-By: Richard Hartmann <[email protected]>
Description: 
 vcsh       - manage config files in $HOME via fake bare git repositories
Closes: 699093
Changes: 
 vcsh (1.1-1) experimental; urgency=low
 .
   * New upstream release
     + Documentation fixes
     + Use rm -f when removing a git repo
     + Fix quoting bug Closes: #699093
Checksums-Sha1: 
 18b474048cc8db95438942c7b66fa552f1371104 1796 vcsh_1.1-1.dsc
 03fb302a1ff75ca6b13fbda0513cc0ffc3825fb6 19884 vcsh_1.1.orig.tar.gz
 086e17b40f9e7758bc7f640e28eb8e761aa7e3ef 2171 vcsh_1.1-1.debian.tar.gz
 23dbd7e2b40b9a99bd509ba41c313ee7efb6e095 16292 vcsh_1.1-1_all.deb
Checksums-Sha256: 
 4ff05eba7dfc6478e6d101f84a7afd5cb0f022306daacec37a244a9d30450764 1796 
vcsh_1.1-1.dsc
 56d387142a265387209d7b0abad26bad4abf8712f468c931bea39c577d8303f7 19884 
vcsh_1.1.orig.tar.gz
 e434bc56f9805f5ea3dc8e2d12c2d8dcd2a21769559534d879d00a6155abb063 2171 
vcsh_1.1-1.debian.tar.gz
 7baad10c5f4165beb5d48a9165d3e67df8397a3cdd540fcaa1d025d5daae016a 16292 
vcsh_1.1-1_all.deb
Files: 
 0faf8ae30265ffc78312c20ff67f30a4 1796 misc optional vcsh_1.1-1.dsc
 7cafad4d0c4ebe4ea0f490d9614ba0c0 19884 misc optional vcsh_1.1.orig.tar.gz
 89d80d15ad874004145a22704ca5dc51 2171 misc optional vcsh_1.1-1.debian.tar.gz
 7da9d28cb7457d4e966ac126901795cd 16292 misc optional vcsh_1.1-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBCgAGBQJRWIV+AAoJEGkGSwGVIG3THU8QAMUtGm6AD6fOdn+wWH3H/5Dw
XOAjc65fOm91k5u/LMEr8AfQV33lX6nJr5FAIpP7vKbLFTErvQSe7pumTgRdC93l
xUABHGZa63dEoP76UPbt/QWGQeOodVKoGMBnjM0cM8KgtGvZ3KHaJR/ICMKj/TRr
xQI4OiL4nOVHdpicdSymyEefY4aRPGZl+qpCXzlPbp6XMQibWFZOlq+K4xUzwuvp
9LPKchgl/xJ9LnYMH7zxIX8emwshnZtMAxaSRXccaG8c/PYjL6jz+Kzh+JCGT+QH
qnihR4Xhy+MYNAXjpwrF57qshUjjY/G+/DDbfsZV3rPftnryjc3+eNigxkqUBFZx
p8E0kBtbZZrT9cKgsWKRxzan76hPMifY5O3tpClJkkrlxalcrYg5rwHaUQ9CZ0Xt
wVn+0zexbegYFlqWtRYVKKcPFNdKCyvKfQ+iMKuHky0Sb/KrZfrKF7D2bhcouGAs
2kSRK1T4ooRB8lPWZEzpVFckbuh/ADYezrQ0P2cRfkhVx7h1XflV5wE645e7yPHC
5Ng7112RNYcwq9r49nnZO4HO7FYw0Fx6Watc6Fs8ElCmCduztM86d8gnmbrww6N7
XS5Wv0e5hWaRbALt571YLwCoj0qsZgCwPAHzW0E5DjUjNNh2rQvIZ204vQ/UigQE
xZaNZGluY1ntDVur9/1G
=u5D9
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to