Your message dated Fri, 5 Apr 2013 07:38:15 +0200
with message-id <[email protected]>
and subject line Re: Bug#704712: git-buildpackage: fix --git-sign-tag option
has caused the Debian Bug report #704712,
regarding git-buildpackage: fix --git-sign-tag option
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
704712: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=704712
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: git-buildpackage
Version: 0.6.0~git20130329
Tags: patch
Hi,
I found --git-sign-tag doesn't work properly, and create a
patch for it. Please review and apply it, thanks.
--
Regards,
Hideki Yamane henrich @ debian.or.jp/org
http://wiki.debian.org/HidekiYamane
>From 019ce12f698191ddd622539449b1e688b42c8d96 Mon Sep 17 00:00:00 2001
From: Hideki Yamane <[email protected]>
Date: Fri, 5 Apr 2013 06:34:33 +0900
Subject: [PATCH] fix --git-sign-tags option work
---
gbp/scripts/buildpackage.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gbp/scripts/buildpackage.py b/gbp/scripts/buildpackage.py
index bdb3177..f8016ed 100755
--- a/gbp/scripts/buildpackage.py
+++ b/gbp/scripts/buildpackage.py
@@ -554,7 +554,7 @@ def main(argv):
Command(options.postbuild, shell=True,
extra_env={'GBP_CHANGES_FILE': changes,
'GBP_BUILD_DIR': build_dir})()
- if options.tag or options.tag_only:
+ if options.tag or options.tag_only or options.sign_tags:
gbp.log.info("Tagging %s" % cp.version)
tag = repo.version_to_tag(options.debian_tag, cp.version)
if options.retag and repo.has_tag(tag):
--
1.7.10.4
--- End Message ---
--- Begin Message ---
On Fri, Apr 05, 2013 at 06:38:17AM +0900, Hideki Yamane wrote:
> Package: git-buildpackage
> Version: 0.6.0~git20130329
> Tags: patch
>
> Hi,
>
> I found --git-sign-tag doesn't work properly, and create a
> patch for it. Please review and apply it, thanks.
>
>
> --
> Regards,
>
> Hideki Yamane henrich @ debian.or.jp/org
> http://wiki.debian.org/HidekiYamane
> From 019ce12f698191ddd622539449b1e688b42c8d96 Mon Sep 17 00:00:00 2001
> From: Hideki Yamane <[email protected]>
> Date: Fri, 5 Apr 2013 06:34:33 +0900
> Subject: [PATCH] fix --git-sign-tags option work
>
> ---
> gbp/scripts/buildpackage.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gbp/scripts/buildpackage.py b/gbp/scripts/buildpackage.py
> index bdb3177..f8016ed 100755
> --- a/gbp/scripts/buildpackage.py
> +++ b/gbp/scripts/buildpackage.py
> @@ -554,7 +554,7 @@ def main(argv):
> Command(options.postbuild, shell=True,
> extra_env={'GBP_CHANGES_FILE': changes,
> 'GBP_BUILD_DIR': build_dir})()
> - if options.tag or options.tag_only:
> + if options.tag or options.tag_only or options.sign_tags:
Sign_tags means: sign a tag if it's created not create a signed tag so
the code is already correct as is. From the manpage:
--git-[no-]sign-tags
GPG sign all created tags
Cheers,
-- Guido
> gbp.log.info("Tagging %s" % cp.version)
> tag = repo.version_to_tag(options.debian_tag, cp.version)
> if options.retag and repo.has_tag(tag):
> --
> 1.7.10.4
>
--- End Message ---
