Your message dated Fri, 26 Apr 2013 09:47:37 +0000
with message-id <[email protected]>
and subject line Bug#706170: fixed in xosview 1.14-2
has caused the Debian Bug report #706170,
regarding xosview: platform detection improvement/fix in debian/rules
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
706170: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=706170
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: xosview
Version: 1.14-1
Severity: wishlist
Tags: patch
Hi,
the changes in the experimental version still make xosview compiled as
"linux" even in non-Linux OSes, and never uses the right platform
string on kFreeBSD.
The attached patch factorizes the detection of the platform string
to use when invoking make,
- making it use the right one on kFreeBSD (which though won't compile
yet, and that will need proper fixes)
- bailing out when the OS is not recognized, and it is easy (just add
the two proper lines in that if chain, e.g. starting from the
kfreebsd ones) to add cases for new OSes
Thanks,
--
Pino
--- a/debian/rules
+++ b/debian/rules
@@ -9,23 +9,20 @@
CXX=g++
DEB_BUILD_ARCH_OS ?=$(shell dpkg-architecture -qDEB_BUILD_ARCH_OS)
+ifeq ($(DEB_BUILD_ARCH_OS),linux)
+ PLATFORM=linux
+else ifeq ($(DEB_BUILD_ARCH_OS),kfreebsd)
+ PLATFORM=bsd
+else
+ $(error Missing implementation for $(DEB_BUILD_ARCH_OS))
+endif
build: build-arch build-indep
build-arch: build-stamp
build-indep: build-stamp
build-stamp:
dh_testdir
-
-#experimental kfreebsd-* support
-ifeq ($(DEB_BUILD_ARCH_OS),kfreebsd-i386)
- $(MAKE) PLATFORM=bsd
-else
-ifeq ($(DEB_BUILD_ARCH_OS),kfreebsd-amd64)
- $(MAKE) PLATFORM=bsd
-endif
-endif
-
- $(MAKE) PLATFORM=linux
+ $(MAKE) PLATFORM=$(PLATFORM)
touch $@
clean:
--- End Message ---
--- Begin Message ---
Source: xosview
Source-Version: 1.14-2
We believe that the bug you reported is fixed in the latest version of
xosview, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Kartik Mistry <[email protected]> (supplier of updated xosview package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Fri, 26 Apr 2013 13:46:38 +0530
Source: xosview
Binary: xosview
Architecture: source amd64
Version: 1.14-2
Distribution: experimental
Urgency: low
Maintainer: Kartik Mistry <[email protected]>
Changed-By: Kartik Mistry <[email protected]>
Description:
xosview - X based system monitor
Closes: 706170
Changes:
xosview (1.14-2) experimental; urgency=low
.
* debian/rules:
+ Platform detection improvement, Thanks to Pino Toscano <[email protected]>
(Closes: #706170).
* debian/control:
+ Added libkvm-dev as build-depends for kfreebsd-*
Checksums-Sha1:
0fe47198bd7188f9d1e15dc1ad1c31cfabdcffe6 1302 xosview_1.14-2.dsc
f3ca774af503d9862c7af1a2d28593448cb8c05a 14894 xosview_1.14-2.debian.tar.gz
0bc5643cbce759c1808114a5cd0dfc53bcfb5538 139326 xosview_1.14-2_amd64.deb
Checksums-Sha256:
b712b71a93a16f3cb3d8dac081e1cde3b4c3b43f195374a1df6653ad714b1225 1302
xosview_1.14-2.dsc
0d11d2794168211cd96a90ddc62d5f5385743a5fa8d0741d4a5141b31860d449 14894
xosview_1.14-2.debian.tar.gz
d465121e6b5f68cd148c9295dbaebac2c3ddc3daad966fcab52c5fde21e28628 139326
xosview_1.14-2_amd64.deb
Files:
34ce6bdcaacdb4f48fd8724b66fb2dfc 1302 utils optional xosview_1.14-2.dsc
8acffb8a2b2b5a4e94e897ad1193885b 14894 utils optional
xosview_1.14-2.debian.tar.gz
42c6ad11d3c90608dab2630ed001ccf2 139326 utils optional xosview_1.14-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iEYEARECAAYFAlF6Oa0ACgkQoRg/jtECjI3rIwCeMiFXQqBAZ6yNx3o8O+zALHUE
WvAAnAskX5WlJ7gyWvLOyjoNK6iJtEdg
=L15Z
-----END PGP SIGNATURE-----
--- End Message ---
