Your message dated Mon, 29 Apr 2013 22:47:37 +0000
with message-id <[email protected]>
and subject line Bug#653362: fixed in mp4h 1.3.1-7
has caused the Debian Bug report #653362,
regarding mp4h: FTBFS on hurd-i386
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
653362: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=653362
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: mp4h
Version: 1.3.1-6
Severity: important
Tags: patch
User: [email protected]
Usertags: hurd
Hi,
mp4h FTBFS on GNU/Hurd, see
https://buildd.debian.org/status/fetch.php?pkg=mp4h&arch=hurd-i386&ver=1.3.1-6&stamp=1324166240
This is due to that MATPATHLEN is set to 256 in builtin.h which is far
too short for realpath usage. On GNU/HUrd PATH_MAX is not defined, while
_POSIX_PATH_MAX is and is set to 256 an that constant is used.
During the build of documentation mp4h.html from mp4h.mp4h the end of
the environment vector __envron is overwritten/truncated, removing the
NULL termination of that vector and causing a segfault. The attached
patch fixes these problems by dynamically allocating the resolved
pathname using the canonicalize_file_name() function if available. The
availability is checked in configure.ac. The patch should be placed last
in the series to apply properly.
Thanks!
diff -ur mp4h-1.3.1/configure.ac mp4h-1.3.1.modified/configure.ac
--- mp4h-1.3.1/configure.ac 2011-12-27 12:09:55.000000000 +0100
+++ mp4h-1.3.1.modified/configure.ac 2011-12-27 12:41:20.000000000 +0100
@@ -38,7 +38,7 @@
AC_CHECK_HEADERS([limits.h locale.h memory.h stdarg.h string.h unistd.h time.h])
AC_CHECK_HEADERS([pwd.h grp.h dirent.h sys/param.h sys/stat.h sys/types.h sys/times.h])
-AC_CHECK_FUNCS([mkstemp strchr strerror tmpfile getpwuid getgrgid bcopy memmove])
+AC_CHECK_FUNCS([mkstemp strchr strerror tmpfile getpwuid getgrgid bcopy memmove canonicalize_file_name])
AC_FUNC_ALLOCA
AC_FUNC_VPRINTF
AC_REPLACE_FUNCS(strtol obstack xmalloc xstrdup)
diff -ur mp4h-1.3.1/src/builtin.c mp4h-1.3.1.modified/src/builtin.c
--- mp4h-1.3.1/src/builtin.c 2011-12-27 12:09:56.000000000 +0100
+++ mp4h-1.3.1.modified/src/builtin.c 2011-12-27 12:41:23.000000000 +0100
@@ -1468,7 +1468,11 @@
mp4h_bp_real_path (MP4H_BUILTIN_ARGS)
{
const char *pathname;
+#ifdef HAVE_CANONICALIZE_FILE_NAME
+ char *resolvedname = NULL;
+#else
char resolvedname[MAXPATHLEN];
+#endif
CHECK_SAFETY_LEVEL(1);
@@ -1478,12 +1482,22 @@
_("Warning:%s:%d: In <%s>, required attribute `%s' is not specified"),
CURRENT_FILE_LINE, ARG (0), "pathname"));
else
+#ifdef HAVE_CANONICALIZE_FILE_NAME
+ if ((resolvedname = canonicalize_file_name(pathname)) == NULL)
+#else
if (!realpath(pathname, resolvedname))
+#endif
MP4HERROR ((warning_status, errno,
_("Error:%s:%d: Cannot form real path for `%s'"),
CURRENT_FILE_LINE, pathname));
else
+ {
obstack_grow(obs, resolvedname, strlen(resolvedname));
+#ifdef HAVE_CANONICALIZE_FILE_NAME
+ free(resolvedname);
+#endif
+
+ }
}
#endif /* HAVE_FILE_FUNCS */
--- End Message ---
--- Begin Message ---
Source: mp4h
Source-Version: 1.3.1-7
We believe that the bug you reported is fixed in the latest version of
mp4h, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Axel Beckert <[email protected]> (supplier of updated mp4h package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Tue, 30 Apr 2013 00:23:40 +0200
Source: mp4h
Binary: mp4h
Architecture: source amd64
Version: 1.3.1-7
Distribution: experimental
Urgency: low
Maintainer: Debian WML Packaging Team
<[email protected]>
Changed-By: Axel Beckert <[email protected]>
Description:
mp4h - Macro processor for HTML documents
Closes: 653362
Changes:
mp4h (1.3.1-7) experimental; urgency=low
.
* Fix FTBFS on GNU/Hurd (Closes: #653362) Thanks to Svante Signell for
investigation and the patch!
* Fix FTBFS with -Werror=format-security.
* Remove manual DEB_BUILD_OPTIONS check around dh_strip as dh_strip does
that itself.
* Bump Standards-Version to 3.9.4 (no changes)
* Bump debhelper compatibility to 9
+ Add Pre-Depends on ${misc:Pre-Depends)
* Switch to source format "3.0 (quilt)"
+ Drop build-dependency on quilt
+ Drop debian/README.source
+ Remove quilt traces from debian/rules
* Switch from autotools-dev to dh-autoreconf
+ Update build-dependencies accordingly
* Revamp debian/rules:
+ Use dh_auto_{configure,build,install}
+ Support multiarch lib directories
+ Make clean target more robust
+ Use debian/docs and don't list upstream changelog explicitly
+ Finally switch normalized debian/rules to minimal dh style
* Build against system copy of PCRE3
+ Add build-dependency on libpcre3-dev
+ No more install README.pcre into /usr/share/doc/mp4h
* Enable test suite at build time
* Apply wrap-and-sort
* Fix the following lintian warnings:
+ vcs-field-not-canonical
+ spelling-error-in-manpage (fix added to lintian-cleanup-tg.diff)
Checksums-Sha1:
a22796439e363b1fef3a68376dec858c2f25388c 1325 mp4h_1.3.1-7.dsc
e34d2ad52fdd283e26090045f3457ff6ca9eb9da 13690 mp4h_1.3.1-7.debian.tar.gz
859055b8e83a8a8cd23a91833261c2dbaec5349f 211192 mp4h_1.3.1-7_amd64.deb
Checksums-Sha256:
2199ae4fa39ad0a2c0d2bec4ae43c8d8ca034b95810d2e2def8c48197d52f0f9 1325
mp4h_1.3.1-7.dsc
ed339889bc03e7d206c9b3c487976dcafbe6e93f41cccc6f77f11cf67d43535a 13690
mp4h_1.3.1-7.debian.tar.gz
36f53b2d0e2ea1a607e991c3e08b6a6d1fef147778039ae9a390071cb2029d19 211192
mp4h_1.3.1-7_amd64.deb
Files:
42bf042cd5b31d09c10c0368783fa7df 1325 web optional mp4h_1.3.1-7.dsc
b396da7fd8b71ca6a43d84968be1bfc1 13690 web optional mp4h_1.3.1-7.debian.tar.gz
5d34fb2cee14116d89bf7ba148c38152 211192 web optional mp4h_1.3.1-7_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iEYEARECAAYFAlF+9LUACgkQwJ4diZWTDt7w+gCeP+TRvCouKobglkIJNopTaSIO
X1YAnAxWKwGxIu9Gf0YPZx1Ixsp6J0jd
=HxAc
-----END PGP SIGNATURE-----
--- End Message ---
