Your message dated Thu, 16 May 2013 05:03:22 +0000
with message-id <[email protected]>
and subject line Bug#707875: fixed in firehol 1.296-3
has caused the Debian Bug report #707875,
regarding firehol: Starting Firewall: firehol/sbin/firehol: line 5783: [: 
8-1-amd64: integer expression expected
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
707875: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=707875
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: firehol
Version: 1.296-2
Severity: normal
Tags: patch

Attached patch solves the bug in subject in a more elegant way.
Still, there are more bugs :(  Running the script using 'set -e' (errexit)
reveals more.

-- System Information:
Debian Release: jessie/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 3.8-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Shell: /bin/sh linked to /bin/dash

Versions of packages firehol depends on:
ii  bash      4.2+dfsg-1
ii  iproute   20120521-3+b4
ii  iptables  1.4.18-1
ii  lsb-base  4.1+Debian9

Versions of packages firehol recommends:
ii  aggregate  1.6-7
ii  curl       7.30.0-2
ii  kmod       9-3
ii  wget       1.14-1

Versions of packages firehol suggests:
ii  ulogd  1.24-3.3

-- Configuration Files:
/etc/default/firehol changed [not included]
/etc/firehol/firehol.conf changed [not included]

-- no debconf information

-- debsums errors found:
debsums: changed file /sbin/firehol (from firehol package)


Cheers,

-- 
Cristian
--- /sbin/firehol-1.296-2	2013-05-11 21:20:20.340860813 +0200
+++ /sbin/firehol	2013-05-11 21:23:34.497319586 +0200
@@ -5773,8 +5773,16 @@
 	exit 0
 fi
 
-KERNELMAJ=`${UNAME_CMD} -r | ${SED_CMD}                   -e 's,\..*,,'`
-KERNELMIN=`${UNAME_CMD} -r | ${SED_CMD} -e 's,[^\.]*\.,,' -e 's,\..*,,'`
+kernel_maj_min() {
+	local kmaj kmin IFS=.-
+
+	kmaj=$1
+	kmin=$2
+
+	set -- $(uname -r)
+	eval $kmaj=\$1 $kmin=\$2
+}
+kernel_maj_min KERNELMAJ KERNELMIN
 
 if [ "$KERNELMAJ" -lt 2 ] ; then
 	echo >&2 "FireHOL requires a kernel version higher than 2.3."

--- End Message ---
--- Begin Message ---
Source: firehol
Source-Version: 1.296-3

We believe that the bug you reported is fixed in the latest version of
firehol, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Jerome Benoit <[email protected]> (supplier of updated firehol package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Wed, 15 May 2013 13:24:41 +0000
Source: firehol
Binary: firehol
Architecture: source all
Version: 1.296-3
Distribution: unstable
Urgency: low
Maintainer: Jerome Benoit <[email protected]>
Changed-By: Jerome Benoit <[email protected]>
Description: 
 firehol    - easy to use but powerful iptables stateful firewall
Closes: 707875
Changes: 
 firehol (1.296-3) unstable; urgency=low
 .
   * Fix kernel version detection so that it is more flexible and less error
     prone (Closes: #707875), thanks to Cristian Ionescu-Idbohrn
     <[email protected]>.
Checksums-Sha1: 
 5d5cecfbeae5da7be882c19aada579974646d1b2 1817 firehol_1.296-3.dsc
 bc9c399ce6cb093e202848f05b50c0c789d5cd3e 14444 firehol_1.296-3.debian.tar.xz
 6f00558414608e978cdf5e84b1a7962e452f9301 183150 firehol_1.296-3_all.deb
Checksums-Sha256: 
 acec7a5402784309aa3aeccc7de56fef8907fda21c3af9fb27c8814612e8a760 1817 
firehol_1.296-3.dsc
 83cb9a86d650eecae82174218b6eb71cb6fcef2e82bd4eefec080ad716d362e4 14444 
firehol_1.296-3.debian.tar.xz
 78514884719a3811dc4bda20f24e1dc91f547e340498a65d8f0c4ae181d00a06 183150 
firehol_1.296-3_all.deb
Files: 
 a78b704701b535c67b9e4251f007f546 1817 net optional firehol_1.296-3.dsc
 8470070dfe2f1907d939179de19bcbd4 14444 net optional 
firehol_1.296-3.debian.tar.xz
 0ab9ac7c64d107c2d8d928fa2c17c31c 183150 net optional firehol_1.296-3_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQIcBAEBAgAGBQJRlGZ8AAoJECHSBYmXSz6W1dsQAMF973Q98xwbz0Fb0lid4+Ja
ErHsIPVsNGVmuSqzTtwVe+eh5xRHu7gYu3/69WJqa7WoEQZ8R1ozlVa6UXnCl8rS
+FJNJh46sWSspl+Ys9XMs4ixasq+VLTdC4aDEIponTqROTd1n4JhTGEzX5jfpQJe
c+sB1FH5Vvpc49amiG8Ff8PewJ3RTwq4cSjDTGDbgLxc6Rl3hXwidWaCSmW42hlZ
mvwhhIBt1vLHCE52LON+3NOnVKCTYYOO2KrBwn1BPWSFt06eC4xoNIEFaAy+ZVxs
YfxXfzk3u7fGVCKy6l0ZXePuq+p6hZAa44zeJhD9/sowD72O/ZDvVw3WAG5E4y1I
4tJvlQ/IAshKR9OmAMnjIK21yiRUjctDrIeKI7fwfmV1arMdcvwc+TfMKe1T4dog
hoF3uiJSVgXurvJXhDrLTpl7/PJn4psKbOGqWRx71k7FsjGcrQR6Y0TSmcQT3VIR
it8/sC+WWzlby9EuKeyd2bAu8nlPm+bPnkTvAadFWIvG+K27uQPbtTgmeK36tWzZ
d9Z5c/Tn+7td3YYnhwSNXgJgSAzCzAmazbPtk4PXiLnF7ULVn3h7bf1tNGdIH/h/
dprmS7WigHvwBhCA+PheRkzvvtb0upoEMLF3ibUDRmxPZSUkpWVEUbk70OvqBZwK
R37L7hK/f5msSXvBDgl+
=65uV
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to