Your message dated Sun, 09 Jun 2013 10:33:13 +0000
with message-id <[email protected]>
and subject line Bug#641833: fixed in digitools 1.03-1.2
has caused the Debian Bug report #641833,
regarding digitools: FTBFS with ld that defaults to --as-needed: bad link order
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
641833: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=641833
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: digitools
Version: 1.3-1
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch oneiric

digitools fails to build with a linker that defaults to --as-needed, as
shown in this Ubuntu bug report:

  https://bugs.launchpad.net/ubuntu/+source/digitools/+bug/831389

This is because of incorrect link ordering: it puts libraries before the
objects that use them rather than after.  See:

  http://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries

The following patch fixes this.

  * Put libraries in LDLIBS, not LDFLAGS.

diff -u digitools-1.03/debian/patches/00list 
digitools-1.03/debian/patches/00list
--- digitools-1.03/debian/patches/00list
+++ digitools-1.03/debian/patches/00list
@@ -1,0 +2 @@
+02_link_order.dpatch
only in patch2:
unchanged:
--- digitools-1.03.orig/debian/patches/02_link_order.dpatch
+++ digitools-1.03/debian/patches/02_link_order.dpatch
@@ -0,0 +1,20 @@
+#! /bin/sh /usr/share/dpatch/dpatch-run
+## 02_link_order.dpatch by Colin Watson <[email protected]>
+##
+## All lines beginning with `## DP:' are a description of the patch.
+## DP: Libraries belong in LDLIBS rather than LDFLAGS, otherwise the link
+## DP: order will be wrong.
+
+@DPATCH@
+diff -urNad '--exclude=CVS' '--exclude=.svn' '--exclude=.git' 
'--exclude=.arch' '--exclude=.hg' '--exclude=_darcs' '--exclude=.bzr' 
digitools-1.03~/Makefile digitools-1.03/Makefile
+--- digitools-1.03~/Makefile   2011-09-16 16:52:05.000000000 +0100
++++ digitools-1.03/Makefile    2011-09-16 16:52:25.000000000 +0100
+@@ -3,7 +3,7 @@
+ SBINDIR = $(PREFIX)/sbin
+ 
+ # Users should not need to edit anything below this line.
+-LDFLAGS = -lasound
++LDLIBS = -lasound
+ CFLAGS = -Wall -Os
+ 
+ LN = ln

Thanks,

-- 
Colin Watson                                       [[email protected]]



--- End Message ---
--- Begin Message ---
Source: digitools
Source-Version: 1.03-1.2

We believe that the bug you reported is fixed in the latest version of
digitools, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <[email protected]> (supplier of updated digitools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 04 Jun 2013 10:55:56 +0100
Source: digitools
Binary: digitools
Architecture: source i386
Version: 1.03-1.2
Distribution: unstable
Urgency: low
Maintainer: Cyril Lacoux (Yack) <[email protected]>
Changed-By: Colin Watson <[email protected]>
Description: 
 digitools  - A set of tools to control ASUS Digimatrix embedded hardware
Closes: 641833
Changes: 
 digitools (1.03-1.2) unstable; urgency=low
 .
   * Non-maintainer upload.
   * Put libraries in LDLIBS, not LDFLAGS (closes: #641833, LP: #831389).
Checksums-Sha1: 
 2bff964bd5cbe6f5ae316ac993be6a9626b8f706 1749 digitools_1.03-1.2.dsc
 8c67b9c657353b5ea102bb31003a1510ca56f2b4 4088 digitools_1.03-1.2.debian.tar.gz
 4beaf32c6233ca2e233504d75cee01f3174dc760 17626 digitools_1.03-1.2_i386.deb
Checksums-Sha256: 
 c73ea2e46881b5d07c8b90bf326436ecce4f1980656a836562dfb477dd089492 1749 
digitools_1.03-1.2.dsc
 67b0563521a425dc0e83b911e61e45c1236373a8987dde8b4726df78d8cba19f 4088 
digitools_1.03-1.2.debian.tar.gz
 1479cef996af2c205157c9acb3f83b060fc58f079281af793ac6393b3d41b8b9 17626 
digitools_1.03-1.2_i386.deb
Files: 
 31be0678c32c387bead6a2a1341e0326 1749 utils extra digitools_1.03-1.2.dsc
 f059184e599b9124feb636bc5eaca47a 4088 utils extra 
digitools_1.03-1.2.debian.tar.gz
 94fbdb3cf62a94800f6d764d3957a011 17626 utils extra digitools_1.03-1.2_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
Comment: Colin Watson <[email protected]> -- Debian developer

iQIVAwUBUa26Njk1h9l9hlALAQgEyw//diwbv9FKhExoSI6mXoYK2P9pMaRGB15H
TBvjM1HDDXfW1ZAvQ8m04sjrzYDVu8aLdQ09zou7NuQ88RS8czzmicGmVdP1hsxn
A8IjCHdJ/4g6NHC2bD5hShZHb7LzDZ7htun9BTH782HsQ0W6SXOcmBhRnTU/+hN0
y4HXMkRHLROd/4/BDfF7IvUpTaa3vkR78GwMSJgV+TYkejOk0RmECVzRK6XaZQzN
uEKsmMr8EdER1gt+cvNCGewYasVRmsMf8xw3VKNycosW4Pfy1M+o2lo4rF2Yy0pn
dnl+WuI2iHLHGwqr6QnLowfxQ8acYoZR9sWrC2jJzDWQEjvK0oXjU/CBwtc0LNOX
fOK3QmTo03TMRta/XuVJ4p6c6IEg+upOKamwpNuntcE51Zhib9RCGAHDOiXizbLn
qJ7HonD7ealtzPB85g9GzgtRCLFPOq2oo1j1/iIOPJthE3QobdvC+0simyS7h824
cMfpdQj3+dMsyms3sRhDH4NkZ6PW3l3k3FoFT378V9jJYQwBvmZhtflH8tZwy0BX
0jUPS/sPlfmOK2Md+hLpwdvaqfY80cHD6Tc5N0/ym6gXvqvXOjfVwNTmuIw0MtfF
9KSQmPW/QiXwQAK5qWuSEHpnVgfYtNnToiS9k41OgA2qxdnypI+4bJ1Ze5wtQcRJ
I7iObp+7PtA=
=vbv/
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to