Your message dated Wed, 10 Jul 2013 09:03:16 +0000
with message-id <[email protected]>
and subject line Bug#715166: fixed in check 0.9.10-4
has caused the Debian Bug report #715166,
regarding check: FTBFS on hurd-i386
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
715166: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=715166
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: check
Version: 0.9.10-3
Severity: important
Tags: patch
User: [email protected]
Usertags: hurd
Control: forwarded -1 https://sourceforge.net/p/check/patches/49/
Hi,
check 0.9.10-3 does not build on hurd-i386 [1].
The problem is due to the second-only precision which is available with
alarm in the replacement for the timer_* functions (not implemented yet
on Hurd), which causes few check failures in two tests.
I just reported the issue upstream [2] with a clean patch for the issue;
since that requires autoreconf, I'm providing a simplier patch which
just unconditionally switches the timer_settimer replacement to
setitimer; should cause no issues on Linux and kFreeBSD, since both
implement the timer_* functions.
Both patches (the one sent upstream and the one attached here) fix the
issue on Hurd.
[1]
https://buildd.debian.org/status/fetch.php?pkg=check&arch=hurd-i386&ver=0.9.10-3&stamp=1373106835
[2] https://sourceforge.net/p/check/patches/49/
Thanks,
--
Pino
--- a/lib/timer_settime.c
+++ b/lib/timer_settime.c
@@ -1,22 +1,18 @@
#include "libcompat.h"
+#include <sys/time.h>
+
int timer_settime(timer_t timerid CK_ATTRIBUTE_UNUSED,
int flags CK_ATTRIBUTE_UNUSED,
const struct itimerspec *new_value,
struct itimerspec * old_value CK_ATTRIBUTE_UNUSED)
{
- int seconds = new_value->it_value.tv_sec;
-
- /*
- * As the alarm() call has only second precision, if the caller
- * specifies partial seconds, we round up to the nearest second.
- */
- if(new_value->it_value.tv_nsec > 0)
- {
- seconds += 1;
- }
-
- alarm(seconds);
-
- return 0;
+ struct itimerval new;
+
+ new.it_value.tv_sec = new_value->it_value.tv_sec;
+ new.it_value.tv_usec = new_value->it_value.tv_nsec / 1000;
+ new.it_interval.tv_sec = new_value->it_interval.tv_sec;
+ new.it_interval.tv_usec = new_value->it_interval.tv_nsec / 1000;
+
+ return setitimer(ITIMER_REAL, &new, NULL);
}
--- End Message ---
--- Begin Message ---
Source: check
Source-Version: 0.9.10-4
We believe that the bug you reported is fixed in the latest version of
check, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thomas Bechtold <[email protected]> (supplier of updated check package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Wed, 10 Jul 2013 09:46:55 +0200
Source: check
Binary: check
Architecture: source amd64
Version: 0.9.10-4
Distribution: unstable
Urgency: low
Maintainer: Robert Lemmen <[email protected]>
Changed-By: Thomas Bechtold <[email protected]>
Description:
check - unit test framework for C
Closes: 715166
Changes:
check (0.9.10-4) unstable; urgency=low
.
* debian/patches: Add 04setitimer_hurd.patch to fix build on hurd (closes:
#715166).
Checksums-Sha1:
5d64753986e9eba80136ddac2417b3daa83f8fed 1911 check_0.9.10-4.dsc
8a07b90db1e99c847fb0b15dc1855ee7b11935d6 7133 check_0.9.10-4.debian.tar.gz
345406f0aa88520e54b13c6b978a3e26ed1b4e81 146184 check_0.9.10-4_amd64.deb
Checksums-Sha256:
0f382b84114a68cf8dae16910e5529746092480d231994dc8a5f22d6b6e3b347 1911
check_0.9.10-4.dsc
7114f7534489d751fb06e4c93c426aa037ec271d0a2aa03856c75b5c5864aae3 7133
check_0.9.10-4.debian.tar.gz
dcadf3c0e1b5ac9233a9abbbec87a79e7eaada9e487ee0e3d74b358906e1adac 146184
check_0.9.10-4_amd64.deb
Files:
2fadaac4872a69966d2497534dcfcff6 1911 devel optional check_0.9.10-4.dsc
5611143cb80bca2910ae36019628e02e 7133 devel optional
check_0.9.10-4.debian.tar.gz
6ffd21bf43b1a3490eb019b695a51207 146184 devel optional check_0.9.10-4_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)
iQIcBAEBCAAGBQJR3RdfAAoJEELuctrCcxmtGlkQAIebtRH/lxhfB9hbagzfn+o8
4z1fu40Mrq8s7N+tUoxbGe3hebEoyGPtiLg5D58bTHsUhm6od9ASR78gg5LF++bm
OBMkxdbzJd8xB//CZf8o0U9GciN0Yjh76+wPeixUrHcNjrRG0re+Ho4SBWkZOn22
FpJ2B/gANLTWNvK8MlqLmGkOCtWrrpl2rAuFIQ2nE2iRlBFTJYXrmYj19Eo4hZTB
EhzJyvY4W8BT6a0cSp9isSR4NQsCpJrqJZjgpZxSP9ghMkD+6GTKuAnEqNeTjVD1
X3ULH1s5q0cO+73yN5QQ3a55MA/enghzRsJrD8wLpChCKF+YOgniklypBpmG/2kK
mUOxlSqu7f5p2mZLH/0EvKhIQzR8P+htkObvKvzLxDqHbV6hDzRHW/hQ6D7Vfp9z
WQLiAiSTwAXEhcbf5r/O4zlym6mhFmHPR2unHfS0bGfA2VOFZzaic5jVhkA9R4mH
m8KJZRREvtGCqT79IV+dqojjl+zzkBOPAy6NIynbDVY7Ax/E0Zq0BNkNzuFQwfDm
jjFPxWPgEXbVGmqtOkTo9oKp7phZBZItAoljY1+pnkygiAVTOxyxWJozioEWl8sB
OE7G2Au3pAu/89BzeqPkGh4eJEtwGedfCANTfhk9fGt9EpLWjB62IJgeEZ9KzBau
YKZPhY62maNr+fl+K+AV
=Y9iz
-----END PGP SIGNATURE-----
--- End Message ---
