Your message dated Fri, 04 Nov 2005 05:32:06 -0800
with message-id <[EMAIL PROTECTED]>
and subject line Bug#335592: fixed in randomplay 0.48
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 24 Oct 2005 20:38:20 +0000
>From [EMAIL PROTECTED] Mon Oct 24 13:38:20 2005
Return-path: <[EMAIL PROTECTED]>
Received: from moutng.kundenserver.de [212.227.126.183]
by spohr.debian.org with esmtp (Exim 3.36 1 (Debian))
id 1EU95I-0005Ck-00; Mon, 24 Oct 2005 13:38:20 -0700
Received: from p54AD3A99.dip0.t-ipconnect.de [84.173.58.153] (helo=sparc)
by mrelayeu.kundenserver.de with ESMTP (Nemesis),
id 0ML25U-1EU95C26PF-0007iV; Mon, 24 Oct 2005 22:38:14 +0200
Received: from madroach by sparc with local (Exim 4.54)
id 1EU94C-0000Kq-Si; Mon, 24 Oct 2005 22:37:12 +0200
Content-Type: multipart/mixed; boundary="===============0172994246=="
MIME-Version: 1.0
From: Christopher Zimmermann <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: randomplay: fails to skip tracks played by play (sox)
X-Mailer: reportbug 3.17
Date: Mon, 24 Oct 2005 22:37:12 +0200
Message-Id: <[EMAIL PROTECTED]>
X-Provags-ID: kundenserver.de [EMAIL PROTECTED]
login:ffa0b79550bcbf7dc9e74e421174f785
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE
autolearn=no version=2.60-bugs.debian.org_2005_01_02
This is a multi-part MIME message sent by reportbug.
--===============0172994246==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: randomplay
Version: 0.47
Severity: normal
Tags: patch
Hi,
randomplay failes to skip tracks played by the play command, which in
turn runs sox. That's because the KillAll sub is limited to kill only
the children of a process and not it's grandchildren. I modified it to
recursively kill all descendants.
Christopher
*** patch
--- /usr/bin/randomplay 2005-09-04 13:57:39.000000000 +0200
+++ randomplay 2005-10-24 22:28:43.000000000 +0200
@@ -67,7 +67,7 @@
eval $regexp_if_statement;
}
-# KillAll kills the request process ID and all of its children
+# KillAll recursively kills the request process ID and all of its children,
grandchildren...
# This is a bit of a hack--there should be a better way to do this, but I
haven't found one.
# Normally, kill HUP => -$$ should do the job, except this doesn't work when
randomplay itself
# is called from a shell script and all output from child processes is
redirected to null.
@@ -79,7 +79,8 @@
local $SIG{HUP} = 'IGNORE'; # don't want to kill ourselves here--shouldn't
happen, but just in case.
if (open PS, "ps -o pid,ppid |") {
foreach my $line (<PS>) {
- kill HUP => $1 if ($line =~ /^\s*(\d+)\s*(\d+)\s*$/ and ($1 eq $pid or
$2 eq $pid));
+ kill HUP => $pid;
+ KillAll($1) if ($line =~ /^\s*(\d+)\s*(\d+)\s*$/ and ($2 eq $pid));
}
close PS;
} else { # if we can't read the process table, just try
killing the child process group
-- System Information:
Debian Release: testing/unstable
APT prefers testing
APT policy: (500, 'testing')
Architecture: sparc (sparc64)
Shell: /bin/sh linked to /bin/dash
Kernel: Linux 2.6.14-rc4-sparc
Locale: LANG=C, LC_CTYPE=de_DE (charmap=ISO-8859-1)
Versions of packages randomplay depends on:
ii libdate-calc-perl 5.4-4 Perl library for accessing dates
ii libmp3-info-perl 1.13-1 Perl MP3::Info - Manipulate / fetc
ii libogg-vorbis-header-perl 0.03-1 perl interface to Ogg Vorbis infor
ii libterm-readkey-perl 2.30-2 A perl module for simple terminal
ii perl 5.8.7-6 Larry Wall's Practical Extraction
Versions of packages randomplay recommends:
ii mpg321 0.2.10.3 A Free command-line mp3 player, co
ii vorbis-tools 1.0.1-1.4 Several Ogg Vorbis Tools
-- no debconf information
--===============0172994246==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="patch"
--- /usr/bin/randomplay 2005-09-04 13:57:39.000000000 +0200
+++ randomplay 2005-10-24 22:28:43.000000000 +0200
@@ -67,7 +67,7 @@
eval $regexp_if_statement;
}
-# KillAll kills the request process ID and all of its children
+# KillAll recursively kills the request process ID and all of its children,
grandchildren...
# This is a bit of a hack--there should be a better way to do this, but I
haven't found one.
# Normally, kill HUP => -$$ should do the job, except this doesn't work when
randomplay itself
# is called from a shell script and all output from child processes is
redirected to null.
@@ -79,7 +79,8 @@
local $SIG{HUP} = 'IGNORE'; # don't want to kill ourselves here--shouldn't
happen, but just in case.
if (open PS, "ps -o pid,ppid |") {
foreach my $line (<PS>) {
- kill HUP => $1 if ($line =~ /^\s*(\d+)\s*(\d+)\s*$/ and ($1 eq $pid or
$2 eq $pid));
+ kill HUP => $pid;
+ KillAll($1) if ($line =~ /^\s*(\d+)\s*(\d+)\s*$/ and ($2 eq $pid));
}
close PS;
} else { # if we can't read the process table, just try
killing the child process group
--===============0172994246==--
---------------------------------------
Received: (at 335592-close) by bugs.debian.org; 4 Nov 2005 13:36:42 +0000
>From [EMAIL PROTECTED] Fri Nov 04 05:36:42 2005
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 3.36 1 (Debian))
id 1EY1fq-0001Sb-00; Fri, 04 Nov 2005 05:32:06 -0800
From: Adam Rosi-Kessel <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.56 $
Subject: Bug#335592: fixed in randomplay 0.48
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Fri, 04 Nov 2005 05:32:06 -0800
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
Source: randomplay
Source-Version: 0.48
We believe that the bug you reported is fixed in the latest version of
randomplay, which is due to be installed in the Debian FTP archive:
randomplay_0.48.dsc
to pool/main/r/randomplay/randomplay_0.48.dsc
randomplay_0.48.tar.gz
to pool/main/r/randomplay/randomplay_0.48.tar.gz
randomplay_0.48_i386.deb
to pool/main/r/randomplay/randomplay_0.48_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Adam Rosi-Kessel <[EMAIL PROTECTED]> (supplier of updated randomplay package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sun, 30 Oct 2005 08:38:19 -0500
Source: randomplay
Binary: randomplay
Architecture: source i386
Version: 0.48
Distribution: unstable
Urgency: low
Maintainer: Adam Rosi-Kessel <[EMAIL PROTECTED]>
Changed-By: Adam Rosi-Kessel <[EMAIL PROTECTED]>
Description:
randomplay - command-line based shuffle music player that remembers songs betw
Closes: 335592
Changes:
randomplay (0.48) unstable; urgency=low
.
* When advancing tracks, kill not just children of player program, but
all spawned processes. Thanks to Christopher Zimmermann for the
patch. (Closes: #335592).
Files:
3b672b8e3d01ca74b57aec79a9491df2 502 sound optional randomplay_0.48.dsc
c10b5bcb13967b81341bfe4c03549edc 16351 sound optional randomplay_0.48.tar.gz
a17d3779f827a4b6bfd508fe27491d50 20664 sound optional randomplay_0.48_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iD8DBQFDZM5pdTf3ZklQ6qYRAib/AJ9JYMDu6GLilG1AwifvW+CXI3RjkACgtXyK
2iGqBhWfAxi2BcRKrIMe54w=
=+4DK
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
