Your message dated Wed, 02 Oct 2013 22:36:06 +0000 with message-id <[email protected]> and subject line Bug#691506: fixed in sympa 6.1.17~dfsg-1 has caused the Debian Bug report #691506, regarding [PATCH] debian/postinst: Invert premise in if-statement for adding configuration parameters to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 691506: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=691506 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: sympa Version: debian/6.0.1-1 Severity: normal Control: tags -1 patch Dear Debian folks, please apply the patch from below. I also could not find the documentation saying the parameters are required. It should also be backported to the version in Squeeze. Thanks, Paul --- 8< ---- >8 --- Date: Fri, 26 Oct 2012 11:59:29 +0200 Subject: [PATCH] debian/postinst: Invert premise in if-statement for adding configuration parameters The following commit commit 463789a828c8edad0438327a9233d82b2fea5c90 Author: Stefan Hornburg (Racke) <[email protected]> Date: Sun Apr 11 15:21:14 2010 +0200 on upgrades from Sympa 5 ensure that bounce_warn_rate/bounce_halt_rate directives are set in sympa.conf intended to add a check to `debian/postinst`, appending the parameters `bounce_warn_rate` and `bounce_halt_rate` to `/etc/sympa/sympa.conf` when not being found and when upgrading from Sympa 5.x. Experiencing the problem described bug report #631162 [1], I noticed that both parameters were added to `sympa.conf` every time I tried to configure the package. Looking at the check, revealed that the premise was inverted. Additionally, both parameters were already present in my `sympa.conf` from Sympa 5.3.4-x. But they were commented. If they need to be set, as the commit message above suggests, then the check needs to be adapted to add the parameters even if they are commented. [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=631162 --- debian/postinst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/postinst b/debian/postinst index 50acc83..a7ea49b 100644 --- a/debian/postinst +++ b/debian/postinst @@ -94,10 +94,10 @@ rm -f "$conf"~ if [ "$1" = "configure" ]; then if [ -n "$2" ] && dpkg --compare-versions "$2" lt "6.0.1"; then # add required parameters in Sympa 6 - if grep -q bounce_warn_rate $conf; then + if ! grep -q -e '^bounce_warn_rate' $conf; then echo "bounce_warn_rate 30" >> $conf; fi - if grep -q bounce_halt_rate $conf; then + if ! grep -q -e '^bounce_halt_rate' $conf; then echo "bounce_halt_rate 50" >> $conf; fi # fix paths -- 1.7.10.4
signature.asc
Description: This is a digitally signed message part
--- End Message ---
--- Begin Message ---Source: sympa Source-Version: 6.1.17~dfsg-1 We believe that the bug you reported is fixed in the latest version of sympa, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Emmanuel Bouthenot <[email protected]> (supplier of updated sympa package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Format: 1.8 Date: Tue, 24 Sep 2013 21:41:18 +0000 Source: sympa Binary: sympa Architecture: source amd64 Version: 6.1.17~dfsg-1 Distribution: unstable Urgency: low Maintainer: Debian Sympa team <[email protected]> Changed-By: Emmanuel Bouthenot <[email protected]> Description: sympa - Modern mailing list manager Closes: 669803 682563 682664 691506 706965 709565 712141 714388 717435 724086 Changes: sympa (6.1.17~dfsg-1) unstable; urgency=low . * New upstream release: - Fix possible infinite loop while generating digest with text/plain binary attachements (Closes: #712141) - Fix missing templates (Closes: #714388) - Switch the default locale from en_US to en (update debconf templates accordingly) (Closes: #682563) * Refresh patches: - Fix 'CREATE DATABASE' syntax with mysql backend. Thanks to Daniel Caillibaud for the patch (Closes: #682664) * Add a patch to make possible to fallback on C locale when no other locales are available * Add a patch to raise a warning instead of an error when the CA bundle file is not readable (Closes: #706965, #717435) * Fix packaging to support Apache >= 2.4 (Closes: #669803) * Update manpages patch to fix a FTBFS caused by lack of 'encoding' identifer in pod snippets (Closes: #724086) * Add dependency on libsoap-lite-perl * Fix Vcs-* fields * Bump Standards-Version to 3.9.4 * Remove support of sqlite < 3 * Add a warning message in postinst about the fix of permissions and ownership which can take a while. Thanks to David Prévot for the suggestion (Closes: #709565) * Fix a bug in postinst while trying to add missing parameters in sympa.conf during upgrade to sympa > 6.0.1. Thanks to Paul Menzel for the patch (Closes: #691506) * Minor updates in debian/copyright * Switch to debhelper >= 9 Checksums-Sha1: 51684a564a966934a1419cd7857a0e976c41c4be 2517 sympa_6.1.17~dfsg-1.dsc ac43ab205d681343681abff9772d55a541fd912a 5582004 sympa_6.1.17~dfsg.orig.tar.gz 3d42df0f13b216b595b14541426c6959c0e2b7f4 118776 sympa_6.1.17~dfsg-1.debian.tar.gz f58cb1ed377f8d6a22d2b565a10a7a66eff2e23d 2096214 sympa_6.1.17~dfsg-1_amd64.deb Checksums-Sha256: 9a6ae19a77c40d8d68f00b6b3ec4f737e056aed93d695be17f3fe96456d7ef49 2517 sympa_6.1.17~dfsg-1.dsc 82398955d8052d323441718ee3830ddf505ee50acdb82431acc7a297bf3f77b6 5582004 sympa_6.1.17~dfsg.orig.tar.gz 73c9acd941894a1d0d17194d5cdfc2e7f3d2d403f7b9cdfe2ea9ddf005d6b9a0 118776 sympa_6.1.17~dfsg-1.debian.tar.gz 1974ef0f15c530418f65ea17ce25b7750cc633800fbed1c5921e2d0b74c27839 2096214 sympa_6.1.17~dfsg-1_amd64.deb Files: 3a2cac33de59432b8d11aea192413b21 2517 mail optional sympa_6.1.17~dfsg-1.dsc 1cf3040bf1f8013b7ebcf3bf8216bb18 5582004 mail optional sympa_6.1.17~dfsg.orig.tar.gz 076cf5d8c110c6856b82f0e244dd846d 118776 mail optional sympa_6.1.17~dfsg-1.debian.tar.gz 9e623cba0566abc75033faea3eb073bc 2096214 mail optional sympa_6.1.17~dfsg-1_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) iQIcBAEBCgAGBQJSTJ0qAAoJEEsHdyOSnULDoNAQAIANqdXVv5W7IIKo02rmWzbE nBXmNm133H/r50kNoAv2Ht162dwqaUhdyDxPMmqsWxA2EjcIODhWReyE/89e6jgB S7OPbWEYo9xe8rLA/68K4CcqBAi9kLBL+awSvkpdCWcfmv3DEP6kiPeuFU280LXm 0hpYQ8WJu8jzaFTftRa8J2a5DsS0zyPR6UsQsdNPclCNX3fT5NMaoucTp3/Aub/k VSMOW6BK1bmM1YPUAjJ8YDoNKlbarKLxmuHxDzEEBzS/2ATKu6cmgQ7wSgp3fO0W or4I6bRkwrWJGdU0azXufl6Jq45YeLaWMojM/AgoYetbsDQA9WyLASHFNVfGLVF0 Ae6k/Q0XGlpy6jyi+e7k4PoCPOQ3r8dyt8hC7jShb3ihnKUxsrDCQnqv4muMzYNm lQX5v57Gc7J+oBVt7pyMXSMoJ6O0FqcEiEQc46eKAP11RD6VdoWYxQacrOY315+8 6BMIMC/L6T7O8u0UYJ6PShGhJXD/XCjlzYnBO5zka5k6VikoefEY6k+d93mPwM4X +FoRd/OZHVyv/Y0GHfwRMrxxwDiEcWZR5Gd+ryW5n/PxLqasnst727Wn2WgQ2UP5 h9gK7my/0V/A7NMiDfyuws3m9IvyBS1YFYKtkWEbtxKML/tlSwqTjYsNySPjrOpa yZ6R2V+fQOhHzj7zB/bB =/RcS -----END PGP SIGNATURE-----
--- End Message ---
