Your message dated Sun, 03 Nov 2013 16:33:19 +0000
with message-id <[email protected]>
and subject line Bug#728583: fixed in etckeeper 1.10
has caused the Debian Bug report #728583,
regarding etckeeper: Git variables are not exported when run under sudo
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
728583: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=728583
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: etckeeper
Version: 1.9ubuntu1
Severity: normal
Tags: upstream patch

Dear Maintainer,

version 1.5 introduced a change which causes the Git configuration of
the actual user being used when executed using sudo.

However, the GIT_* (name, e-mail) variables are not exported, therefore
Git does not find them and falls back to determining them itself. This
results in an e-mail such as "host.(none)" which Git rejects as invalid.

I have fixed the error by exporting the variables in the
commit.d/50vcs-commit script, which seems to work.

You can git pull the fix from the git-export branch at
https://git.ikkoku.de/git/suraia/etckeeper

Alternatively, I am attaching a patch for your convenience.

   * What led up to the situation?

Upgrading from version 1.4 to 1.9 produced an error in the post-install
hook (using "sudo aptitude").

-- System Information:
Debian Release: wheezy/sid
  APT prefers saucy-updates
  APT policy: (500, 'saucy-updates'), (500, 'saucy-security'), (500, 'saucy')
Architecture: amd64 (x86_64)

Kernel: Linux 3.11.0-12-generic (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages etckeeper depends on:
ii  debconf [debconf-2.0]  1.5.50ubuntu1
ii  git                    1:1.8.4.1-1~saucy1
ii  hostname               3.13ubuntu1

Versions of packages etckeeper recommends:
ii  cron  3.0pl1-124ubuntu2

Versions of packages etckeeper suggests:
ii  sudo  1.8.6p3-0ubuntu3

-- Configuration Files:
/etc/etckeeper/etckeeper.conf changed [not included]

-- debconf information excluded
>From c9e372abf2fc40a0ef07599e54f2b2755269a067 Mon Sep 17 00:00:00 2001
From: Michael Kuhn <[email protected]>
Date: Sun, 3 Nov 2013 11:32:32 +0100
Subject: [PATCH] Export Git variables, otherwise Git falls back to determining
 them itself.

---
 commit.d/50vcs-commit | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/commit.d/50vcs-commit b/commit.d/50vcs-commit
index 3a4c819..5987ad6 100755
--- a/commit.d/50vcs-commit
+++ b/commit.d/50vcs-commit
@@ -46,14 +46,14 @@ if [ "$VCS" = git ] && [ -d .git ]; then
 		USER_HOME="$(perl -e 'print ((getpwnam(shift()))[7])' "$USER")"
 		if [ -n "$USER_HOME" ] && [ -e "$USER_HOME/.gitconfig" ]; then
 			if [ -z "$GIT_AUTHOR_NAME" ]; then
-				GIT_AUTHOR_NAME="$(git config -f "$USER_HOME/.gitconfig" user.name)" || true
+				export GIT_AUTHOR_NAME="$(git config -f "$USER_HOME/.gitconfig" user.name)" || true
 			fi
 			if [ -z "$GIT_AUTHOR_EMAIL" ]; then
-				GIT_AUTHOR_EMAIL="$(git config -f "$USER_HOME/.gitconfig" user.email)" || true
+				export GIT_AUTHOR_EMAIL="$(git config -f "$USER_HOME/.gitconfig" user.email)" || true
 			fi
 		fi
 		if [ -z "$GIT_COMMITTER_EMAIL" ]; then
-			GIT_COMMITER_EMAIL="$(git config --global user.email)" || true
+			export GIT_COMMITER_EMAIL="$(git config --global user.email)" || true
 		fi
 
 		if [ -z "$GIT_AUTHOR_NAME" ]; then
-- 
1.8.4.2


--- End Message ---
--- Begin Message ---
Source: etckeeper
Source-Version: 1.10

We believe that the bug you reported is fixed in the latest version of
etckeeper, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Joey Hess <[email protected]> (supplier of updated etckeeper package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sun, 03 Nov 2013 12:14:02 -0400
Source: etckeeper
Binary: etckeeper
Architecture: source all
Version: 1.10
Distribution: unstable
Urgency: low
Maintainer: Joey Hess <[email protected]>
Changed-By: Joey Hess <[email protected]>
Description: 
 etckeeper  - store /etc in git, mercurial, bzr or darcs
Closes: 728583
Changes: 
 etckeeper (1.10) unstable; urgency=low
 .
   * Remove lvm/backup from default ignores, because lvm
     documentation recommends backing that up, for use by
     vgcfgrestore.
   * Fix exporting of some git variables. Closes: #728583
Checksums-Sha1: 
 dadb9e9d22f76a84aaab2ec51d60fd060911d735 1574 etckeeper_1.10.dsc
 aea3e7fdf6bdc9e8aeb39e647c3c76096b8cfff2 48432 etckeeper_1.10.tar.gz
 9dfa808fd5137c6a0e9e1ba8fdf8683faf601059 35468 etckeeper_1.10_all.deb
Checksums-Sha256: 
 6fab634e929bc3b8a087fafb45169044c9fc5f990b98c0135bac8542238884de 1574 
etckeeper_1.10.dsc
 d3d057bac155e161802a747d49996af87c9754959d34f063261826813752a7dd 48432 
etckeeper_1.10.tar.gz
 248824eb42fb127ef5b9a47cff6f30527f63136734bb8cb1285407cf592efd3c 35468 
etckeeper_1.10_all.deb
Files: 
 048085ad2c4dbcc5a5b2142524e88070 1574 admin optional etckeeper_1.10.dsc
 8f9376166d97aa3c842223db93ee2889 48432 admin optional etckeeper_1.10.tar.gz
 2f6655ed47f82775b9069a3032c866df 35468 admin optional etckeeper_1.10_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.15 (GNU/Linux)

iQIVAwUBUnZ28ckQ2SIlEuPHAQgZ6Q/+Ip5wkaT5ro0+m65/r8LAVmgJkIhLu9ck
PxP6886Kia1nFzDbc+uzjaO2eFGgTia826EFHdY0TCsR282z73+zXIAHFZQ6lfdx
qKTvUXweLNwVrioXqiizS4TXK5re6TRHj+EjL2IMeJcrbzDQeCiH3kjbQTwL1OWe
i+HNf6X+4aC56hjhlfAHBMK9Tx3lKh6wOeCu0Y8QAgof0Mk/zMiPJ8M0Fibyb6+P
fVJ6j9goIKs78Z828Y5NYTXcOJijc97tVw83AONKDw35cp5a1cwhXkVuaDw/c6az
jPY3Oitfl8bQ+ISMzOiDJ9BoTUHcTYgb5sbZU28AGAMLleLgWLgpaQMH6av00yna
ZmFoLk+h1+JD58TsO4BNBt2jL2rnSoa5zKVWlb0t6LP5GEp5qHps05PQFiGLWTV/
fLvo9IqgTEIKHHiPM9SiwUkaZmPj7+NYKTAqxjkjejNiSJGSWbGUp21DXVs9ZOzf
+rEaModD3q0GuXOsXnXh7HCkvrX4RiHo8BY4x7JxNSf3TDj417jTPPavGdjNlH3G
Szel/vfh+T5GCaB+wt/UcSzbTPZUoXVJPRXDofZ5D2SNqsRwnF3YrXWdVJ734/jZ
ZgaXX8XCdknFxUtZLHO0VEekV82hhzoAgww30s0/ZBnTeRW5nCrZCPYLmDHn2Wno
PIwwmUkgbzI=
=zCZE
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to