Your message dated Thu, 26 Dec 2013 16:19:25 +0000
with message-id <[email protected]>
and subject line Bug#732572: fixed in tor 0.2.4.20-1
has caused the Debian Bug report #732572,
regarding /etc/init.d/tor: Tor daemon won't start if /var/log/tor does not 
exist, even though it could create new dir
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
732572: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=732572
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: tor
Version: 0.2.3.25-1
Severity: wishlist
File: /etc/init.d/tor
Tags: patch

Dear Maintainer (you are awesome),

So I run /var/log on a tmpfs, which means at restart, it is empty. Most
programs will recreate their logfiles in the absence of any old files or
directories, but Tor will fail with the following error

> Starting tor daemon...
> [warn] Couldn't open file for 'Log notice file /var/log/tor/notice.log': No 
> such file or directory
> [warn] Failed to parse/validate config: Failed to init Log options. See logs 
> for details.
> [err] Reading config failed--see warnings above.
 
Tor's init.d script already handles a missing /var/run/tor/ directory by
creating a new one, so I thought it might be useful for the same script
to re-create a missing /var/log/tor directory. Patch is included below.

The additional function is based on the /var/run/tor action.

d.

-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.11-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages tor depends on:
ii  adduser         3.113+nmu3
ii  libc6           2.17-2
ii  libevent-2.0-5  2.0.19-stable-3
ii  libssl1.0.0     1.0.1e-2
ii  lsb-base        4.1+Debian9
ii  zlib1g          1:1.2.7.dfsg-13

Versions of packages tor recommends:
ii  logrotate    3.8.3-3
ii  tor-geoipdb  0.2.3.25-1
ii  torsocks     1.2-3

Versions of packages tor suggests:
pn  apparmor-utils     <none>
pn  mixmaster          <none>
ii  privoxy            3.0.20-1
ii  socat              1.7.1.3-1.4
pn  tor-arm            <none>
ii  xul-ext-torbutton  1.4.6.3-1

-- Configuration Files:
/etc/init.d/tor changed 

-- no debconf information
--- /home/danny/tmp/tor	2013-12-18 13:41:17.884898842 -0800
+++ /etc/init.d/tor	2013-12-18 13:38:14.321388245 -0800
@@ -24,6 +24,7 @@
 DAEMON=/usr/sbin/tor
 NAME=tor
 DESC="tor daemon"
+TORLOGDIR=/var/log/tor
 TORPIDDIR=/var/run/tor
 TORPID=$TORPIDDIR/tor.pid
 DEFAULTSFILE=/etc/default/$NAME
@@ -108,6 +109,15 @@
 	fi
 }
 
+check_torlogdir () {
+	if test ! -d $TORLOGDIR; then
+		mkdir -m 02750 "$TORLOGDIR"
+		chown debian-tor:adm "$TORLOGDIR"
+		! [ -x /sbin/restorecon ] || /sbin/restorecon "$TORPIDDIR"
+	fi
+}
+
+
 check_config () {
 	if ! $DAEMON $VERIFY_ARGS > /dev/null; then
 		log_failure_msg "Checking if $NAME configuration is valid"
@@ -134,6 +144,7 @@
 	fi
 
 	check_torpiddir
+	check_torlogdir
 	check_config
 
 	log_action_begin_msg "Starting $DESC"

--- End Message ---
--- Begin Message ---
Source: tor
Source-Version: 0.2.4.20-1

We believe that the bug you reported is fixed in the latest version of
tor, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Peter Palfrader <[email protected]> (supplier of updated tor package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Thu, 26 Dec 2013 16:57:29 CET
Source: tor
Binary: tor tor-dbg tor-geoipdb
Architecture: source all
Version: 0.2.4.20-1
Distribution: unstable
Urgency: low
Maintainer: Peter Palfrader <[email protected]>
Changed-By: Peter Palfrader <[email protected]>
Description: 
 tor - anonymizing overlay network for TCP
 tor-dbg - debugging symbols for Tor
 tor-geoipdb - GeoIP database for Tor
Closes: 732105 732572
Changes: 
 tor (0.2.4.20-1) unstable; urgency=low
 .
   * New upstream version.
     - Avoid a crash bug when starting with a corrupted microdescriptor cache
       file. Fixes bug 10406; bugfix on 0.2.2.6-alpha (closes: #732105).
   * init script: make /var/log/tor if it does not exist anymore
     (closes: #732572).
Checksums-Sha256: 
 aedf5397ba5412e67418db64c3704b365bb775a561549ae15828d3ee8aedcbf0 1693 
tor_0.2.4.20-1.dsc
 ccc51747cbcbf98f658c34d5c693ff8a868698da0349d056e98287ef2e294d9f 2867180 
tor_0.2.4.20.orig.tar.gz
 f5397004f842639522bf4f3a55983c2f20fec8e8101895a44ff0b1884b6b06b7 34060 
tor_0.2.4.20-1.diff.gz
 8a40ff3d6004fbbc48d2b1f22bed76745161c1d3927a6535c157ee4a39a5d37f 653636 
tor-geoipdb_0.2.4.20-1_all.deb
Checksums-Sha1: 
 f1d9f319cf913e71919b91e1598a2e00dc849409 1693 tor_0.2.4.20-1.dsc
 09ba4eda9a73c46852a277b721ed74c8263e8dba 2867180 tor_0.2.4.20.orig.tar.gz
 80c58b3d039febccab3014da53f748452e107a09 34060 tor_0.2.4.20-1.diff.gz
 f07ec168806cc2ec1b95c2f521a6fff229042a3e 653636 tor-geoipdb_0.2.4.20-1_all.deb
Files: 
 ee89ec62081d5bafe4e6811c25313389 1693 net optional tor_0.2.4.20-1.dsc
 a8cd8e3b3a3f6a7770f2c22d280f19b8 2867180 net optional tor_0.2.4.20.orig.tar.gz
 49fb9eed760fe493ac51f75aa834fa8f 34060 net optional tor_0.2.4.20-1.diff.gz
 63f08b7c01e1facc0c1c96f7597595bd 653636 net extra 
tor-geoipdb_0.2.4.20-1_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iQEcBAEBAgAGBQJSvFJcAAoJEDTSCgbh3sV3SxgIAIYwLAIMDfheTwzMQshR7cGz
CD9o+rVRZBs0hjsoUvogbzV8uFfFO1si6Ln6+DvLhTYkUzMXdTHngyHp9ZKmI5Hv
IBRqGD6yH7RB1trVOFxO3e33Ivv+2LjnDt4BzgA5JWZNQTv7cdKM1aJT5AmepU/Q
MlBuikvs4/7S9ET24r7TQUypDJe/qXES1XL8CMCzLMw9bB1YlGLhkLOYhSFu+loZ
cRDsiPq1muJ8ec2w6JKZAPgJw1WxeNY8dGHFvjfHCMqiXYHodjSuxMOIAxHq4WnS
Fa6D9AvgQWVKIiCConRjyT3zyCUpr4FUgVkuZlkUPh63deKBFqvgn7TODn7Ctiw=
=C1ir
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to