Your message dated Tue, 7 Jan 2014 16:46:06 +1030
with message-id <[email protected]>
and subject line multilink with nodetach [Fixed]
has caused the Debian Bug report #538107,
regarding multilink with nodetach 
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
538107: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=538107
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ppp
Version: 2.4.4rel-10.1
Severity: minor If pppd is used with l2tpd (nodetach) in a multilink situation then this feature of pppd causes problems

      MULTILINK
If the first link terminates (for example, because of a hangup or a received LCP terminate-request) the bundle is not destroyed unless there are no other links remaining in the bundle. Rather than exiting, the first pppd keeps running after its link terminates, until all the
      links in the bundle have terminated.

pppd remains connected to l2tpd even though it is just acting as a multilink master, causing l2tpd to belive the pppd is connected... i have resolved the issue in my own system by instructing pppd to detach from the terminal after it changes to PHASE_MASTER i have been using this patch since 2009-02-19 in our production systems and havent had any problems

The "if (!detached)" call is redundant since the detach function already checks if the process is detached so can be optionally excluded

i have noticed other people complaining of similar issues when using multilink/nodetach in other setups (eg pppoe) I believe that this patch may also solve the problem for them, but i have not tested that setup

-----
(auth.c)@(void link_terminated(unit))

  if (doing_multilink && multilink_master) {
       if (!bundle_terminating)
           new_phase(PHASE_MASTER);
+++            if (!detached)
+++                detach();
       else
           mp_bundle_terminated();
   } else
       new_phase(PHASE_DEAD);
-----

feedback is appreciated :)

Regards

Stephen




--- End Message ---
--- Begin Message ---
Version: 2.4.5+git20130610-1

Hi,

This bug has been resolved in upstream git, and the version in jessie
2.4.5+git20130610-1 includes the fix.

Regards,

Stephen

commit 398ed2585640d198c53e736ee5bbd67f7ce8168e
Author: Paul Mackerras <[email protected]>
Date:   Sat Mar 2 20:25:28 2013 +1100

    pppd: Add master_detach option

    This adds a new option, master_detach, to allow pppd to detach from
    the controlling terminal when it is the multilink bundle master but
    its own link has terminated, even if the nodetach option has been
    given.

    Requested-by: Stephen Marron <[email protected]>
    Signed-off-by: Paul Mackerras <[email protected]>

--- End Message ---

Reply via email to