Your message dated Sat, 25 Jan 2014 18:33:21 +0000
with message-id <[email protected]>
and subject line Bug#736634: fixed in c-icap-modules 1:0.3.2-1
has caused the Debian Bug report #736634,
regarding c-icap-modules: run dh-autoreconf to update
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
736634: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=736634
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: c-icap-modules
Version: 1:0.3.1-2
Severity: important
Tags: patch
User: [email protected]
Usertags: origin-ubuntu trusty ubuntu-patch
In Ubuntu, the attached patch was applied to achieve the following:
* 0002-Implicit-declaration.patch: Replace strcasestr() with ci_strcasestr()
* debian/{control,rules}: Builddep on and use dh-autoreconf for new ports.
Due to a thinko in virus_scan_vir.c, it ends up implicitly declaring
strcasestr(), when it should have used the wrapped ci_strcasestr(). The
attached path fixes this.
While you're at it, you may as well take the other part of the patch,
which adds dh-autoreconf, and future-proofs your package for new ports,
such as ppc64el.
... Adam
-- System Information:
Debian Release: wheezy/sid
APT prefers trusty-updates
APT policy: (500, 'trusty-updates'), (500, 'trusty-security'), (500,
'trusty'), (500, 'saucy-updates')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.13.0-0-generic (SMP w/4 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru c-icap-modules-0.3.1/debian/changelog c-icap-modules-0.3.1/debian/changelog
diff -Nru c-icap-modules-0.3.1/debian/control c-icap-modules-0.3.1/debian/control
--- c-icap-modules-0.3.1/debian/control 2013-12-21 02:37:38.000000000 -0700
+++ c-icap-modules-0.3.1/debian/control 2013-12-21 14:11:28.000000000 -0700
@@ -3,7 +3,7 @@
Priority: extra
Maintainer: Tim Weippert <[email protected]>
Uploaders: Jochen Friedrich <[email protected]>, Mathieu Parent <[email protected]>
-Build-Depends: debhelper (>= 9~), autotools-dev, libicapapi-dev (>=1:0.3.1~), libclamav-dev, libltdl-dev | libltdl3-dev, libdb-dev
+Build-Depends: debhelper (>= 9~), autotools-dev, libicapapi-dev (>=1:0.3.1~), libclamav-dev, libltdl-dev | libltdl3-dev, libdb-dev, dh-autoreconf
Standards-Version: 3.9.4
Homepage: http://c-icap.sourceforge.net/
diff -Nru c-icap-modules-0.3.1/debian/patches/0002-Implicit-declaration.patch c-icap-modules-0.3.1/debian/patches/0002-Implicit-declaration.patch
--- c-icap-modules-0.3.1/debian/patches/0002-Implicit-declaration.patch 1969-12-31 17:00:00.000000000 -0700
+++ c-icap-modules-0.3.1/debian/patches/0002-Implicit-declaration.patch 2013-12-21 13:51:56.000000000 -0700
@@ -0,0 +1,14 @@
+Description: Use ci_strcasestr() instead of strcasestr()
+Author: Adam Conrad <[email protected]>
+
+--- c-icap-modules-0.3.1.orig/services/virus_scan/virus_scan_vir.c
++++ c-icap-modules-0.3.1/services/virus_scan/virus_scan_vir.c
+@@ -197,7 +197,7 @@
+ int namelen;
+
+ content_disposition = ci_http_response_get_header(req, "Content-Disposition");
+- if (content_disposition && (filename = strcasestr(content_disposition, "filename="))) {
++ if (content_disposition && (filename = ci_strcasestr(content_disposition, "filename="))) {
+ filename = filename + 9;
+ if ((str = strrchr(filename, '/'))) {
+ filename = str + 1;
diff -Nru c-icap-modules-0.3.1/debian/patches/series c-icap-modules-0.3.1/debian/patches/series
--- c-icap-modules-0.3.1/debian/patches/series 2013-12-21 02:37:38.000000000 -0700
+++ c-icap-modules-0.3.1/debian/patches/series 2013-12-21 12:30:36.000000000 -0700
@@ -1 +1,2 @@
0001-Fix-manpage.patch
+0002-Implicit-declaration.patch
diff -Nru c-icap-modules-0.3.1/debian/rules c-icap-modules-0.3.1/debian/rules
--- c-icap-modules-0.3.1/debian/rules 2013-12-21 02:37:38.000000000 -0700
+++ c-icap-modules-0.3.1/debian/rules 2013-12-21 12:41:32.000000000 -0700
@@ -10,7 +10,7 @@
export DEB_BUILD_MAINT_OPTIONS := hardening=+bindnow
%:
- dh $@
+ dh $@ --with autoreconf
override_dh_auto_configure:
dh_auto_configure -- \
--- End Message ---
--- Begin Message ---
Source: c-icap-modules
Source-Version: 1:0.3.2-1
We believe that the bug you reported is fixed in the latest version of
c-icap-modules, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Mathieu Parent <[email protected]> (supplier of updated c-icap-modules package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 25 Jan 2014 19:10:27 +0100
Source: c-icap-modules
Binary: libc-icap-mod-virus-scan libc-icap-mod-clamav libc-icap-mod-urlcheck
Architecture: source i386 all
Version: 1:0.3.2-1
Distribution: unstable
Urgency: medium
Maintainer: Tim Weippert <[email protected]>
Changed-By: Mathieu Parent <[email protected]>
Description:
libc-icap-mod-clamav - transitional dummy package
libc-icap-mod-urlcheck - URL Check Service for c-icap
libc-icap-mod-virus-scan - Antivirus Service for c-icap
Closes: 732801 736634
Changes:
c-icap-modules (1:0.3.2-1) unstable; urgency=medium
.
* New upstream release
* Updated Standards-Version to 3.9.5 - no change
* Use dh-autoreconf (Closes: #736634)
* Use ci_strcasestr() instead of strcasestr() (Closes: #732801)
Checksums-Sha1:
652ce55f168d14fa2f5685d3a1e598f5c132046d 1440 c-icap-modules_0.3.2-1.dsc
98dd7b3bf40b8831e297ffa8c4e1eaf7cef57cd0 384788
c-icap-modules_0.3.2.orig.tar.gz
88fa1fa48da711a11092a510f6a3957cce72a8b2 4440
c-icap-modules_0.3.2-1.debian.tar.xz
5972d1414d3280f4a6daec3aa25da0bcc7dccfb8 22772
libc-icap-mod-virus-scan_0.3.2-1_i386.deb
24421466274345e7242f5af349bdd1b9f775a2d1 3252
libc-icap-mod-clamav_0.3.2-1_all.deb
f89dc3e8e41024c6a7b264122fe2608dc184d46e 26016
libc-icap-mod-urlcheck_0.3.2-1_i386.deb
Checksums-Sha256:
1b3652e047363b1ea8ff6f8518b71e88518da53e5f130fd0b555477db476a13b 1440
c-icap-modules_0.3.2-1.dsc
e3472662687cf9fa37a496df31436924326e315920056a404f023ec5e852e239 384788
c-icap-modules_0.3.2.orig.tar.gz
2d92c31aebadb4fcd57dad21c6071d564492afe79bea6a658f7f4e00806f06b2 4440
c-icap-modules_0.3.2-1.debian.tar.xz
eee8958baddbe8dccb95d0bb0e46723153d86417ca8579920300d4119c8033a5 22772
libc-icap-mod-virus-scan_0.3.2-1_i386.deb
ef19d30aeedf03b4c494794cf0ce50552f1c2c5a982f07526cbf82744f9b8c7b 3252
libc-icap-mod-clamav_0.3.2-1_all.deb
dfe1b84643707a4b7765d954bcab3ba8706baedf6793ae44356408d309b32f7d 26016
libc-icap-mod-urlcheck_0.3.2-1_i386.deb
Files:
5d1167316ff47a00fc219ffbec8bacf3 1440 net extra c-icap-modules_0.3.2-1.dsc
25a904f98cddbcc7431b22720cd3996e 384788 net extra
c-icap-modules_0.3.2.orig.tar.gz
67a1fff2e2e8da73a1be859e852db3c7 4440 net extra
c-icap-modules_0.3.2-1.debian.tar.xz
7ffa1b2ac52fad550d4b84be6e0a22f2 22772 net extra
libc-icap-mod-virus-scan_0.3.2-1_i386.deb
13dc7e64d16d63ec6c639800e56ae974 3252 oldlibs extra
libc-icap-mod-clamav_0.3.2-1_all.deb
8c9c62d73c77aff20e724613db6ce12a 26016 net extra
libc-icap-mod-urlcheck_0.3.2-1_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlLj/3kACgkQOW2jYf5fHX9DCQCeJWn9023/+naT8pGATFw6MV5V
2mwAn3R4nerp0Jh4Br9/uwxFgnBc1qTM
=pMFO
-----END PGP SIGNATURE-----
--- End Message ---
