Your message dated Mon, 03 Feb 2014 00:18:25 +0000
with message-id <[email protected]>
and subject line Bug#448441: fixed in emacs-goodies-el 35.11
has caused the Debian Bug report #448441,
regarding gnus-bonus-el: gnus-pers does not work properly with no default
personality
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
448441: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=448441
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gnus-bonus-el
Version: 28.3-1
Severity: normal
Tags: patch
When using gnus-pers without a default personality, the prompting
doesn't use completing-read which is inconvenient, and it sometimes
adds duplicate "From:" lines. The code for the no default, and
default cases are a crufty cut and paste job of nearly identical code.
My patch restructures the code slightly to obviate the need for these
duplicate sections (which also fixes the problems with the duplicate
From: lines), and uses completing-read for the prompting.
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.22-2-686 (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Versions of packages gnus-bonus-el depends on:
ii emacs21 [emacsen] 21.4a+1-5.1 The GNU Emacs editor
ii emacs22 [emacsen] 22.1+1-2 The GNU Emacs editor
ii gnus 5.11+v0.5.dfsg-3 A versatile news and mail reader f
gnus-bonus-el recommends no packages.
-- no debconf information
--- /usr/share/emacs/site-lisp/gnus-bonus-el/gnus-pers.el 2007-10-23 20:33:22.000000000 -0400
+++ software/src/gnus-pers.el 2007-10-28 23:45:24.000000000 -0400
@@ -392,9 +392,12 @@
(when tmp-pers
(setq personality tmp-pers))))
+ (setq personality (or personality
+ (and (assoc "default" gnus-personalities) "default")
+ (completing-read "Personality: " gnus-personalities nil 1)))
- (if (or personality (assoc "default" gnus-personalities))
- (let* ((values (assoc (or personality "default") gnus-personalities))
+
+ (let* ((values (assoc personality gnus-personalities))
(foo1 (cdr values))
(fromfoo (car foo1))
(from (cond
@@ -437,10 +440,6 @@
((listp signaturesfoo)
(eval signaturesfoo))
)))
-
- ; (from (cdr (assoc 'from values)))
- ; (extras (cdr (assoc 'extras values)))
- ; (signature (cdr (assoc 'signature values))))
(progn
(if (and (not personality) (assoc "default" gnus-personalities))
(let ((personality "default"))
@@ -535,145 +534,7 @@
(search-forward mail-header-separator)
(forward-line 1)
(beginning-of-line)
- )
- )
-
-
-
-
- (let* ( (personality (gnus-personality-prompt))
- (values (assoc personality gnus-personalities))
- ; (from (cdr (assoc 'from values)))
- ; (extras (cdr (assoc 'extras values)))
- ; (signature (cdr (assoc 'signature values))))
- (foo1 (cdr values))
- (fromfoo (car foo1))
- (from (cond
- ((stringp fromfoo)
- fromfoo)
- ((or (symbolp fromfoo)
- (functionp fromfoo))
- (cond ((functionp fromfoo)
- (funcall fromfoo))
- ((boundp fromfoo)
- (symbol-value fromfoo))))
- ((listp fromfoo)
- (eval fromfoo))
))
- (foo (cdr foo1))
- (extrasfoo (car foo))
- (extras (cond
- ((stringp extrasfoo)
- extrasfoo)
- ((or (symbolp extrasfoo)
- (functionp extrasfoo))
- (cond ((functionp extrasfoo)
- (funcall extrasfoo))
- ((boundp extrasfoo)
- (symbol-value extrasfoo))))
- ((listp extrasfoo)
- (eval extrasfoo))
- ))
- (foo2 (cdr foo))
- (signaturesfoo (car foo2))
- (signature (cond
- ((stringp signaturesfoo)
- signaturesfoo)
- ((or (symbolp signaturesfoo)
- (functionp signaturesfoo))
- (cond ((functionp signaturesfoo)
- (funcall signaturesfoo))
- ((boundp signaturesfoo)
- (symbol-value signaturesfoo))))
- ((listp signaturesfoo)
- (eval signaturesfoo))
- )))
- (progn
- ; Set up the last-personality in case we change them:
- (setq gnus-personality-last-used personality)
- ;Let's do From: first.
- (if (and from (not (equal from "")))
- (progn
- (let ((endpos (search-forward mail-header-separator)))
- (goto-char (point-min))
- (if (re-search-forward "From:" endpos t)
- (progn
- (beginning-of-line)
- (let ((beg (point)))
- (end-of-line)
- (delete-region beg (point))
- )
- (insert (concat
- "From: "
- from
- )
- )
- )
- (progn
- (goto-char (point-min))
- (insert (concat
- "From: "
- from
- "\n"
- )
- )
- )
- ))))
- (if gnus-pers-cc-fix
- ; Now we have a problem with Cc when doing a followup. So let's check the Cc field and see if from is there:
- (save-excursion
- (save-restriction
- (message-narrow-to-head)
- (let ((case-fold-search t)
- (rmail-dont-reply-to-names
- (regexp-quote
- (cadr (gnus-extract-address-components from))))
- (cc (message-fetch-field "cc")))
- (when (and cc
- (string-match rmail-dont-reply-to-names cc))
- (message-remove-header "cc")
- (widen)
- (unless (string= "" (setq cc (rmail-dont-reply-to cc)))
- (message-goto-cc)
- (insert cc)))
-
- )
- )
- )
-)
-
- ; Now the extra headers
- (if (and extras (not (equal extras "")))
- (progn
- (goto-char (point-min))
- (search-forward mail-header-separator)
- (forward-line -1)
- (end-of-line)
- (insert (concat
- "\n"
- extras
- )
- )
-
- )
-
- )
- ; Now the signature
- (if (and signature (not (equal signature "")))
- (let ((oldsig message-signature)
- (oldsigfile message-signature-file))
- (cond ((file-exists-p signature)
- (setq message-signature-file signature))
- (t
- (setq message-signature signature)))
- (gnus-pers-insert-signature)
- (setq message-signature oldsig)
- (setq message-signature-file oldsigfile))
-
-)
- )
- )
- )
; buttonize from now that we're done
(gnus-personality-buttonize-from)
--- End Message ---
--- Begin Message ---
Source: emacs-goodies-el
Source-Version: 35.11
We believe that the bug you reported is fixed in the latest version of
emacs-goodies-el, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Julian Gilbey <[email protected]> (supplier of updated emacs-goodies-el package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Mon, 03 Feb 2014 00:02:53 +0000
Source: emacs-goodies-el
Binary: emacs-goodies-el devscripts-el debian-el dpkg-dev-el
Architecture: source all
Version: 35.11
Distribution: unstable
Urgency: medium
Maintainer: Peter S Galbraith <[email protected]>
Changed-By: Julian Gilbey <[email protected]>
Description:
debian-el - Emacs helpers specific to Debian users
devscripts-el - Emacs wrappers for the commands in devscripts
dpkg-dev-el - Emacs helpers specific to Debian development
emacs-goodies-el - Miscellaneous add-ons for Emacs
Closes: 236919 448441 570276 597035 609698 648607 737202
Changes:
emacs-goodies-el (35.11) unstable; urgency=medium
.
* Complete dpatch -> quilt transition from 31.7 by removing dpatch code
from debian/patch/* files
* Quieten lintian warnings by removing executable bits from almost all
files
* Include make-orig.sh in source distribution (cvs-buildpackage does
this anyway)
* vm-bonus-el package removed - it's ancient and barely used anymore
* Remove gnus-bonus-el from the source package (the binary package was
removed in 35.6). This closes the bugs against it, even though they
have not been fixed (Closes: #570276, #448441, #236919, #597035,
#609698, #648607)
* Fix piuparts error with a temporary patch, until emacsen-common (or
whatever the true source of the bug is) is fixed. (Closes: #737202)
* Add emacsen compat files (in line with new policy and current
debhelper behaviour)
* Rewrite rules to use nice debhelper stuff; have explicity quilt
build-dependency
* Rewrite copyright files to use DEP-5/copyright-format-1.0
* Update Standards-Version
Checksums-Sha1:
081b092fc37a9dc57c02a80efb717f96b370bd3e 1144 emacs-goodies-el_35.11.dsc
b3e832a0a0efd502c18b597587a6ac85c03bf997 743648 emacs-goodies-el_35.11.tar.xz
6482994711b17ffaef541c91244f92b9f92e7a4f 685604 emacs-goodies-el_35.11_all.deb
b1c5b24c13a099d834fb2c9ed9630151b9756fb9 43302 devscripts-el_35.11_all.deb
202703565c50785d2a0d1228fbf297140ab4498c 94502 debian-el_35.11_all.deb
e71873ce095fa80c5de30fcf134f5fe5e5e3156c 70760 dpkg-dev-el_35.11_all.deb
Checksums-Sha256:
0213f6c09f6f4cfb060b30da94c471cf1654c33c42f756c729771414f65899e4 1144
emacs-goodies-el_35.11.dsc
c928cb438d01aa117e77766083a24ee017f1ec4bcdfcfa09da004e2af3a0f00f 743648
emacs-goodies-el_35.11.tar.xz
998392c78b2658c8d6ae7aa26bd09524f121f6683bb4cde0d008c614caab15ad 685604
emacs-goodies-el_35.11_all.deb
7f7bad00e0d1c71e1705769ad51e767a5730ed7685890d48793a5f92affb4906 43302
devscripts-el_35.11_all.deb
4cafab7f7dd532e83c98dd22987e832e604791f1e36301f52281a4e16c33c9ec 94502
debian-el_35.11_all.deb
7419b169f147a88a5b0fdf24ca7d62760e2fb15529ab173c665db9e32fac3b83 70760
dpkg-dev-el_35.11_all.deb
Files:
d564c6da0529a16da85ad19e6df945aa 1144 editors optional
emacs-goodies-el_35.11.dsc
595b2526c575b12ef92f772d5b78ef1a 743648 editors optional
emacs-goodies-el_35.11.tar.xz
e83255898d4cce19e0f7341bf0bc9f48 685604 editors optional
emacs-goodies-el_35.11_all.deb
48c092b33740dd7d51e98ddb1623501c 43302 editors optional
devscripts-el_35.11_all.deb
9b39111d1d65d7da96dcedee2f626f40 94502 utils optional debian-el_35.11_all.deb
ba3b8ebd696f9dc2efce1ddef9b6223b 70760 utils optional dpkg-dev-el_35.11_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlLu3O8ACgkQDU59w/205FmU4QCghZwtDx3l4RYtnIjVp5IGCw+K
dMkAnjGLs8f8VKaqk0orYRDvkW9oOni0
=Fkl5
-----END PGP SIGNATURE-----
--- End Message ---
