Your message dated Mon, 10 Mar 2014 05:53:02 +0000
with message-id <[email protected]>
and subject line Re: Bug#741128: libglib2.0-dev: No return values in
glib/gmessages.h
has caused the Debian Bug report #741128,
regarding libglib2.0-dev: No return values in glib/gmessages.h
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
741128: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=741128
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: libglib2.0-dev
Version: 2.0-2.38.2
Severity: minor
Tags: patch
User: [email protected]
Usertags: clang-ftbfs
Dear Maintainer,
I'm building packages with clang instead of gcc. Some packages depending on
glib fail to build with -Wreturn-type errors.
See the following log excerpt:
g_return_if_fail(widget != NULL);
^
/usr/include/glib-2.0/glib/gmessages.h:345:3: note: expanded from macro
'g_return_if_fail'
return; \
^
The attached patch *could* fix it but it has *not* been tested.
You can find a buildlog with these errors here:
https://github.com/nonas/debian-clang/blob/master/buildlogs/spectools/spectools_201108r1-3_amd64-20140308-1829.build
The package 'slashem' shows the same errors:
http://clang.debian.net/logs/2013-07-14/slashem_0.0.7E7F3-6_unstable_clang.log
Tell me if you need more info.
Hope this helps,
Nicolas
-- System Information:
Debian Release: jessie/sid
APT prefers testing-updates
APT policy: (500, 'testing-updates'), (500, 'testing')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.12-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Description: Fix return values in gmessage.h
Packages depending on glib fail to build from source with clang instead of gcc with [-Wreturn-type] errors.
This is caused by functions defined in gmessages.h that return no value.
Author: Nicolas Sévelin-Radiguet <[email protected]>
Last-Update: 2014-03-08
--- a/glib/gmessages.h
+++ b/glib/gmessages.h
@@ -342,7 +342,7 @@
g_return_if_fail_warning (G_LOG_DOMAIN, \
__PRETTY_FUNCTION__, \
#expr); \
- return; \
+ return 1; \
}; }G_STMT_END
#define g_return_val_if_fail(expr,val) G_STMT_START{ \
@@ -361,7 +361,7 @@
__FILE__, \
__LINE__, \
__PRETTY_FUNCTION__); \
- return; }G_STMT_END
+ return 1; }G_STMT_END
#define g_return_val_if_reached(val) G_STMT_START{ \
g_log (G_LOG_DOMAIN, \
@@ -383,7 +383,7 @@
__FILE__, \
__LINE__, \
#expr); \
- return; \
+ return 1; \
}; }G_STMT_END
#define g_return_val_if_fail(expr, val) G_STMT_START{ \
@@ -404,7 +404,7 @@
"file %s: line %d: should not be reached", \
__FILE__, \
__LINE__); \
- return; }G_STMT_END
+ return 1; }G_STMT_END
#define g_return_val_if_reached(val) G_STMT_START{ \
g_log (G_LOG_DOMAIN, \
--- End Message ---
--- Begin Message ---
On Sun, Mar 09, 2014 at 06:45:36PM +0100, Nicolas Sévelin-Radiguet wrote:
> Oh, I see.
> Thank you for the clarification. I was indeed able to write a patch
> using g_return_vaf_if_*.
>
> Sorry for the noise :(
OK, I'll take the liberty of closing this, then. Thanks for getting
back to us.
--
Colin Watson [[email protected]]
--- End Message ---
