Your message dated Thu, 24 Apr 2014 18:08:45 +0200
with message-id <[email protected]>
and subject line [alacarte] erroneous selection handling below separator items
has caused the Debian Bug report #562013,
regarding [alacarte] erroneous selection handling below separator items
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
562013: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=562013
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: alacarte
Version: 0.12.4-1
Severity: normal
Tags: patch
--- Please enter the report below this line. ---
Hi,
the selection marker on the right pane of alacarte acts weirdly, if there is a
separator item above.
How to reproduce:
1) add a separator
2) select the next item below
3) click on the "move down" button on the right side
The selected item moves as expected. But afterwards the previous item is
selected (instead of the moved one).
This does not happen in lists without a separator item.
The attached patch fixes this issue.
thanks for your work,
Lars
--- System information. ---
Architecture: i386
Kernel: Linux 2.6.30-2-686
Debian Release: squeeze/sid
990 testing localhost
--- Package information. ---
Depends (Version) | Installed
===============================-+-=============
python (>= 2.4) | 2.5.4-2
python-support (>= 0.90.0) | 1.0.6
python-gtk2 (>= 2.13.0) | 2.16.0-1
python-gmenu (>= 2.27.92) | 2.28.0.1-1
gnome-menus (>= 2.27.92) | 2.28.0.1-1
python-gobject (>= 2.15.1) | 2.20.0-1
Recommends (Version) | Installed
==========================-+-===========
gnome-panel | 2.28.0-3
Package's Suggests field is empty.
--
gpg key: https://systemausfall.org/schluessel/lars-devel.0.asc
diff -ruN Alacarte.orig/MainWindow.py Alacarte/MainWindow.py
--- Alacarte.orig/MainWindow.py 2009-12-21 22:59:55.000000000 +0100
+++ Alacarte/MainWindow.py 2009-12-22 00:02:32.000000000 +0100
@@ -128,6 +128,8 @@
found = True
if item[3].get_type() == gmenu.TYPE_SEPARATOR:
if not isinstance(item_id, tuple):
+ #we may not skip the increment via "continue"
+ i += 1
continue
#separators have no id, have to find them manually
#probably won't work with two separators together
signature.asc
Description: PGP signature
--- End Message ---
--- Begin Message ---
fixed 562013 alacarte/0.13.4-1
stop
See commit:
https://git.gnome.org/browse/alacarte/commit/?id=7c6a18c8a5170c5abc77f8bace1313578fec0d48
--
Stéphane Aulery
--- End Message ---
