Your message dated Sun, 18 May 2014 12:12:04 +0200
with message-id <[email protected]>
and subject line Re: Bug#748384: quilt graph missing from quilt(1) man page
has caused the Debian Bug report #748384,
regarding quilt graph missing from quilt(1) man page
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
748384: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=748384
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: quilt
Version: 0.60-9
Severity: minor
The installed man page for quilt(1) does not contain a description of
the 'graph' subcommand. Instead, it contains this message:
It seems that graphviz is currently not installed (unable to
find
the tred binary). You must install it to use 'quilt graph'.
This is true even on systems where graphviz is installed.
In order to resolve #659944, quilt graph now tests for the existence
of /usr/bin/tred and, if that program is not found, prints a friendly
error message and exits. This happens fairly early; in particular, it
happens before parsing options or printing a usage message. Thus,
running 'quilt graph -h' on a machine without graphviz installed will
print the error message rather than a usage message for 'quilt graph'.
Unfortunately, the build-time process which constructs both the
installed README file and the man page depends on running each
subcommand to obtain its usage message. As a result, since the change
in #659944, if quilt is built on a system on which graphviz is not
installed, the resulting man page contains the error message in place of
documentation on quilt graph.
The simplest solution would be to add graphviz to quilt's Build-Depends.
However, it might be more appropriate to move the check to a point later
in the script, after options processing, so that the usage message can
be printed even if graphviz is not installed.
-- Jeffrey T. Hutzelman (N3NHS) <[email protected]>
Sr. Research Systems Programmer
School of Computer Science - Research Computing Facility
Carnegie Mellon University - Pittsburgh, PA
--- End Message ---
--- Begin Message ---
Package: quilt
fixed 748384 0.63-2
thanks
On Fri, May 16, 2014 at 02:39:44PM -0400, Jeffrey Hutzelman wrote:
> Package: quilt
> Version: 0.60-9
> Severity: minor
>
> The installed man page for quilt(1) does not contain a description of
> the 'graph' subcommand. Instead, it contains this message:
>
> It seems that graphviz is currently not installed (unable to
> find
> the tred binary). You must install it to use 'quilt graph'.
>
> This is true even on systems where graphviz is installed.
>
>
> In order to resolve #659944, quilt graph now tests for the existence
> of /usr/bin/tred and, if that program is not found, prints a friendly
> error message and exits. This happens fairly early; in particular, it
> happens before parsing options or printing a usage message. Thus,
> running 'quilt graph -h' on a machine without graphviz installed will
> print the error message rather than a usage message for 'quilt graph'.
>
> Unfortunately, the build-time process which constructs both the
> installed README file and the man page depends on running each
> subcommand to obtain its usage message. As a result, since the change
> in #659944, if quilt is built on a system on which graphviz is not
> installed, the resulting man page contains the error message in place of
> documentation on quilt graph.
>
>
> The simplest solution would be to add graphviz to quilt's Build-Depends.
> However, it might be more appropriate to move the check to a point later
> in the script, after options processing, so that the usage message can
> be printed even if graphviz is not installed.
I changed the check on graphviz for that exactly. Actually, I didn't
see that the documentation was broken (thanks for the report), but
some parts of the graph command can be used without graphviz, so I
refined the checks:
http://anonscm.debian.org/gitweb/?p=collab-maint/quilt.git;a=blob;f=debian/patches/graph_depends_on_graphviz
This patch was already updated in version 0.63-2, so closing the bug.
Thanks for the report -- feel free to reopen on need.
Bye, Mt.
--
Let's call it an accidental feature. -- Larry Wall
signature.asc
Description: Digital signature
--- End Message ---
