Your message dated Tue, 27 May 2014 21:11:36 +1000
with message-id <[email protected]>
and subject line Fixed in 0.3.2-1
has caused the Debian Bug report #601613,
regarding gjay --analyze-standalone segfaults if audio decoder not found
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
601613: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=601613
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: gjay
Version: 0.3.1-2
Severity: important
Tags: patch

gjay only Suggests: vorbis-tools.  but when ogg123 is not in the path,
gjay dies with a segfault when trying to decode an ogg file:

0 dkg@pip:~$ gjay --analyze-standalone foo.ogg
Segmentation fault
139 dkg@pip:~$

The attached patch should avoid the segmentation fault (though it
makes it terminate immediately with return code 0, printing no error
messages unless you set the verbose flag, so i am not sure if it's all
that much better).

Regards,

        --dkg

-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing'), (200, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.36-rc6-686 (SMP w/1 CPU core)
Locale: LANG=en_US.utf8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages gjay depends on:
ii  audacious              2.3-2             small and fast audio player which 
ii  libatk1.0-0            1.30.0-1          The ATK accessibility toolkit
ii  libaudclient2          2.3-2             audacious dbus remote control libr
ii  libc6                  2.11.2-6+squeeze1 Embedded GNU C Library: Shared lib
ii  libcairo2              1.8.10-6          The Cairo 2D vector graphics libra
ii  libdbus-1-3            1.2.24-3          simple interprocess messaging syst
ii  libdbus-glib-1-2       0.88-2            simple interprocess messaging syst
ii  libfontconfig1         2.8.0-2.1         generic font configuration library
ii  libfreetype6           2.4.2-1           FreeType 2 font engine, shared lib
ii  libglib2.0-0           2.24.2-1          The GLib library of C routines
ii  libgsl0ldbl            1.14+dfsg-1       GNU Scientific Library (GSL) -- li
ii  libgtk2.0-0            2.20.1-2          The GTK+ graphical user interface 
ii  libpango1.0-0          1.28.1-1          Layout and rendering of internatio
ii  mpg321 [mpg123]        0.2.12-1          Simple and lighweight command line

gjay recommends no packages.

Versions of packages gjay suggests:
pn  vorbis-tools                  <none>     (no description available)

-- no debconf information
--- a/analysis.c        2010-10-27 15:38:37.000000000 -0400
+++ b/analysis.c        2010-10-27 15:39:58.000000000 -0400
@@ -379,6 +379,12 @@
     send_ipc_text(daemon_pipe_fd, ANIMATE_START, analyze_song->path);
 
     f = inflate_to_wav(fname, type);
+    if (f == NULL) {
+        if (verbosity)
+          g_warning(_("Failed to decompress '%s'.\n"),fname);
+        in_analysis = FALSE;
+        return;
+    }      
     memset(&wsfile, 0x00, sizeof(wav_file));
     wsfile.f = f;
     fread(&wsfile.header, sizeof(waveheaderstruct), 1, f);

--- End Message ---
--- Begin Message ---
Package: gjay
Version: 0.3.2-1

The changelog had the wrong bug number, but upstream version 0.3.2
has this fixed.
-- 
Craig Small (@smallsees)   http://enc.com.au/       csmall at : enc.com.au
Debian GNU/Linux           http://www.debian.org/   csmall at : debian.org
GPG fingerprint:        5D2F B320 B825 D939 04D2  0519 3938 F96B DF50 FEA5

--- End Message ---

Reply via email to