Your message dated Mon, 09 Jun 2014 19:04:02 +0000
with message-id <[email protected]>
and subject line Bug#746390: fixed in ruby-kgio 2.9.2-2
has caused the Debian Bug report #746390,
regarding ruby-kgio: FTBFS (ppc64el): test_default_wait(TestDefaultWait) page 
size assumptions too small for 64K page size architectures
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
746390: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=746390
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: ruby-kgio
Version: 2.9.2-1
Severity: normal
Tags: patch
User: [email protected]
Usertags: origin-ubuntu utopic ubuntu-patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * d/p/fix-test-test_default_wait: fix up bad assumption in test that
    reading 16K is sufficient to open write space in a pipe.  Also add
    commentary to the test for the next person who hits this.

This fixes an FTBFS on ppc64el (and any other linux architecture with
page sizes above 16KB.

Thanks for considering the patch.

-apw

-- System Information:
Debian Release: jessie/sid
  APT prefers trusty-updates
  APT policy: (500, 'trusty-updates'), (500, 'trusty-security'), (500, 
'trusty'), (100, 'trusty-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.13.0-25-generic (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru ruby-kgio-2.9.2/debian/changelog ruby-kgio-2.9.2/debian/changelog
diff -Nru ruby-kgio-2.9.2/debian/patches/fix-test-test_default_wait ruby-kgio-2.9.2/debian/patches/fix-test-test_default_wait
--- ruby-kgio-2.9.2/debian/patches/fix-test-test_default_wait	1970-01-01 01:00:00.000000000 +0100
+++ ruby-kgio-2.9.2/debian/patches/fix-test-test_default_wait	2014-04-29 15:21:57.000000000 +0100
@@ -0,0 +1,27 @@
+Description: fix test to take account of larger page sizes on ppc64el
+ The test_default_wait/TestDefaultWait test assume that a single read
+ can definatly switch a "full" pipe to one which will poll writable.  The
+ kernel optimises for IO size by delaying the writable status until a
+ complete buffer slot is available; these are the system page.  The test
+ already exhibits this by using large IOs compared to the common 4K page
+ size, but this is not sufficient in the face of the 64K page sizes on
+ ppc64el.  Up this to 64k which represents the biggest page size available
+ in the kernel.
+Author: Andy Whitcroft <[email protected]>
+Last-Update: 2014-04-29
+
+--- ruby-kgio-2.9.2.orig/test/test_default_wait.rb
++++ ruby-kgio-2.9.2/test/test_default_wait.rb
+@@ -39,7 +39,11 @@ class TestDefaultWait < Test::Unit::Test
+     diff = Time.now - t0
+     assert_in_delta diff, 1.1, 0.2
+ 
+-    a.kgio_read(16384)
++    # Read enough to ensure one kernel buffer is cleared
++    # to ensure that poll et al will start saying we have
++    # enough space to allow a write.  This should be at
++    # least the largest system page size we support.
++    a.kgio_read(65536)
+     assert_equal b, b.kgio_wait_writable(1.1)
+   end
+ end
diff -Nru ruby-kgio-2.9.2/debian/patches/series ruby-kgio-2.9.2/debian/patches/series
--- ruby-kgio-2.9.2/debian/patches/series	2014-04-09 21:11:14.000000000 +0100
+++ ruby-kgio-2.9.2/debian/patches/series	2014-04-29 15:16:37.000000000 +0100
@@ -1 +1,2 @@
 fix-test
+fix-test-test_default_wait

--- End Message ---
--- Begin Message ---
Source: ruby-kgio
Source-Version: 2.9.2-2

We believe that the bug you reported is fixed in the latest version of
ruby-kgio, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Hleb Valoshka <[email protected]> (supplier of updated ruby-kgio package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Sat, 31 May 2014 21:35:09 +0300
Source: ruby-kgio
Binary: ruby-kgio
Architecture: source amd64
Version: 2.9.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Ruby Extras Maintainers 
<[email protected]>
Changed-By: Hleb Valoshka <[email protected]>
Description:
 ruby-kgio  - Kinder, gentler I/O for Ruby
Closes: 746390
Changes:
 ruby-kgio (2.9.2-2) unstable; urgency=medium
 .
   * Add patch from Ubuntu to fix test failure on ppc64el (Closes: #746390).
   * Rebuild against newer gem2deb (adds gemspec for all interpreters, current
     and future)
Checksums-Sha1:
 0e2b47e535165eef7a160ecb0379285a98767e54 2021 ruby-kgio_2.9.2-2.dsc
 ddd04d6ce3f272b0c192b2f6337d21e2d4ef29ac 3780 ruby-kgio_2.9.2-2.debian.tar.xz
 c120b3c596dc892cb9ebd27f81fd517e8fca55bc 53942 ruby-kgio_2.9.2-2_amd64.deb
Checksums-Sha256:
 1198312abcbcbcc232a944ec1bb180955c52d24b7361009885686b648a7d9aa5 2021 
ruby-kgio_2.9.2-2.dsc
 cb57cf20bff9bb88129fe6f2dd8f97f41cad7e8cbc08b732490fdbd4fd69e303 3780 
ruby-kgio_2.9.2-2.debian.tar.xz
 d15fbe680fcec7180ead02003ea422ddc70ecac76394a2fb0af12fce1686b70b 53942 
ruby-kgio_2.9.2-2_amd64.deb
Files:
 5e16a82e8b0bc09fe9d965b0c0eaecbe 53942 ruby optional 
ruby-kgio_2.9.2-2_amd64.deb
 3a71ed7fe3cf311f4baca72110d683b6 2021 ruby optional ruby-kgio_2.9.2-2.dsc
 068d83c716d6cb70a093c98d71550362 3780 ruby optional 
ruby-kgio_2.9.2-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCAAGBQJTlgC2AAoJEFwT1tuTBS4DDb8P/0OFAiBE7X67sTdckp2g9zjN
UZkZ4VhnywWF4/wezsaVQQQ3Cfun4QGRpQAPu11a6bAxltyKm9nrcCxdA58SShJm
q3oqwvniz5h4C5JaWTBzSftZ833OuCJh9ID/rX1/pXHrpge41jCZFlYSZy2Ui+eU
5krfP4bGl/yz6sKz8IOTWdHJgvrX+5q97pqo5buArFTZSxUei7azFnIi2+HE4A/v
BrSFt75TQZpyy3QFzvMlwBa5TP6WZn4Az6BMf/WK1eKng/Rrcd20lGNf4gyuKnKk
WyMfpUGokKyT5/fJBia+HU+jIsfaobk0X/JoI+Gs6X99ECqdvz9p18jWZuBwMdj+
lNo0rQJIbzuFMU1qtw19vR3fv/u33JE0LmaWs9aEDXDxqvrSdkJm8qo9dhT3n9AY
O3m8yac5BY0AHzZ4gUnN3odjRrafAv+QoeFnJH1r7Fefu+jtNiNnX0zU2maV48hh
SAy7oE4imlHPChSDPTaYrWYNErOKF0PFNIR4CQ8xgPW1EEssPiPvpbVBcf6z8laE
Da6N7PsuShXFKfp720a9YfLi8c2BcrutJuP3W5yMncYMx06stZJYaERw791R6PJt
s/shygLaGj5thvIZM3j2LiZPrsi7EKxubFx2TCWKh20P/sHyDiGQC30a37BohiFS
pJqng9Qs60dgIu4GDGqn
=Qzvk
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to