Your message dated Tue, 10 Jun 2014 09:53:11 +0000
with message-id <[email protected]>
and subject line Bug#750985: fixed in libraw 0.16.0-5
has caused the Debian Bug report #750985,
regarding broken autopkgtest
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
750985: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=750985
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libraw
Version: 0.16.0-4
Tags: patch
User: [email protected]
Usertags: origin-ubuntu ubuntu-patch utopic
User: [email protected]
Usertags: autopkgtest
Hello,
thanks for adding an autopkgtest to libraw! However, it has several
problems:
- It fails with "test.c:1:27: fatal error: libraw/libraw.h: No such
file or directory" [1] as the test doesn't depend on libraw-dev
- The test doesn't need @builddeps@. libraw-dev ought to depend on
anything that it needs by itself, that's the point of having an
autopkgtest :)
- The test is not set -e and thus continues after the failed
compilation (also visible in [1])
- The linking order is wrong and doesn't work with --as-needed /
binutils-gold (see [2] for details).
The attached patch fixes everything. Tested with
adt-run -B libraw_0.16.0-4ubuntu1.dsc --- schroot utopic
Thanks for considering,
Martin
[1]
https://jenkins.qa.ubuntu.com/job/utopic-adt-libraw/1/ARCH=i386,label=adt/console
[2] https://wiki.debian.org/ToolChain/DSOLinking
--
Martin Pitt | http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
diff -Nru libraw-0.16.0/debian/changelog libraw-0.16.0/debian/changelog
--- libraw-0.16.0/debian/changelog 2014-06-07 18:44:21.000000000 +0200
+++ libraw-0.16.0/debian/changelog 2014-06-09 11:41:17.000000000 +0200
@@ -1,3 +1,11 @@
+libraw (0.16.0-4ubuntu1) utopic; urgency=medium
+
+ * Fix autopkgtest: Add missing libraw-dev test dep, drop unnecessary
+ @builddeps@, and add missing "set -e" so that the test actually fails
+ properly. Also fix linking order to also work with binutils-gold.
+
+ -- Martin Pitt <[email protected]> Mon, 09 Jun 2014 11:38:59 +0200
+
libraw (0.16.0-4) unstable; urgency=medium
* debian/libraw10.symbols:
diff -Nru libraw-0.16.0/debian/tests/control libraw-0.16.0/debian/tests/control
--- libraw-0.16.0/debian/tests/control 2014-06-07 18:20:40.000000000 +0200
+++ libraw-0.16.0/debian/tests/control 2014-06-09 11:38:28.000000000 +0200
@@ -1,3 +1,3 @@
Tests: testbuild
-Depends: @builddeps@,
+Depends: libraw-dev,
build-essential
diff -Nru libraw-0.16.0/debian/tests/testbuild
libraw-0.16.0/debian/tests/testbuild
--- libraw-0.16.0/debian/tests/testbuild 2014-06-07 18:26:14.000000000
+0200
+++ libraw-0.16.0/debian/tests/testbuild 2014-06-09 11:40:48.000000000
+0200
@@ -1,4 +1,5 @@
#!/bin/sh
+set -e
cd "$ADTTMP"
cat > test.c << EOF
@@ -14,6 +15,6 @@
}
EOF
-g++ -Wall -Wl,-lraw -o test test.c
+g++ -Wall -o test test.c -lraw
./test
objdump -p test | grep "libraw"
signature.asc
Description: Digital signature
--- End Message ---
--- Begin Message ---
Source: libraw
Source-Version: 0.16.0-5
We believe that the bug you reported is fixed in the latest version of
libraw, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Luca Falavigna <[email protected]> (supplier of updated libraw package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Tue, 10 Jun 2014 11:13:04 +0200
Source: libraw
Binary: libraw10 libraw-bin libraw-dev libraw-doc
Architecture: source amd64 all
Version: 0.16.0-5
Distribution: unstable
Urgency: medium
Maintainer: Debian Shotwell Maintainers
<[email protected]>
Changed-By: Luca Falavigna <[email protected]>
Description:
libraw-bin - raw image decoder library (tools)
libraw-dev - raw image decoder library (development files)
libraw-doc - raw image decoder library (documentation)
libraw10 - raw image decoder library
Closes: 750985
Changes:
libraw (0.16.0-5) unstable; urgency=medium
.
[ Martin Pitt ]
* Fix autopkgtest: Add missing libraw-dev test dep, drop unnecessary
@builddeps@, and add missing "set -e" so that the test actually fails
properly. Also fix linking order to also work with binutils-gold.
These fixes closes: #750985.
Checksums-Sha1:
dc391ecbf82be305d8514663c6b7572084c01a53 2097 libraw_0.16.0-5.dsc
b04c75230931b61ee1e2d94cae8e3587036844ae 24936 libraw_0.16.0-5.debian.tar.xz
f62623201bc9821b599af4c9f81cfe6ea2a131bd 215588 libraw10_0.16.0-5_amd64.deb
db0d59855c1b8a68098acbd1bb2a549a78a6ea2b 61938 libraw-bin_0.16.0-5_amd64.deb
56289a88f4485c9af3a4afb0ae5e523411c6f903 219070 libraw-dev_0.16.0-5_amd64.deb
ea969e4afd97bb41f48596e72a5e9860a3dde01a 108848 libraw-doc_0.16.0-5_all.deb
Checksums-Sha256:
244a51edf3f7f081c24a43c719fe5f2fbd10bc6d644d1eefcff98b439e274190 2097
libraw_0.16.0-5.dsc
1935298c2e4cc312cd0929151a8d70e13139ad743d0830da48aa6485f08319d3 24936
libraw_0.16.0-5.debian.tar.xz
06928bf996cedc1372d860fb8ca48064f5f30c2d89a7c37a6a1c8cf44a62d075 215588
libraw10_0.16.0-5_amd64.deb
3c50db3c19c00ed68b1ba803ab21f95dd171e7f65857936ff7da8e8adb2c5a81 61938
libraw-bin_0.16.0-5_amd64.deb
cb0d5c331e6f7c53c07e6182ee30e3fed2d320b9ddc7c2ced2a78edbbee4fed7 219070
libraw-dev_0.16.0-5_amd64.deb
fac0bcc462bbc35a4159ffd1ed3e7abe83798d39330e95b8db0588db39a32623 108848
libraw-doc_0.16.0-5_all.deb
Files:
7860291b794f4118fd6c1930b54129c5 215588 libs optional
libraw10_0.16.0-5_amd64.deb
cb6b195a46fceb24f9458d25131bf284 61938 graphics optional
libraw-bin_0.16.0-5_amd64.deb
caf6ac5ebad46a2773cc4ad80749fa12 219070 libdevel optional
libraw-dev_0.16.0-5_amd64.deb
51373f1e313e6cb556e9e7244644eea1 108848 doc optional
libraw-doc_0.16.0-5_all.deb
d2b9b1176ac64ebc188640902679cb0b 2097 libs optional libraw_0.16.0-5.dsc
2befc7f58670ce86d72aea5e6eac515d 24936 libs optional
libraw_0.16.0-5.debian.tar.xz
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJTls3+AAoJEEkIatPr4vMfi04P/jomY/jarEsQa6oqtXkqjZw7
U/DvQaQb4ozy6VpA8hrl91zslao8XP+NueGIiSqLO+mj/BJ7Nr16WBpoqoYTLFAt
cpu6TMepyavwbvpXuu0vDKbQtctTvmU1F9ayVcTHykEmZRLaiWslirt+h6xvqrU6
p4WSBzIP9VlKQ8TjwvOsnEbLDl1ihbO1iPBmyQpmCgMsXuzY8t4TftuNG+pL+B5V
K5npQaBPp9w82pKeykeqMptW5njZeh4W3OvRVzEc8FS0nzQgc2xLcne34T22GmGo
xE3C9rJUUf+am30djV4ppmMqxRa3jfRqCoKeVOOk1Sxl0E9xjnJq8Y8XA2pPLU8w
GoR+yKlxtE5bkwK8l96JKPJJ8a51KsG+FmhN7KIShG1wDr0pbj9u3kSeo2hjuqEQ
DhuFjYU8qlm08UViZ+/cRVYmT2zWHqGlMsU+PPiU8v/eTd+ziW3nDAZfwP6Wpqae
/Xn29+2oY+HOK1Yn0N7M1+P3i8Bs+4xP/zoWN0sCkT8G6vaO/p6gDKkZL1IvlBVB
CMazI3T5L7XUyJL6J3FYEGiPphYVIGTOH3iKTU3xhoPRw6kZopvhxxMeZREYJBZd
VK8bu6Ww5Z0C3q2M/rdDmjypVQOhqH9f0runjAavcTBgpKl9a6ziIeDrXAcDBSRM
zfGG9agtIMhkbqsqCyGS
=GpYo
-----END PGP SIGNATURE-----
--- End Message ---
