Your message dated Sat, 05 Jul 2014 21:02:11 +0200
with message-id <[email protected]>
and subject line Re: Bug#753108: Fwd: Re: Bug#753108: dh-systemd does not seem 
to properly handle services when using --name
has caused the Debian Bug report #753108,
regarding dh-systemd does not seem to properly handle services when using --name
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
753108: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=753108
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dh-systemd
Version: 1.19

Am 29.06.2014 11:49, schrieb Michael Biebl:
> So quotarpc.service is only supposed to run if rpcbind is installed?
> 
> I think what you want here then is Wants/After + a Condition [1].
> i.e.
> 
> [Unit]
> Wants=rpcbind.service
> After=rpcbind.service
> ConditionFileIsExecutable=/sbin/rpcbind
> ....

Btw, I noticed that quotarpc is not enabled by default. Instead
dh_systemd creates two sections for quota.service

# ls debian/*.service
debian/quota.quotarpc.service  debian/quota.service

# debian/rules
dh_systemd_enable
dh_systemd_enable --name=quotarpc.service


The start section for quotarpc is completely missing.

This might be a bug in dh_systemd in how --name= is handled.

Michael Stapelberg, could you look into this?

3 Michaels now, I feel like talking to myself :-)

Cheers,
Michael


-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

Attachment: signature.asc
Description: OpenPGP digital signature


--- End Message ---
--- Begin Message ---
Hi Michael,

You used “dh_systemd_enable --name=quotarpc.service”, but I think you
are confusing two things here:

1) For deciding which service file dh_systemd_enable should install
   (like dh_installinit), you should specify --name=quotarpc,
   i.e. without the .service prefix. This is the handling that is common
   to debhelper and specifies the per-package files.

   dh_systemd_enable --name=quotarpc
       install -p -m644 debian/quota.quotarpc.service 
debian/quota/lib/systemd/system/quotarpc.service

2) For only generating blocks for specific service files, you need to
   pass them as arguments: “dh_systemd_enable quota.service” and
   “dh_systemd_enable --name=quotarpc quotarpc.service”. Likewise for
   dh_systemd_start.

When I use these commands in debian/rules, the package is built
correctly for me. Hence, I’m closing this bugreport. Feel free to reopen
and explain in detail in case you still have doubts.

-- 
Best regards,
Michael

--- End Message ---

Reply via email to