Your message dated Sat, 11 Oct 2014 03:19:52 +0000
with message-id <[email protected]>
and subject line Bug#680321: fixed in libgeo-ip-perl 1.45-1
has caused the Debian Bug report #680321,
regarding libgeo-ip-perl: noise in error log due to use of constant subroutines
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
680321: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=680321
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: libgeo-ip-perl
Version: 1.38-1
Severity: important
Hi,
Whenever Geo::IP is used with mod_perl's PerlRun handler, Apache's error log
will be populated by a dozen of warnings *on every request*.
The warnings go on like this:
Constant subroutine
ModPerl::ROOT::ModPerl::PerlRun::path_to_perl_file_2epl::GEOIP_UNKNOWN_SPEED
redefined at /usr/lib/perl5/ModPerl/Util.pm line 69.
Now, I couldn't find any way *at all* to disable those warnings. -X, no
warnings, etc; nothing works.
According to a thread I found in an apache ML [1], there's some XS code that
could be used that does The Right Thing. However, for an unknown reason the
PP code is used (as demonstrated by the error log and the surrounding code
in ModPerl::Util::unload_package().
Perhaps somebody reading this message knows why it wasn't used or what the
status of that alledgedly included code is.
In any case, it is fairly easier to avoid defining those constant
subroutines. Attached diff turns those constant subroutines into non-constant
subroutines.
I know that it could have a performance impact, but at least when using
Geo::IP under PerlRun, it is the only sane way to use an application without
filling the /var/log partition.
Feel free to contact upstream and find an alternative solution.
P.S. how about a backport of wheezy's version to squeeze, for IPv6 support?
Thanks!
[1]http://mail-archives.apache.org/mod_mbox/perl-
modperl/200410.mbox/%[email protected]%3E
Cheers,
--
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net
--- unpacked/usr/lib/perl5/Geo/IP.pm 2009-06-21 15:41:47.000000000 +0000
+++ /usr/lib/perl5/Geo/IP.pm 2012-07-05 00:13:55.000000000 +0000
@@ -22,36 +22,36 @@
require Geo::IP::Record;
-sub GEOIP_STANDARD() { 0; } # PP
-sub GEOIP_MEMORY_CACHE() { 1; } # PP
-sub GEOIP_CHECK_CACHE() { 2; }
-sub GEOIP_INDEX_CACHE() { 4; }
-sub GEOIP_MMAP_CACHE() { 8; } # PP
-
-sub GEOIP_UNKNOWN_SPEED() { 0; } #PP
-sub GEOIP_DIALUP_SPEED() { 1; } #PP
-sub GEOIP_CABLEDSL_SPEED() { 2; } #PP
-sub GEOIP_CORPORATE_SPEED() { 3; } #PP
+sub GEOIP_STANDARD { 0; } # PP
+sub GEOIP_MEMORY_CACHE { 1; } # PP
+sub GEOIP_CHECK_CACHE { 2; }
+sub GEOIP_INDEX_CACHE { 4; }
+sub GEOIP_MMAP_CACHE { 8; } # PP
+
+sub GEOIP_UNKNOWN_SPEED { 0; } #PP
+sub GEOIP_DIALUP_SPEED { 1; } #PP
+sub GEOIP_CABLEDSL_SPEED { 2; } #PP
+sub GEOIP_CORPORATE_SPEED { 3; } #PP
BEGIN {
#my $pp = !( defined &_XScompiled && &_XScompiled && !$TESTING_PERL_ONLY );
my $pp = !defined &open;
- sub GEOIP_COUNTRY_EDITION() { 1; }
- sub GEOIP_CITY_EDITION_REV1() { 2; }
- sub GEOIP_REGION_EDITION_REV1() { 3; }
- sub GEOIP_ISP_EDITION() { 4; }
- sub GEOIP_ORG_EDITION() { 5; }
- sub GEOIP_CITY_EDITION_REV0() { 6; }
- sub GEOIP_REGION_EDITION_REV0() { 7; }
- sub GEOIP_PROXY_EDITION() { 8; }
- sub GEOIP_ASNUM_EDITION() { 9; }
- sub GEOIP_NETSPEED_EDITION() { 10; }
- sub GEOIP_DOMAIN_EDITION() { 11; }
+ sub GEOIP_COUNTRY_EDITION { 1; }
+ sub GEOIP_CITY_EDITION_REV1 { 2; }
+ sub GEOIP_REGION_EDITION_REV1 { 3; }
+ sub GEOIP_ISP_EDITION { 4; }
+ sub GEOIP_ORG_EDITION { 5; }
+ sub GEOIP_CITY_EDITION_REV0 { 6; }
+ sub GEOIP_REGION_EDITION_REV0 { 7; }
+ sub GEOIP_PROXY_EDITION { 8; }
+ sub GEOIP_ASNUM_EDITION { 9; }
+ sub GEOIP_NETSPEED_EDITION { 10; }
+ sub GEOIP_DOMAIN_EDITION { 11; }
- sub GEOIP_CHARSET_ISO_8859_1() { 0; }
- sub GEOIP_CHARSET_UTF8() { 1; }
+ sub GEOIP_CHARSET_ISO_8859_1 { 0; }
+ sub GEOIP_CHARSET_UTF8 { 1; }
# cheat --- try to load Sys::Mmap PurePerl only
if ($pp) {
--- End Message ---
--- Begin Message ---
Source: libgeo-ip-perl
Source-Version: 1.45-1
We believe that the bug you reported is fixed in the latest version of
libgeo-ip-perl, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Axel Beckert <[email protected]> (supplier of updated libgeo-ip-perl package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 11 Oct 2014 04:07:46 +0200
Source: libgeo-ip-perl
Binary: libgeo-ip-perl
Architecture: source amd64
Version: 1.45-1
Distribution: unstable
Urgency: low
Maintainer: Debian Perl Group <[email protected]>
Changed-By: Axel Beckert <[email protected]>
Description:
libgeo-ip-perl - Perl interface to GeoIP library
Closes: 680321
Changes:
libgeo-ip-perl (1.45-1) unstable; urgency=low
.
[ gregor herrmann ]
* debian/control: remove Nicholas Bamber from Uploaders on request of
the MIA team.
* Strip trailing slash from metacpan URLs.
.
[ Salvatore Bonaccorso ]
* Update Vcs-Browser URL to cgit web frontend
.
[ Axel Beckert ]
* Import new upstream release
+ Drop no-dns.patch, no more needed (test has been moved to xt/.)
+ Refreshed remaining patch.
* Add myself as uploader to fix lintian warning no-human-maintainers
* Bump Standards-Version to 3.9.6 (no changes needed)
* Fix pkg-perl-specific lintian warning missing-testsuite-header
* Apply patch by Raphael Geissert to avoid error log noise under
mod_perl (Closes: #680321)
Checksums-Sha1:
531b12a39a1c355fe33dbd49a933627700e4b99c 1402 libgeo-ip-perl_1.45-1.dsc
f53093c7945081fe584114de1df4642b41099dc4 134181 libgeo-ip-perl_1.45.orig.tar.gz
720f7a1d804522df25f4c6af5f06e2dbfa54fec4 3984
libgeo-ip-perl_1.45-1.debian.tar.xz
75e0bda175748a76ef463d82bd58b13c21085c69 76578 libgeo-ip-perl_1.45-1_amd64.deb
Checksums-Sha256:
10e069b24d69553e00e5b808877213ff8334e6ad107e3de13b4be2e1b4b88226 1402
libgeo-ip-perl_1.45-1.dsc
0eb765c238dde4a29d5c863d475c72078e5361deab2cfc168b9285bc049e3662 134181
libgeo-ip-perl_1.45.orig.tar.gz
6313db9c726fef6455d143c87615a92e0a4ed80269e23ac746d1808b8141c08f 3984
libgeo-ip-perl_1.45-1.debian.tar.xz
b81e4a9fafaf7e39d72e270c71eb065bb5bb3bc73b0ce8a7172579100d3de7a6 76578
libgeo-ip-perl_1.45-1_amd64.deb
Files:
d8f84163793a6509fa1492bf88cd18a3 1402 perl optional libgeo-ip-perl_1.45-1.dsc
781fbf2a6b6505e86e3e5ebe05254928 134181 perl optional
libgeo-ip-perl_1.45.orig.tar.gz
a352718adb1cdb8f8d3439da83ab42f7 3984 perl optional
libgeo-ip-perl_1.45-1.debian.tar.xz
1c120e81d7b8ba13efd48d1c7ecc4a07 76578 perl optional
libgeo-ip-perl_1.45-1_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iEYEARECAAYFAlQ4kUQACgkQwJ4diZWTDt6WwwCfaBpZdl4uzqSdQh6N51mFyNIc
iQ4An37N+SlVKPsDBrtOdCgTV8CnECki
=e2dh
-----END PGP SIGNATURE-----
--- End Message ---
