Your message dated Fri, 21 Nov 2014 18:35:07 +0000
with message-id <[email protected]>
and subject line Bug#767704: fixed in watchdog 5.14-2
has caused the Debian Bug report #767704,
regarding watchdog: wd_keepalive gets killed from /etc/init.d/sendsigs on 
shutdown
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
767704: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767704
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: watchdog
Version: 5.12-1
Severity: important
Tags: patch

Dear Maintainer,

wd_keepalive gets killed on shutdown from sendsigs. If the watchdog module runs 
with "nowayout", this leads to a hard reset after some time. This "some time" 
usually is very probably during the fs unmounting, which in turn probably leads 
to file system corruption.

An exemplary case:
Watchdog module:
options bcm2708_wdog heartbeat=15 nowayout=1 
rc6.d:
lrwxrwxrwx 1 root root 18 Nov 24  2013 rc6.d/K01watchdog -> ../init.d/watchdog
lrwxrwxrwx 1 root root 18 Nov  1 23:58 rc6.d/K07sendsigs -> ../init.d/sendsigs
lrwxrwxrwx 1 root root 18 Nov  1 23:58 rc6.d/K11umountfs -> ../init.d/umountfs

On K01, wd_keepalive is started, on K07 it gets killed by killall5 and on K11 
the PC shuts down due to the hardware watchdog.

It seems, the sendsigs init script (from package initscripts) has a mechanism 
to circumvent this, so it is easy to patch by adding a pid file to 
/run/sendsigs.omit.d like:

... on watchod start

        rm -f /run/sendsigs.omit.d/$KEEPALIVE_NAME.pid

... on watchod stop

        ln -s /var/run/$KEEPALIVE_NAME.pid 
/run/sendsigs.omit.d/$KEEPALIVE_NAME.pid

Some own testing showed that this works flawlessly. Since sendsigs is from 
initscripts and watchdog depends on this implicitly, the directory can be 
assumed to exist.

Ralf


-- System Information:
Debian Release: 7.6
Architecture: armhf (armv6l)

Kernel: Linux 3.12.28+ (PREEMPT)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages watchdog depends on:
ii  debconf [debconf-2.0]  1.5.49
ii  libc6                  2.13-38+rpi2+deb7u3
ii  lsb-base               4.1+Debian8+rpi1+deb7u1
ii  makedev                2.3.1-92
ii  udev                   175-7.2

watchdog recommends no packages.

watchdog suggests no packages.

-- Configuration Files:
/etc/init.d/watchdog changed:
PATH=/bin:/usr/bin:/sbin:/usr/sbin
test -x /usr/sbin/watchdog || exit 0
run_watchdog=0
watchdog_options=""
watchdog_module="none"
[ -e /etc/default/watchdog ] && . /etc/default/watchdog
NAME=watchdog
KEEPALIVE_NAME=wd_keepalive
DAEMON=/usr/sbin/watchdog
KEEPALIVE_DAEMON=/usr/sbin/wd_keepalive
STOP_RETRY_SCHEDULE='TERM/10/forever/KILL/1'
. /lib/lsb/init-functions
case "$1" in
  start)
    if [ $run_watchdog = 1 ]
    then
        # do we have to load a module?
        [ ${watchdog_module:-none} != "none" ] && /sbin/modprobe 
$watchdog_module
        # make sure that wd_keepalive is stopped
        log_begin_msg "Stopping watchdog keepalive daemon..."
        start-stop-daemon --stop --quiet --oknodo --retry $STOP_RETRY_SCHEDULE \
            --pidfile /var/run/$KEEPALIVE_NAME.pid
        log_end_msg $?
        rm -f /run/sendsigs.omit.d/$KEEPALIVE_NAME.pid
        # Unconditionally start watchdog daemon because we want to run it even
        # if wd_keepalive wasn't running
        log_begin_msg "Starting watchdog daemon..."
        start-stop-daemon --start --quiet --pidfile /var/run/$NAME.pid \
             --exec $DAEMON -- $watchdog_options
        log_end_msg $?
    fi
    ;;
  stop)
    if [ $run_watchdog = 1 ]
    then
        log_begin_msg "Stopping watchdog daemon..."
        start-stop-daemon --stop --quiet --retry $STOP_RETRY_SCHEDULE \
            --pidfile /var/run/$NAME.pid
        log_end_msg $?
        # make sure that wd_keepalive is started
        log_begin_msg "Starting watchdog keepalive daemon..."
        start-stop-daemon --start --quiet --pidfile 
/var/run/$KEEPALIVE_NAME.pid \
            --exec $KEEPALIVE_DAEMON -- $watchdog_options
        log_end_msg $?
        ln -s /var/run/$KEEPALIVE_NAME.pid 
/run/sendsigs.omit.d/$KEEPALIVE_NAME.pid
    fi
    ;;
  restart)
    $0 force-reload
    ;;
  force-reload)
    if [ $run_watchdog = 0 ]; then exit 0; fi
    log_daemon_msg "Restarting ${NAME}"
    log_progress_msg "Stopping $NAME daemon..."
    start-stop-daemon --stop --pidfile /var/run/$NAME.pid --quiet \
        --retry $STOP_RETRY_SCHEDULE || log_end_msg $?
    log_progress_msg "Starting $NAME daemon..."
    start-stop-daemon --start --quiet --pidfile /var/run/$NAME.pid \
        --exec $DAEMON -- $watchdog_options
    log_end_msg $?
    ;;
  status)
    status_of_proc "$DAEMON" watchdog
    ;;
  *)
    echo "Usage: /etc/init.d/watchdog {start|stop|restart|force-reload|status}"
    exit 1
esac
exit 0

/etc/watchdog.conf changed:
change                  = 1800
max-load-1              = 100
max-load-5              = 25
min-memory              = 1
watchdog-device = /dev/watchdog
interval                = 10
realtime                = yes
priority                = 1


-- debconf information:
  watchdog/module: none
  watchdog/run: true
  watchdog/restart: false

--- End Message ---
--- Begin Message ---
Source: watchdog
Source-Version: 5.14-2

We believe that the bug you reported is fixed in the latest version of
watchdog, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Michael Meskes <[email protected]> (supplier of updated watchdog package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 04 Nov 2014 16:30:54 +0100
Source: watchdog
Binary: watchdog
Architecture: source amd64
Version: 5.14-2
Distribution: unstable
Urgency: medium
Maintainer: Michael Meskes <[email protected]>
Changed-By: Michael Meskes <[email protected]>
Description:
 watchdog   - system health checker and software/hardware watchdog handler
Closes: 767644 767704 768168
Changes:
 watchdog (5.14-2) unstable; urgency=medium
 .
   * Applied upstream change to fix an incorrectly calculated amount of memory
     being used in a test.
   * Make sure /etc/init.d/sendsigs does not kill wd_keepalive. (Closes: 
#767704)
   * Auto-generated default file from debconf. (Closes: #767644)
   * Changed ordering of unit files to prevent a cycle. (Closes: #768168)
Checksums-Sha1:
 39eff030caa2c8d68f00e8bef82dfaa509316cbc 1691 watchdog_5.14-2.dsc
 41154c0717c806f8caace47c78ac12cccb871e93 6810 watchdog_5.14-2.diff.gz
 238911d8daa90e364bebcfbdcb8c136849d4a48c 83876 watchdog_5.14-2_amd64.deb
Checksums-Sha256:
 280ad2be857a25e2cccc828cba3aa7e3a4c0d2f22515751adbd8e6f81ec4b7cb 1691 
watchdog_5.14-2.dsc
 b81549fdac436c437832bb133ffb5f96f613fcc7d069fe442289f8de02b44f6e 6810 
watchdog_5.14-2.diff.gz
 8d5d30ac1b9c1d7facda55bb33eca5b1beba6105387b8f261ff8fa4f2f4c9a1e 83876 
watchdog_5.14-2_amd64.deb
Files:
 bcca9bccad8622a53d040b39a9fa5112 1691 admin extra watchdog_5.14-2.dsc
 d4d8f55d37f35f46ab9123efe5979d3f 6810 admin extra watchdog_5.14-2.diff.gz
 b96119a7609c3af7a8e7e254e2818662 83876 admin extra watchdog_5.14-2_amd64.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIVAwUBVG+Bd98j2jOWl46zAQibYQ//da4b2yUdIgiRAZcyO/f98Frbh/B5JoZM
BGEZJDocJ5NgV0/MXnwtN1Jy9QiN1kZtHzyQoUtEHbkC+n4yUFO3y7F+FdfxziSo
UgNXeKrTJFw2Xdv2fVHeDmEqiCVw5QMNUsPySBai/wbzKpucpHOE4PINmD5QxNDP
Lr/DMdRyMPeHjyj6VqxA5lSU/AM9Y2zEiAWETKzUh5bjQuveBW2we1HPvqLR9PjC
x61dpFKg7vX6ZM/DYAnz81RQFFX1PCWYMn+AbPiklN/biD90EWYXGPomxkLwJ+KA
xFeH/B5kE6RTiX05ANeQ4v3Q5sl5wQFrV6VXhVkfGRHPwNcXuZ80GLSlIjK+iV6g
27Q53Cb+sFDA/GZ/ZXDDwom1S88Y/5K/EV/CFcoAaZIbn1Km7nyIK08KX/zGQoeb
RfeSwNtP6K9NfyqmJz0XNDlWeCU2Ma8FUrw6DvcgH+7Pi5FTcP25ek2ZeZ6ZAwHz
gLVOYmy4gqnztFY/Tdhk/+6Uxtdk0takosM+j453BnMueyuFUS+w5th37nci2Lrm
VRphYDsY8FQKgEmiUFwJ/DB2wWvfqFEiyQkbJXstxl+qCVSvyuSPsimfVRXEoBnU
3XcpFJ+IdmnOW5do6DVPWsCvWDEVr0xcb1UfMvKFrPlJ1uvs+u9lS4FtAFsPP0qm
Des7lXbuqwQ=
=eCep
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to