Your message dated Mon, 29 Dec 2014 18:48:36 +0000
with message-id <[email protected]>
and subject line Bug#773569: fixed in openntpd 20080406p-12
has caused the Debian Bug report #773569,
regarding openntpd: race condition in '/etc/init.d/openntpd restart'
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
773569: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=773569
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: openntpd
Version: 20080406p-10
Severity: normal
Tags: patch
Dear Maintainer,
Currently, openntpd's init script restarts openntpd by killing it (with
start-stop-daemon --stop), sleeping 1 second, and then starting it.
This has a race condition: if openntpd takes longer than 1 second to
terminate, it fails to start up again (presumably because the UDP port
is in use). This has happened to me a few times now.
The attached patch adds the --retry option to the start-stop-daemon
command, so that start-stop-daemon waits for the daemon to terminate,
sending SIGKILL if necessary.
Could this patch be applied to the package?
Thanks,
Andrew
diff -ruN openntpd-20080406p.orig/debian/openntpd.init openntpd-20080406p/debian/openntpd.init
--- openntpd-20080406p.orig/debian/openntpd.init 2014-07-31 13:20:18.000000000 -0700
+++ openntpd-20080406p/debian/openntpd.init 2014-12-19 17:39:57.730697444 -0800
@@ -45,14 +45,13 @@
stop)
echo -n "Stopping $DESC: "
- start-stop-daemon --stop --oknodo --quiet --user root --exec $DAEMON
+ start-stop-daemon --stop --oknodo --quiet --retry=TERM/30/KILL/5 --user root --exec $DAEMON
echo "$NAME."
;;
restart|force-reload)
echo -n "Restarting $DESC: "
- start-stop-daemon --stop --oknodo --quiet --user root --exec $DAEMON
- sleep 1
+ start-stop-daemon --stop --oknodo --quiet --retry=TERM/30/KILL/5 --user root --exec $DAEMON
start-stop-daemon --start --quiet --exec $DAEMON -- $DAEMON_OPTS
echo "$NAME."
;;
--- End Message ---
--- Begin Message ---
Source: openntpd
Source-Version: 20080406p-12
We believe that the bug you reported is fixed in the latest version of
openntpd, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Ulises Vitulli <[email protected]> (supplier of updated openntpd package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 29 Dec 2014 14:02:31 -0300
Source: openntpd
Binary: openntpd
Architecture: source amd64
Version: 20080406p-12
Distribution: experimental
Urgency: low
Maintainer: Ulises Vitulli <[email protected]>
Changed-By: Ulises Vitulli <[email protected]>
Description:
openntpd - OpenBSD NTP daemon
Closes: 773569
Changes:
openntpd (20080406p-12) experimental; urgency=low
.
* Fix sysv initscript race condition while restarting.
Thanks AndrewAyer! (Closes: #773569).
* Updated d/copyright to copyright-format 1.0.
* Update Standards-Version to 3.9.6. No changes required.
Checksums-Sha1:
1fb770d5d84cd32bc93f5ee345b651ff9671d9e7 1939 openntpd_20080406p-12.dsc
931fc817b28c28967430bf31dcb0104d561a09d9 13792
openntpd_20080406p-12.debian.tar.xz
c04b120f06fa9ac584d837ba3623b28b3d163c2a 61970 openntpd_20080406p-12_amd64.deb
Checksums-Sha256:
519e0924e10d734f39f37fe6a681e8039d03bfec4a2dcd66de9ba56597e68f89 1939
openntpd_20080406p-12.dsc
dfc46b8839f17a4f7c2b7ae28b443d24c12d0ed48a05455557a2080fa1e5301f 13792
openntpd_20080406p-12.debian.tar.xz
ffcc8c03bc3b4fbbde89252388e3a1a0ae2c8c0f18c84ac55e867b09ae660713 61970
openntpd_20080406p-12_amd64.deb
Files:
6520f3017d26fcfd05aa1a8185eaa3ee 1939 net optional openntpd_20080406p-12.dsc
e7b364d98a9033e86c44aeecedcef63e 13792 net optional
openntpd_20080406p-12.debian.tar.xz
8afde86064876751dde8c21633628ebb 61970 net optional
openntpd_20080406p-12_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCgAGBQJUoZ3ZAAoJEGin9OG0lUUKNgAQAI2SrrF+6KO8wOI6iVBdgwKO
UPhwRD0yYl+BkrYQfJQRthASokuPejzTgKgYabfn4u3rQciGfkIyK5lQ2q3mYSEo
5qDBsc5YgHZFW3lEHS0KxqCDzuPV/xJfJejwDGJHOrdAgFII1jOR5knk3+j4H43P
lwUTjZ1i0wPpcN8uYGJWljf4E48p2ELzKe7MYIJJJHCcAwDzbV5i0wYoSNxLw8GB
OhcHzi06usE9PdstzmUi8uFbnibT3Ya/VfzPMRbjiHkP/njWH1PGi4zQmaGIvOEK
OU1ICJuh0+CSInZtvV4nNZPn1/0NirUbAc/fVcXe9oFxxP7rCrqWmgUHbMKuw2Lq
S6O9wYuMRF7kCfRyRpQVmkdkVk1j5jiQr7e8VjHkwx+Z6/rs6OFiPoE0sJJeRYim
ubo1FvnUd25OK/wv4+VYC/b2864Pl5ZA9mf/KzTTlqMPExkhQvRgPXWBL+2nl9Up
4NpZ5cFQcmGYG1ey55pSNz1mYuz1svfJjsaTdRDWAqFMsH0cUyyKr54OKxIAlV3g
5lSVtnwPK1QWQYQdeuKYhc7OufSX/qVt8cO9c4GJq7LaJjPNawKh5ZIsiSNm4MGO
+LLcViLPghpbxREticfmow+U+jvjKcy6e/AvyZWBMHgI4uIrqr1/tR2uS2UdHVIW
JGNpqXXv7VP61l4p5HSe
=GFyz
-----END PGP SIGNATURE-----
--- End Message ---
