Your message dated Mon, 26 Jan 2015 07:33:55 +0000 with message-id <[email protected]> and subject line Bug#775567: fixed in partman-md 74 has caused the Debian Bug report #775567, regarding Selection of underlying RAID devices also lists alignment gap artifacts to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 775567: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=775567 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: partman-md Version: 72 Severity: important Tags: d-i patch (Trying to debug #764798, making a big RAID6 with lots of devices.) partman-md shows all the "FREE SPACE" alignment artifacts when offering the list of possible RAID members to use for creating a RAID device. This is clearly silly and annoying, and likely to contribute to user error when working with a large list of devices (hence tagged as severity: important). #558727 alluded to something *similar*, but Frans suggested that only devices/partitions marked for use as physical RAID devices should be listed. I don't agree - some people prefer to use raw disk devices instead of partitions, and while I personally don't like that, it's a valid choice. A simple fix is to simply not show block device objects that are too small, i.e. less than 1MB in size. Trivial patch included here, and I'll check this into git shortly as soon as I get a bug number for the changelog. :-) I've tested this, and it works nicely... diff --git a/lib/md-base.sh b/lib/md-base.sh index 85de95e..6a52a4b 100644 --- a/lib/md-base.sh +++ b/lib/md-base.sh @@ -42,7 +42,7 @@ md_allowed () { local md=no local fs open_dialog PARTITION_INFO $id - read_line x1 x2 x3 x4 fs x6 x7 + read_line x1 x2 size x4 fs x6 x7 close_dialog if [ "$fs" = free ]; then # parted can't deal with VALID_FLAGS on free space as yet, @@ -68,6 +68,12 @@ md_allowed () { close_dialog fi + # Don't list devices that are too small (less than 1MB), + # they're most likely alignment artifacts + if [ $size -lt 1048576 ]; then + md=no + fi + [ $md = yes ] } -- System Information: Debian Release: 7.8 APT prefers stable APT policy: (500, 'stable'), (500, 'oldstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
--- End Message ---
--- Begin Message ---Source: partman-md Source-Version: 74 We believe that the bug you reported is fixed in the latest version of partman-md, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Christian Perrier <[email protected]> (supplier of updated partman-md package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 26 Jan 2015 08:16:37 +0100 Source: partman-md Binary: partman-md Architecture: source all Version: 74 Distribution: unstable Urgency: medium Maintainer: Debian Install System Team <[email protected]> Changed-By: Christian Perrier <[email protected]> Description: partman-md - Add to partman support for MD (udeb) Closes: 775567 Changes: partman-md (74) unstable; urgency=medium . [ Steve McIntyre ] * Don't list free devices that are too small (less than 1MB). They're not going to be useful at all, and they're also likely to simply be alignment artifacts that we can't use anyway. Closes: #775567 Checksums-Sha1: 654694a176e82edfd78da624cfecceeac9c2272d 1675 partman-md_74.dsc 8c7e156e2ee5a91afb9f3d8a6b69aac387f12c12 180204 partman-md_74.tar.xz 5ce6ef5324b0c502af13e2bc19891c289e5061e4 240736 partman-md_74_all.udeb Checksums-Sha256: add4fd90bda454d29baf23c88461337b6595ea59fa6d4d8a7206443ff99e49a3 1675 partman-md_74.dsc 6ad3372f3c1ce60f46750d2927ca55e8efb02eb89217b8714e2104b39031a25e 180204 partman-md_74.tar.xz bb7a9855e46a8b1a29f32bdc40b86ee14e0f2a2002da87fb4cc4c11747e01d53 240736 partman-md_74_all.udeb Files: 61706756eac18d88740107971b6b5fce 1675 debian-installer standard partman-md_74.dsc 0e84284e158b4803d4d958ab27c63be0 180204 debian-installer standard partman-md_74.tar.xz 6766ea0c69777e2664e141f72384a974 240736 debian-installer standard partman-md_74_all.udeb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCAAGBQJUxeohAAoJEIcvcCxNbiWo6T8P/jUWo2eY4FsSAa+OHhHAqJb0 JOD9TZ0vTUVP0DuyjrW0fLiot3akjq4d2Bgh/aZ8tixRGCBETCC7Q4iTZBQanNs5 jluGwbDAqWTJ2GP/1l8FMSQd2BKotQ21T3qv+FEez22pb44iz8FsBMSwz4J4HsgQ bfo90Ixp1ghXkuEthZhS19BGwW3R5OZBMr3VB2+IIjRJI3a69sFd4ImgL2awxExe dYTCXKiXNzC/c2rarWTCwN/e1owOymwOTW8be/PybZIFteFxInPYtk4p8Bcw3/wE awJCrXyUSlbG/V2axA5bn7+/YKyfxLsQHTNpAZ6XYQKsFGX6MXGTa7BaRZXGJntI sW/+X0+upaYqTaytGCtNM7GLRSjV8eYEbkna4o22VhNDsWVWaN6uDwETVvtWuOGd RqaN75dqsitWpcOjbTFcVX7KQ/9PK+rq0YJfx5mjF4uoQAYLazmRr1TCZLJlP8NH Rbj5qn5MqH4sfufBA2pvr1puvwNgaywtnvM+WuEXxuPHA5QI/MrOeX0AuiNmZsLd KUS+cgElEQd1wRPFfaC+K1zoK+/TvHEoNTgo5BOo+VKVHptBFKnW4T/wdmWljcdv WlHUIX/06n90YDOfmHXcNrtgcaBr/ZEGkLGWFEizkZTOlr/0t9KDGKgK63mn7PpJ CwFEYrc4hfKv6TC6t98E =cO7I -----END PGP SIGNATURE-----
--- End Message ---
