Your message dated Wed, 28 Jan 2015 13:04:01 +0000
with message-id <[email protected]>
and subject line Bug#776216: fixed in openstack-debian-images 1.2
has caused the Debian Bug report #776216,
regarding build-openstack-debian-image exits 0 in error cases
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
776216: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=776216
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: openstack-debian-images
Version: 1.1
Severity: normal
Tags: patch
Hi folks,
Spending some time to integrate the openstack builds on cdimage.d.o,
I'm getting errors at the end of the build (see later bug report for
that). Annoyingly, the build-openstack-debian-image script exits 0 on
failure, which makes it difficult for automated callers to know it's
failed.
Here's a trivial patch to fix that.
-- System Information:
Debian Release: 7.8
APT prefers stable
APT policy: (500, 'stable'), (500, 'oldstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 3.2.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff --git a/build-openstack-debian-image b/build-openstack-debian-image
index f6d4fd7..de55807 100755
--- a/build-openstack-debian-image
+++ b/build-openstack-debian-image
@@ -192,14 +192,16 @@ else
fi
cleanup(){
+ error=$?
[ ! -d "${MOUNT_DIR}" ] && return
echo
- echo "error, umounting $MOUNT_DIR"
+ echo "error $error, umounting $MOUNT_DIR"
chroot ${MOUNT_DIR} umount /proc || true
chroot ${MOUNT_DIR} umount /sys || true
umount ${MOUNT_DIR}
rmdir ${MOUNT_DIR}
kpartx -d ${AMI_NAME}
+ exit $error
}
trap "cleanup" EXIT TERM INT
--- End Message ---
--- Begin Message ---
Source: openstack-debian-images
Source-Version: 1.2
We believe that the bug you reported is fixed in the latest version of
openstack-debian-images, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Thomas Goirand <[email protected]> (supplier of updated openstack-debian-images
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 26 Jan 2015 15:14:53 +0100
Source: openstack-debian-images
Binary: openstack-debian-images
Architecture: source all
Version: 1.2
Distribution: unstable
Urgency: medium
Maintainer: PKG OpenStack <[email protected]>
Changed-By: Thomas Goirand <[email protected]>
Description:
openstack-debian-images - script to build a Debian image for OpenStack
Closes: 776216 776217
Changes:
openstack-debian-images (1.2) unstable; urgency=medium
.
* Uses 2GB by default as initial HDD space for the image, as 1GB isn't big
enough for building a Jessie image anymore (Closes: #776217). Thanks to
Steve McIntyre <[email protected]> for the bug report.
* Error as non-zero in case of an error (Closes: #776216). Thanks to Steve
McIntyre <[email protected]> for the bug report and patch.
* Allow stretch and buster as release names.
* Adds the contrib/official-debian-image-hook script used for generating the
official Debian image.
Checksums-Sha1:
85764fa309c3d32a2418bfdde4fb5192365c8a85 1798 openstack-debian-images_1.2.dsc
8d6923e8db2d90546e8d2ba98f592567a84e7464 10976
openstack-debian-images_1.2.tar.xz
7b3f176102373efd920fcf25d46cb01f59919a02 12410
openstack-debian-images_1.2_all.deb
Checksums-Sha256:
67514e89a3ffc9808c06d7d87afc4ed903a99230494d0d55276f1e92c5723207 1798
openstack-debian-images_1.2.dsc
9ef8497d55ba85bf7353ecf40ffd3f76d1724e26e9f2fba56ac3c2d4f2acfb75 10976
openstack-debian-images_1.2.tar.xz
c55f6974c9b0eac5849eaf526534ba74c9a4f8e0fd5329f00d6314592c8414b0 12410
openstack-debian-images_1.2_all.deb
Files:
7d7ac844a39366fa8102b65b6a07747c 1798 web extra openstack-debian-images_1.2.dsc
b169949271e93a4add7bd6fab4ecbc80 10976 web extra
openstack-debian-images_1.2.tar.xz
38f215641dec970c6e462b7f8979195f 12410 web extra
openstack-debian-images_1.2_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJUyNq0AAoJENQWrRWsa0P+i2AQAJvm/ovvH80nmQj51X8Ch1Zn
WZ+bo96tQXXiFfzJ9cZeYpTz6XMqzBEMhPvEWTbxFykBA8VfummiwO1XeB/O71AZ
gKRW/VZ6G5hE9J2jUpn5lClCelYQPJvY7aHDMfht8DbsV6xCN0SVbFf7PfFT5hd9
e8U3TYhdjnFNmB/oAeooiHysgAS3B5RoSXWYYpgCAr6HpnYbQrmOd0ViKXpWgw4f
ggAkkG5z1PEpSO6r5JeJMX4Kq9reThKh5TiOFjdste2Dvb5vovVhnHVuvuqaKxya
FcGfDHYeyB/zRbkKE1dp2E5Hj9NC/Mc73lHwW8+Gr7Wdbt65eFOGG3XIeoioyFQk
ADIwvQpOqTpCZSrzJd3GkhDO0skhTy8uQSXw/8m1BumOZ0uVCNBhzcV/Ur9u0C9M
EDxWayHK4x3zkyKV0nqFHrucdDUIBUsOcmswhxd9iIiXqBPiDClteZxJaCMuohsd
gKXvFREEW38tcw3J7EWhvGjTHRjaKffiAaB408f9Jlc0zmARjRXLwDub9F2Qhcsv
cTuKeIUnL0kD3mg3dA4fEUksg8Wzo7MZHV/pT4c1fzFKQyz63xGpRThGROWlRU8T
7YOhNCqVin/Y8WGQ2joB4VUEELbQ3Wm9ecRbToQg1cBXE8Frx4Jjt1DpI9KOlxWn
NYVdyKjBw36Uo5rlS0mv
=hxSu
-----END PGP SIGNATURE-----
--- End Message ---
