Your message dated Sat, 17 Dec 2005 00:02:17 -0800
with message-id <[EMAIL PROTECTED]>
and subject line Bug#339560: fixed in trustedqsl 1.11-4
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 17 Nov 2005 04:59:06 +0000
>From [EMAIL PROTECTED] Wed Nov 16 20:59:06 2005
Return-path: <[EMAIL PROTECTED]>
Received: from pop-altamira.atl.sa.earthlink.net ([207.69.195.62])
by spohr.debian.org with esmtp (Exim 4.50)
id 1EcbrW-0004ta-5C
for [EMAIL PROTECTED]; Wed, 16 Nov 2005 20:59:06 -0800
Received: from user-11faeg1.dsl.mindspring.com ([66.245.58.1]
helo=penngrove.fdns.net)
by pop-altamira.atl.sa.earthlink.net with esmtp (Exim 3.36 #10)
id 1EcbrU-0006Bz-00
for [EMAIL PROTECTED]; Wed, 16 Nov 2005 23:59:04 -0500
Received: from tvr by penngrove.fdns.net with local (Exim 4.50 #1 (Debian))
id 1EcbrT-0006Af-Mm
for <[EMAIL PROTECTED]>; Wed, 16 Nov 2005 20:59:03 -0800
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: John Mock <[EMAIL PROTECTED]>
To: Debian Bug Tracking System <[EMAIL PROTECTED]>
Subject: trustedqsl: 'tqsl' shouldn't use windows in batch mode
X-Mailer: reportbug 3.8
Date: Wed, 16 Nov 2005 20:59:03 -0800
Message-Id: <[EMAIL PROTECTED]>
Delivered-To: [EMAIL PROTECTED]
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-7.5 required=4.0 tests=BAYES_00,HAS_PACKAGE,
RCVD_IN_SORBS autolearn=no version=2.60-bugs.debian.org_2005_01_02
Package: trustedqsl
Version: 1.11-1
Severity: normal
Tags: patch
When signing log files in batch mode, 'tqsl' still creates an application
window, sends messages to that window instead of 'stdout or 'stderr' and
opens a dialog window to ask for confirmation in case of an error. The
progress dialog is particularly annoying if one wants to do anything else
with one's terminal while trying to run a batch file and the dialog window
essentially breaks the batch file unless one is sitting in front of one's
terminal.
The attached patch is an attempt to send these messages to 'stderr' rather
than to a window. (Perhaps they should go to 'stdout' instead??) Needless
to say, it needs either to be sent upstream and/or be further tested before
being incorporated into 'unstable' or 'testing'.
-- KD6PAG
-- System Information:
Debian Release: 3.1
Architecture: powerpc (ppc)
Kernel: Linux 2.6.11.7
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages trustedqsl depends on:
ii libc6 2.3.2.ds1-22 GNU C Library: Shared libraries an
ii libexpat1 1.95.8-3 XML parsing C library - runtime li
ii libgcc1 1:3.4.3-13 GCC support library
ii libssl0.9.7 0.9.7e-3sarge1 SSL shared libraries
ii libstdc++5 1:3.3.5-13 The GNU Standard C++ Library v3
ii libwxgtk2.4 2.4.3.1 wxWindows Cross-platform C++ GUI t
ii tqsllib1 2.0-1 QSL signing routines for the Logbo
ii zlib1g 1:1.2.2-4.sarge.2 compression library - runtime
-- no debconf information
-------------------------------------------------------------------------------
--- tqsl.cpp.orig 2005-03-03 04:08:03.000000000 -0800
+++ tqsl.cpp 2005-11-16 20:42:09.000000000 -0800
@@ -79,6 +79,7 @@
public:
QSLApp();
virtual ~QSLApp();
+ class MyFrame *GUIinit();
bool OnInit();
// virtual wxLog *CreateLogTarget();
};
@@ -321,6 +322,8 @@
DECLARE_EVENT_TABLE()
};
+class MyFrame;
+
class LogList : public wxLog {
public:
LogList(MyFrame *frame) : wxLog(), _frame(frame) {}
@@ -745,8 +748,12 @@
wxSplitPath(infile, 0, &name, &ext);
if (ext != wxT(""))
name += wxT(".") + ext;
- conv_dial->Show(TRUE);
- this->Enable(FALSE);
+
+ // Only display windows if not in batch mode -- KD6PAG
+ if (this) {
+ conv_dial->Show(TRUE);
+ this->Enable(FALSE);
+ }
bool ignore_err = false;
int major = 0, minor = 0, config_major = 0, config_minor = 0;
tqsl_getVersion(&major, &minor);
@@ -809,7 +816,9 @@
if (bad_text)
msg += wxString(wxT("\n")) +
wxString(bad_text, wxConvLocal);
wxLogError(msg);
- if (!ignore_err) {
+
+ // Only ask if not in batch mode or
ignoring errors - KD6PAG
+ if (!ignore_err && this) {
if
(wxMessageBox(wxString(wxT("Error: ")) + msg + wxT("\n\nIgnore errors?"),
wxT("Error"), wxYES_NO, this) == wxNO)
throw x;
}
@@ -822,7 +831,8 @@
break;
} while (1);
cancelled = !conv_dial->running;
- this->Enable(TRUE);
+ if (this)
+ this->Enable(TRUE);
if (compressed)
gzclose(gout);
else
@@ -839,7 +849,8 @@
gzclose(gout);
else
out.close();
- this->Enable(TRUE);
+ if (this)
+ this->Enable(TRUE);
delete conv_dial;
string msg = x.what();
tqsl_getConverterLine(conv, &lineno);
@@ -1095,18 +1106,31 @@
}
*/
-bool
-QSLApp::OnInit() {
+MyFrame *
+QSLApp::GUIinit() {
MyFrame *frame = new MyFrame(wxT("TQSL"), 50, 50, 550, 400);
frame->Show(true);
SetTopWindow(frame);
LogList *log = new LogList(frame);
wxLog::SetActiveTarget(log);
+ return frame;
+}
+
+bool
+QSLApp::OnInit() {
+ MyFrame *frame = 0;
tQSL_Location loc = 0;
bool locsw = false;
bool suppressdate = false;
+
+ // Send errors to 'stderr' if in batch mode. -- KD6PAG
+ if (!strcasecmp(wxString(argv[argc-1]).mb_str(), "-x")) {
+ wxLog::SetActiveTarget(new wxLogStderr(NULL));
+ } else {
+ frame = GUIinit();
+ }
for (int i = 1; i < argc; i++) {
if (locsw) {
if (loc)
@@ -1122,6 +1146,8 @@
suppressdate = true;
} else if (!strcasecmp(wxString(argv[i]).mb_str(), "-s")) {
// Add/Edit station location
+ if (!frame)
+ frame = GUIinit();
if (loc == 0) {
check_tqsl_error(tqsl_initStationLocationCapture(&loc));
AddEditStationLocation(loc);
@@ -1130,8 +1156,11 @@
} else if (!strcasecmp(wxString(argv[i]).mb_str(), "-x")) {
return false;
} else {
- if (loc == 0)
+ if (loc == 0) {
+ if (!frame)
+ frame = GUIinit();
loc = frame->SelectStationLocation(wxT("Select
Station Location for Signing"));
+ }
if (loc == 0)
return false;
wxString path, name, ext;
-------------------------------------------------------------------------------
---------------------------------------
Received: (at 339560-close) by bugs.debian.org; 17 Dec 2005 08:11:35 +0000
>From [EMAIL PROTECTED] Sat Dec 17 00:11:35 2005
Return-path: <[EMAIL PROTECTED]>
Received: from katie by spohr.debian.org with local (Exim 4.50)
id 1EnX1F-0001K6-KV; Sat, 17 Dec 2005 00:02:17 -0800
From: Hamish Moffatt <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.60 $
Subject: Bug#339560: fixed in trustedqsl 1.11-4
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Sat, 17 Dec 2005 00:02:17 -0800
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2005_01_02
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Level:
X-Spam-Status: No, hits=-6.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2005_01_02
X-CrossAssassin-Score: 3
Source: trustedqsl
Source-Version: 1.11-4
We believe that the bug you reported is fixed in the latest version of
trustedqsl, which is due to be installed in the Debian FTP archive:
trustedqsl_1.11-4.diff.gz
to pool/main/t/trustedqsl/trustedqsl_1.11-4.diff.gz
trustedqsl_1.11-4.dsc
to pool/main/t/trustedqsl/trustedqsl_1.11-4.dsc
trustedqsl_1.11-4_i386.deb
to pool/main/t/trustedqsl/trustedqsl_1.11-4_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Hamish Moffatt <[EMAIL PROTECTED]> (supplier of updated trustedqsl package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 17 Dec 2005 18:26:36 +1100
Source: trustedqsl
Binary: trustedqsl
Architecture: source i386
Version: 1.11-4
Distribution: unstable
Urgency: low
Maintainer: Hamish Moffatt <[EMAIL PROTECTED]>
Changed-By: Hamish Moffatt <[EMAIL PROTECTED]>
Description:
trustedqsl - QSL log signing for the Logbook of the World (LoTW)
Closes: 278856 339560 341474
Changes:
trustedqsl (1.11-4) unstable; urgency=low
.
* Fix circular dependency in Makefile and autoreconf with the
correct tool versions (ie automake 1.9 this time) and hope that
the infinite loop doesn't reoccur .. :-| (closes: #341474)
* tqsl should only open windows if not in batch mode (closes: #339560);
thanks to John Mock KD6PAG for the patch
* Reinstall the help files properly (closes: #278856)
Files:
429658375d39cc9b5eeab38e90d92a4b 778 hamradio optional trustedqsl_1.11-4.dsc
3c1cc7d62784a57ae9bea76cfc4ae457 12376 hamradio optional
trustedqsl_1.11-4.diff.gz
69622b7b9bc174bff1664febee946c32 375242 hamradio optional
trustedqsl_1.11-4_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
iQCVAwUBQ6PEcdiYIdPvprnVAQIjiAP+Ngf9xmIEDgBeec7IIqnp9t55PbeHvQR9
H4PyAHstTFQ/GZCz25ye8SPBc4GJo0WLTDIEKM/CnIGWmoW9GTOUQg1buzbbjNVf
rzsJ/b41Oo8hXbOEiUcV/qK6l2e+md3gRNfxrT/FJn7WVfAsiTG1FIbCn02yWQCg
8vPjLfxML8w=
=hd9I
-----END PGP SIGNATURE-----
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
