Your message dated Sat, 02 May 2015 21:59:27 +0000 with message-id <[email protected]> and subject line Bug#742267: fixed in vmdebootstrap 0.7-1 has caused the Debian Bug report #742267, regarding vmdebootstrap: Should extlinux be installed if grub installation succeed? to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 742267: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=742267 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: vmdebootstrap Version: 0.4-1 Tags: patch At the moment, extlinux is configured also when grub installation is used. Is this intended? The comment in the code ("failed ... using extlinux" make me suspect that the intention was to only install extlinux if grub installation failed. If so, here is a patch I believe will make this the reality. diff --git a/vmdebootstrap b/vmdebootstrap index 126475f..8fba09b 100755 --- a/vmdebootstrap +++ b/vmdebootstrap @@ -482,15 +482,18 @@ class VmDebootstrap(cliapp.Application): '%s' % os.path.join(rootdir, 'proc')]) self.runcmd(['mount', '/sys', '-t', 'sysfs', '-obind', '%s' % os.path.join(rootdir, 'sys')]) + failed = True try: self.runcmd(['chroot', rootdir, 'update-grub']) self.runcmd(['chroot', rootdir, 'grub-install', install_dev]) + failed = False except cliapp.AppException as e: self.message("Failed. Is grub2-common installed? Using extlinux.") self.runcmd(['umount', os.path.join(rootdir, 'sys')]) self.runcmd(['umount', os.path.join(rootdir, 'proc')]) self.runcmd(['umount', os.path.join(rootdir, 'dev')]) - self.install_extlinux(rootdev, rootdir) + if failed: + self.install_extlinux(rootdev, rootdir) def install_extlinux(self, rootdev, rootdir): if not os.path.exists("/usr/bin/extlinux"): -- Happy hacking Petter Reinholdtsen
--- End Message ---
--- Begin Message ---Source: vmdebootstrap Source-Version: 0.7-1 We believe that the bug you reported is fixed in the latest version of vmdebootstrap, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Neil Williams <[email protected]> (supplier of updated vmdebootstrap package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Sat, 02 May 2015 20:23:36 +0100 Source: vmdebootstrap Binary: vmdebootstrap Architecture: source amd64 Version: 0.7-1 Distribution: unstable Urgency: medium Maintainer: VMDebootstrap List <[email protected]> Changed-By: Neil Williams <[email protected]> Description: vmdebootstrap - Bootstrap Debian into a (virtual machine) disk image Closes: 742267 776975 782304 782307 Changes: vmdebootstrap (0.7-1) unstable; urgency=medium . * New upstream release for unstable. * Default to armmp kernel variant on armhf. Patches from: Vagrant Cascadian <[email protected]> (Closes: #776975) * Add vmextract helper. * Avoid adding extlinux config when using grub2 from Jan Gerber <[email protected]> (Closes: #742267) * Installing grub with boot partition requires an offset before the first partition. (Closes: #782307) * Only configure console if serial-console is set from Jan Gerber <[email protected]> (Closes: #782304) Checksums-Sha1: 65610c5432a214caa81223fe2c28f6118b032ca6 2118 vmdebootstrap_0.7-1.dsc 7f54c837582ef4fb146ab9b235263a1872031b3b 31428 vmdebootstrap_0.7.orig.tar.gz 04304adbcfdafa215d94a8ef6b770b46f89664d9 3688 vmdebootstrap_0.7-1.debian.tar.xz 4b79938f5c63d974b307ebe6c24aa117367ba497 23842 vmdebootstrap_0.7-1_amd64.deb Checksums-Sha256: a0a88ebd5c7249f50049bb94ebf36df94be21b8d55b038de33aae461329095a4 2118 vmdebootstrap_0.7-1.dsc 23841eb0bc5293933e492926310747af73e1fabd986263146b5a99e3251ff192 31428 vmdebootstrap_0.7.orig.tar.gz 739948d49bf476748f1538682c073e0a95637b76c56a62260017c7a1f3ba9c8e 3688 vmdebootstrap_0.7-1.debian.tar.xz e7db17fc7717d88c88872b8c72462d87a81df5e53da257fbda7fd248b79464f0 23842 vmdebootstrap_0.7-1_amd64.deb Files: ab61e120e674a1de113c60ab2e74cccb 2118 admin extra vmdebootstrap_0.7-1.dsc c8247a687b74394444feaa5f38195f47 31428 admin extra vmdebootstrap_0.7.orig.tar.gz ba1ad54eb8906c4c8a5d9b8714e56dc9 3688 admin extra vmdebootstrap_0.7-1.debian.tar.xz 09f71aeb53a5e2b32658b93996b6a7a1 23842 admin extra vmdebootstrap_0.7-1_amd64.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCAAGBQJVRTFeAAoJEPFn5DyBQ7aCrC8QAIW6eb7ZiSVCSOTgGHLPRbt0 j088ZWCwX+pvZbNxqb3uwlWZye5GdiUAneF+lKTcPBbpQQxCKRJB+u2CldNjsl7+ 7UvGdeDHV0HiahyHWYmAbox2J+RQl7IpIIdxw4um5jEVZFsRfC84BqlC3nkACp3V i1GSjTv3zcNzyPaR29v8yD5Vz6O8e/tWDxBRDLkTbaJZugBO4VubY455CQ1GMkRh UE4AeSD3sXlKjbaX5fPQHKaREqgDobYfrD173XUaofBSX7ivlmHul8aoH0l2zHO4 buvwJsWZnOVdw7L1fuc/rLUEZgWpoGleijCkpQizQNaFngHaf/7KDJ93eekdIrmI x2AJc9rU3mPe+fqKZxgQJmiTkix5U/sA10YejCLQRMXACgGpKmmbPE/niJ9D+PAq Z1OdQxEClsBwHdtRYlAY63wGvCbOC50x7Xkk6hly75+27Pad5DTzYK2BtayIdOd4 W3AIVCJQzRi5VuJj1XZzThosoZWltfaPOwNEqtcxfVV1ZIBu/6QIewTdngKJyBS9 LRrJgjVI5jjfgVfzdZQ0o+SWYtUL+I44+FAtd0yf23luIk2tjtJwhKd//J9wrwNS 0zCTha8HuX3QnQZwmvfaZUiPLMSha3K/rclhXW3z3h2idiv1rtX1qmEHEnkB4Xyx RA7QIMmxMDmagOrdraTU =QpHM -----END PGP SIGNATURE-----
--- End Message ---
