Your message dated Mon, 25 May 2015 21:42:12 +0000 with message-id <[email protected]> and subject line Bug#745963: fixed in rsnapshot 1.3.1-7 has caused the Debian Bug report #745963, regarding rsnapshot: linux_lvm_cmd_lvremove is not silenced (lvcreate is) to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 745963: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=745963 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: rsnapshot Version: 1.3.1-3 Severity: normal Tags: patch Hi, rsnapshot seems to be wrongly patched at one point, hence the linux_lvm_cmd_umount system() call is silenced, but linux_lvm_cmd_lvremove is not. Since only the latter is noisy by default (fix that, lvm guys!), the wrong one is muted. This applies for stable and sid, at least. Patch: --- /usr/bin/rsnapshot 2011-07-09 16:39:45.000000000 +0200 +++ rsnapshot 2014-04-26 20:34:12.000000000 +0200 @@ -3725,38 +3725,38 @@ } } @cmd_stack = (); push(@cmd_stack, $config_vars{'linux_lvm_cmd_umount'}); push(@cmd_stack, $config_vars{'linux_lvm_mountpath'}); print_cmd(@cmd_stack); if (0 == $test) { - # silence gratuitous lvremove output - #$result = system(@cmd_stack); - $result = system(join " ", @cmd_stack, ">/dev/null"); + $result = system(@cmd_stack); if ($result != 0) { bail("Unmount LVM snapshot failed: $result"); } } @cmd_stack = (); push(@cmd_stack, $config_vars{'linux_lvm_cmd_lvremove'}); push(@cmd_stack, '--force'); push(@cmd_stack, $linux_lvm_snapshotname); print_cmd(@cmd_stack); if (0 == $test) { - $result = system(@cmd_stack); + # silence gratuitous lvremove output + #$result = system(@cmd_stack); + $result = system(join " ", @cmd_stack, ">/dev/null"); if ($result != 0) { bail("Removal of LVM snapshot failed: $result"); } } } } # accepts the name of the argument to split, and its value # the name is used for spitting out error messages (note the "... lvremove output" comment, which is obviously placed inside the wrong if(0==$test){} scope) Please fix that, right now I'd get cron mails for every single rsnapshot run (without my patch applied). Cheers, Julius
--- End Message ---
--- Begin Message ---Source: rsnapshot Source-Version: 1.3.1-7 We believe that the bug you reported is fixed in the latest version of rsnapshot, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Guillaume Delacour <[email protected]> (supplier of updated rsnapshot package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Mon, 11 May 2015 22:23:50 +0200 Source: rsnapshot Binary: rsnapshot Architecture: source all Version: 1.3.1-7 Distribution: unstable Urgency: medium Maintainer: Guillaume Delacour <[email protected]> Changed-By: Guillaume Delacour <[email protected]> Description: rsnapshot - local and remote filesystem snapshot utility Closes: 660372 717451 720509 743310 743777 745963 767124 Changes: rsnapshot (1.3.1-7) unstable; urgency=medium . * Remove obsolete conffiles anacron scripts (Closes: #767124) * debian/patches/14_rsync_rsh_quoting.diff: Don't quote ssh_args arguments (Closes: #717451, #743310, LP: #1332753, #1400283) * debian/patches/16_configtest_manpage.diff: Document configtest option (Closes: #720509) * debian/patches/17_linux_lvm_cmd_lvremove_silenced.diff: lvremove is not silenced when using lvm, thanks Julius Seemayer (Closes: #745963), (LP: #1353972) * debian/rules: Skip compression of .pl examples files (Closes: #743777) * debian/patches/18_rsnapreport_rsync_output.diff: Modify regexp to parse rsync output that changes between 3.0.x and 3.1.x, thanks Dominik George * debian/patches/19_cmd_postexec_umount.diff: Allow unmounting of snapshot root by cmd_postexec config option, thanks Mike Gabriel (Closes: #660372) Checksums-Sha1: a8fd17f8706d0bf740cf1a9d3919b626c087791e 2010 rsnapshot_1.3.1-7.dsc a384484e640581d13d5fbd1331ccc59692a45cbb 17096 rsnapshot_1.3.1-7.debian.tar.xz 69be90b01d75fff7bb1ac81f0981d7b02656ae5a 128388 rsnapshot_1.3.1-7_all.deb Checksums-Sha256: b99e0fa831003746a62ff3343f3e0c3ca00780fe8e01d7630066884c6d18cb5e 2010 rsnapshot_1.3.1-7.dsc f4e6632e0dd87d78144b48e312b0b4f3376504ada28c2f5a7d5b738b2636c977 17096 rsnapshot_1.3.1-7.debian.tar.xz 5552e6ee7ff634fc980519a048a82734ec5dc72ae538cbefae584b4d2039c204 128388 rsnapshot_1.3.1-7_all.deb Files: 4f49caa9e1e584c8f6303aa270959fd9 2010 utils optional rsnapshot_1.3.1-7.dsc 0cd1b1d687a4b5494b14dc82fe22ffff 17096 utils optional rsnapshot_1.3.1-7.debian.tar.xz 1b9650132925c9ac2d13cbbcb69f336b 128388 utils optional rsnapshot_1.3.1-7_all.deb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Signed by Ana Guerrero iQIcBAEBCAAGBQJVY4tTAAoJELNGT4lqoVlIMhwP/jZpcBqWsvE3G/QIMAgQ3KoP DhEDOXH3c/eOyoFcUVTXraSXvEqyuCbbCu56QKEqVVOv6VTrS+bEQ16OSuHvd4L5 j+uC8Lp19GuRd1OnLUJ6cYCKN9D6TM4tPY0L3EWxsqQj1eHKDZ9KEDy9ZV5BL/Hp LMWNv/4JinVlH9aCqUaGiZn3TY+3XmnsZ2YDQuw/y46DbPg6FEd0pESl4X0E5MrP s9L01SaVvfI6eh93MbI0JwKy67gMbr7BTuPFLSCTVzbRi29wYsl539poBjkCkb9l 3Dnqi/dPDWQN/2qCK9rzgiZSMsZvUTmMiQGHrHzPkx3XAypSdiQnKZV29u0ckasq p1OISWNaDiNF9UpNS+ot6yXGC2IJp9RPTsSZnHAnHe73oM3MDIKTO+2WLjPeXlBH gGNPQsxf2DOa4rLub8NhKVDok3zxKeMvRMnYp9qiouVU4cIUq0i2cCBBbzypd/Es b3QvpW9NXgIh5m2Rmd2DzK8a4e1anohwgo77Yy3FNE48nJsWGqkE7NxDRNASQLda EHm8fBQRviWhnacjdjW25QZxSEzxgfbIqyutr1zGXUmadv+i72OSE/PZKO+g3q7e Ed3Wx6NJCuaR8K7/3DKWoyCdZwpD4D/JEH3RAM8vr2lZaFepqGBzTKBHQnXJUzuZ ees5sdX8qR2sdZU7Ms7f =oqO4 -----END PGP SIGNATURE-----
--- End Message ---
