Your message dated Thu, 04 Jun 2015 17:20:34 +0000
with message-id <[email protected]>
and subject line Bug#772618: fixed in cwebx 3.52-2
has caused the Debian Bug report #772618,
regarding cwebx FTBFS on btrfs, incorrect test command
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
772618: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=772618
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: cwebx
Severity: important
Tags: patch
cwebx failed to build on the raspbian jessie autobuilders with the
following error. The build was tried twice so I do not belive this was a
fluke.
make[1]: Entering directory '/«PKGBUILDDIR»'
test -s debian/cwebx/usr/bin || mkdir debian/cwebx/usr/bin
mkdir: cannot create directory 'debian/cwebx/usr/bin': File exists
Makefile:143: recipe for target 'install' failed
According to wikpedia test -s checks if a file exists and has a size
greater than 0. We use btrfs on our autobuilders for space-efficient
snapshotting. Doing some testing it seems btrfs reports a size of 0 for
empty directories. So on btrfs if the directory exists and is empty the
command will fail.
I believe the correct fix is to use -e instead of -s. I have tested this
on the raspbian jessie autobuilders and got a successful build.
debdiff attatched, no intent to NMU.
diff -Nru cwebx-3.52/debian/changelog cwebx-3.52/debian/changelog
--- cwebx-3.52/debian/changelog 2014-10-05 18:58:08.000000000 +0000
+++ cwebx-3.52/debian/changelog 2014-12-09 07:43:18.000000000 +0000
@@ -1,3 +1,9 @@
+cwebx (3.52-1+rpi1) jessie-staging; urgency=medium
+
+ * Use test -e instead of test -s to prevent build failing on BTRFS.
+
+ -- Peter Michael Green <[email protected]> Tue, 09 Dec 2014 07:42:51
+0000
+
cwebx (3.52-1) unstable; urgency=medium
* New upstream release
diff -Nru cwebx-3.52/debian/patches/02_fix-build-on-btrfs.diff
cwebx-3.52/debian/patches/02_fix-build-on-btrfs.diff
--- cwebx-3.52/debian/patches/02_fix-build-on-btrfs.diff 1970-01-01
00:00:00.000000000 +0000
+++ cwebx-3.52/debian/patches/02_fix-build-on-btrfs.diff 2014-12-09
07:48:25.000000000 +0000
@@ -0,0 +1,31 @@
+Description: Use test -e instead of test -s to prevent build failing on BTRFS.
+ Btrfs reports a size of 0 for empty directories. Test -s not only checks
+ if a file exists but also if it it's size is nonzero. This causes the makefile
+ to try and create a directory that already exists and fail. The fix is to use
+ -e instead.
+Author: Peter Michael Green <[email protected]>
+
+---
+The information above should follow the Patch Tagging Guidelines, please
+checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
+are templates for supplementary fields that you might want to add:
+
+Origin: <vendor|upstream|other>, <url of original patch>
+Bug: <url in upstream bugtracker>
+Bug-Debian: https://bugs.debian.org/<bugnumber>
+Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
+Forwarded: <no|not-needed|url proving that it has been forwarded>
+Reviewed-By: <name and email of someone who approved the patch>
+Last-Update: <YYYY-MM-DD>
+
+--- cwebx-3.52.orig/Makefile
++++ cwebx-3.52/Makefile
+@@ -140,7 +140,7 @@ clean: mostlyclean
+ MACRODIR=$(prefix)/share/texmf/tex/plain/litprog
+
+ install: ctanglex cweavex
+- test -s $(prefix)/bin || mkdir $(prefix)/bin
++ test -e $(prefix)/bin || mkdir $(prefix)/bin
+ $(CP) ctanglex cweavex $(prefix)/bin
+ cp cweb?mac.tex $(MACRODIR)
+
diff -Nru cwebx-3.52/debian/patches/series cwebx-3.52/debian/patches/series
--- cwebx-3.52/debian/patches/series 2014-10-05 16:57:46.000000000 +0000
+++ cwebx-3.52/debian/patches/series 2014-12-09 07:45:42.000000000 +0000
@@ -1 +1,2 @@
01_x-ify_all_names.diff
+02_fix-build-on-btrfs.diff
--- End Message ---
--- Begin Message ---
Source: cwebx
Source-Version: 3.52-2
We believe that the bug you reported is fixed in the latest version of
cwebx, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Julian Gilbey <[email protected]> (supplier of updated cwebx package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Thu, 04 Jun 2015 17:48:02 +0100
Source: cwebx
Binary: cwebx
Architecture: source amd64
Version: 3.52-2
Distribution: unstable
Urgency: medium
Maintainer: Julian Gilbey <[email protected]>
Changed-By: Julian Gilbey <[email protected]>
Description:
cwebx - C/C++ literate programming system (Marc van Leeuwen's version)
Closes: 772618
Changes:
cwebx (3.52-2) unstable; urgency=medium
.
* Change directory test from test -s to test -d (thanks to Peter Michael
Green for suggested patch; closes: #772618)
Checksums-Sha1:
c64571e563268831783b340960a052ce912a9577 1629 cwebx_3.52-2.dsc
cd90cde6ffcf1bda3c9e3e4d38bc86af2c6c7d73 7244 cwebx_3.52-2.debian.tar.xz
5d36c9a662f510bb2253405c27cf6236180dd523 220464 cwebx_3.52-2_amd64.deb
Checksums-Sha256:
89434019d8c96f9fdfc93462dcbb28d18348be67b9243065a37ebe121222c0c0 1629
cwebx_3.52-2.dsc
bc5220e6bad222e83940aab81d33e09921f8d5e5c7702d609424796583087931 7244
cwebx_3.52-2.debian.tar.xz
8c91d4fc22ac81d26ee863b57df8ba7d739311d16ce2722b3baf47536caa1ca0 220464
cwebx_3.52-2_amd64.deb
Files:
6c679f9027a1a36c41f740a122cda8dc 1629 devel optional cwebx_3.52-2.dsc
2ac7a4a93b4cd76066ee4261f4ce0149 7244 devel optional cwebx_3.52-2.debian.tar.xz
7a83987d26787b2a0b180e2a4bbeaad9 220464 devel optional cwebx_3.52-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBCAAGBQJVcIImAAoJEGlcQpMWwHv+rokP/0qlxp5xdlv+rx4ITkYB047B
2UqFsnb/TQqZTa4YSLANCwQjTuw8359HARGCfYR+3dfPqN7BivvjErtjXqXL49c/
63ATuNhBMdIJkz49CuKC0VCFJ6rOGHFQl59QYc9BaEerGPH/jHY3r5U5UhWx8vgF
eevGGR5Lg6GrLigftN2RiqHmsSPvhdXRWLltXlz7pkH2glLtQZKqgyssMK1kNjHB
4TIhLYWwHP0S9KyMq0xKbqT49hcNndDm1N8hL/mLIeaWDwy8ELAc1FcxYBFA28zF
/JkcZx9HMjHE6npKkO/xjmld1Qhkm6I+ZyqIBcBmLdkJX/ZnVAsgCznYu3b7cERR
vq5onBZ8ZFzjByM+lTiFFns9gnVxDNrO/OQ9mKLXSjp3RqU3vM96gJKsWoM1GkCB
tii5zr5Ort56tVYsFB7rRdqZamK3V2MNQdXlSnfC3Ld+fb+iNcRpURl5faqw3xHS
YePmt4QvZuNL1lA24U9U4j37Zvbc4fiqO9Ary+CaLGY4Jm8RsaKRqZiHXg8qR79p
9hVdyc9hb1T7T4t9D94PBytv0cHOZ9+g2NbnVhFbyYFjD2nk3ZV3nJCm8xnBM8uz
WDj274NpYqRZ4+L5iANZ+cg71kEBGVjLUJM60VftwJEfzrQyCjg4EomEcKWLsmGh
Sgj1nEog0YBpZWmc/6Lm
=xl8Q
-----END PGP SIGNATURE-----
--- End Message ---
