Your message dated Sat, 27 Jun 2015 03:21:41 +0000
with message-id <[email protected]>
and subject line Bug#780308: fixed in zfs-fuse 0.7.0-13
has caused the Debian Bug report #780308,
regarding zfs-fuse: "zfs list -t snapshot" missing entries
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
780308: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=780308
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: zfs-fuse
Version: 0.7.0-12
Severity: important
Tags: upstream patch

Dear Maintainer,

I see exactly the behavior described in 
https://groups.google.com/forum/#!topic/zfs-fuse/-BtjGFUPOyk:

Removing the com.sun:auto-snapshot-desc property as descibed in the 
command by user hornowitz did not help for me, though.

# zfs list -r -t snapshot -H zpool | wc -l
504

# zdb -d zpool | grep "^Dataset .*@"  | wc -l
913

I can list any property of the missing snapshots if I name the snapshot 
on the command line, it exists but is just missing in the output of "zfs 
list -t snapshot <fs>".

After some debugging, I found the root cause in src/lib/libzfs/libzfs_dataset.c:

2425 static int
2426 zfs_do_list_ioctl(zfs_handle_t *zhp, int arg, zfs_cmd_t *zc)
2427 {
2428     int rc;
2429     uint64_t    orig_cookie;
2430
2431     orig_cookie = zc->zc_cookie;
2432 top:
2433     (void) strlcpy(zc->zc_name, zhp->zfs_name, sizeof (zc->zc_name));
2434     rc = ioctl(zhp->zfs_hdl->libzfs_fd, arg, zc);
2435
2436     if (rc == -1) {
2437         switch (errno) {
2438         case ENOMEM:
2439             /* expand nvlist memory and try again */
2440             if (zcmd_expand_dst_nvlist(zhp->zfs_hdl, zc) != 0) {
2441                 zcmd_free_nvlists(zc);
2442                 return (-1);
2443             }


This code assumes ioctl() returns either 0 or -1, but I'm occasionally getting
12 (=ENOMEM) here.  After changing the condition in line 2436 to just "if (rc)"
and recompiling the zfs command the output of "zfs list -r -t snapshot" matches
the output of zdb.


Kind regards,
Michael




-- System Information:
Debian Release: 7.8
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: armhf (armv7l)

Kernel: Linux 3.4.104+ (SMP w/2 CPU cores; PREEMPT)
Locale: LANG=C, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages zfs-fuse depends on:
ii  fuse         2.9.0-2+deb7u1
ii  libaio1      0.3.109-3
ii  libc6        2.13-38+deb7u8
ii  libfuse2     2.9.0-2+deb7u1
ii  libgcc1      1:4.7.2-5
ii  libssl1.0.0  1.0.1e-2+deb7u14
ii  lsb-base     4.1+Debian8+deb7u1
ii  zlib1g       1:1.2.7.dfsg-13

zfs-fuse recommends no packages.

Versions of packages zfs-fuse suggests:
pn  kpartx             <none>
ii  nfs-kernel-server  1:1.2.6-4

-- Configuration Files:
/etc/zfs/zfsrc changed [not included]

-- no debconf information
--- ./src/lib/libzfs/libzfs_dataset.c.orig	2015-03-11 21:36:13.000000000 +0100
+++ ./src/lib/libzfs/libzfs_dataset.c	2015-03-11 21:36:24.000000000 +0100
@@ -2433,7 +2433,7 @@
 	(void) strlcpy(zc->zc_name, zhp->zfs_name, sizeof (zc->zc_name));
 	rc = ioctl(zhp->zfs_hdl->libzfs_fd, arg, zc);
 
-    if (rc == -1) {
+    if (rc) {
 		switch (errno) {
 		case ENOMEM:
 			/* expand nvlist memory and try again */

--- End Message ---
--- Begin Message ---
Source: zfs-fuse
Source-Version: 0.7.0-13

We believe that the bug you reported is fixed in the latest version of
zfs-fuse, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Asias He <[email protected]> (supplier of updated zfs-fuse package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Sat, 27 Jun 2015 10:28:02 +0800
Source: zfs-fuse
Binary: zfs-fuse
Architecture: source amd64
Version: 0.7.0-13
Distribution: unstable
Urgency: medium
Maintainer: Asias He <[email protected]>
Changed-By: Asias He <[email protected]>
Description:
 zfs-fuse   - ZFS on FUSE
Closes: 780308
Changes:
 zfs-fuse (0.7.0-13) unstable; urgency=medium
 .
   * Fix ""zfs list -t snapshot" missing entries" (Closes: #780308)
Checksums-Sha1:
 fe4a87bcdd14fbf659346e712052c2442bf34342 1965 zfs-fuse_0.7.0-13.dsc
 0aa29cc01a518896b6cdd9be723d47f30ddd0b33 24924 zfs-fuse_0.7.0-13.debian.tar.xz
 280af97efae83a433a793e2f1d2e6c339d0ccb5b 705862 zfs-fuse_0.7.0-13_amd64.deb
Checksums-Sha256:
 518221d59933297494b1a4412f178b364eecf65a23caf0ca6393c62f6465aee5 1965 
zfs-fuse_0.7.0-13.dsc
 c877fb9f74d80abe83b1fdaaa0d33b488dac49e9a449afbbbcd0e1daab0a3806 24924 
zfs-fuse_0.7.0-13.debian.tar.xz
 603877832970c74f43edc361c31412c0299e394764c5888122201b124e67406a 705862 
zfs-fuse_0.7.0-13_amd64.deb
Files:
 8f6819bb9e79d4920f4e740096a6cd73 705862 otherosfs optional 
zfs-fuse_0.7.0-13_amd64.deb
 1d5c3e1cbf78e17b3d18dc0a41417844 1965 otherosfs optional zfs-fuse_0.7.0-13.dsc
 f26fd442e103b9ed2b80a6901f2c0c3a 24924 otherosfs optional 
zfs-fuse_0.7.0-13.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVjg5xAAoJEK7JmSstf/GAIAgP/2rEvz515fcDHk4t3nY1C9NO
hiy+eV5Y9kfX57hLPuiURwdGug8NQ6TV1TPBwfyOucAHMAAUf1jPHYjJHnKCuU7A
eq+NtnO3/uaPhYG6+MD8+EnCHsvzIdO21mjLf6PJdjFZYb1IQxbjB1cGdjG+M6Zx
O7i6mPrLf54mQUQ5E4gzpLWo2+iVkeba/5k/bn5tE3DznCm5glXC2isIOiKyBRjM
qwF0RrCo6qZGTShP8Tal7N2DHfrp/tp+KZcKeR7V36vpTW7btyPcuO7rAY8yFipQ
R6L7zrc2dawz3U41Rg0XqkRHyl6+WvUPHmH2siAl63pvXSXNzGKK28uysLuYqdxN
ShMNrdwyJowhDSAifx3F8Pf+FxC6KihvzJEjtUfkhQKyKRjioOwmsd2bzVqeVOM9
37/lfIE3r0be+h7pCAatBncggfZdI+hgpbApTksU4/bPXTf5b5sdh3rw1PVq97yW
37tZlA7dOvISsKnW4xSDq2bGbQNkLY62mcS5Sl7fUkQOosIlku6fLocZERuuwQyQ
jHv3nI5cBhmcNWYoWdfnP61pRRgKAsbozNu66PLvlpf/q8QvTbfn48XkOC0oL0gt
AeS1ZoH/4uAp+ItSNxaQg7Rw8R8Ue1ggdGZEB2Xjwc6klR5fugBqYKZGfnp5dSfD
wgvlF6cL+udOCTx1aQN9
=RPAW
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to